Page MenuHomePhorge
Feed All Stories

Jun 17 2023

valerio.bozzolan added a project to T15455: Register New Account: unsafe password check not working correctly?: Security.

A bit about Security

Jun 17 2023, 15:20 · Security
valerio.bozzolan removed a project from T15144: Conduit transaction.search: Missing "Constraint" section in the documentation: Good Starter Task.

This is probably not so simple. Doing that change causes this problem:

Jun 17 2023, 15:11 · Conduit, User-valerio.bozzolan
valerio.bozzolan awarded T15433: Hovercard of wiki article needs more information a Like token.
Jun 17 2023, 14:19
valerio.bozzolan triaged T15433: Hovercard of wiki article needs more information as Wishlist priority.

I really like the idea here. Nice research :)

Jun 17 2023, 14:19
bekay updated the task description for T15433: Hovercard of wiki article needs more information.
Jun 17 2023, 12:17
aklapper added a comment to T15470: Include user email address in Conduit output when query is run by admin.

The sysop sees the email addresses of recipients already anyway by running an SQL query in the database if they operate the system anyway.
Running SQL queries is what I've been doing so far and it's cumbersome. Thus my request to allow this on an API level.
(I don't mind how MediaWiki behaves as that software covers different use cases.)

Jun 17 2023, 11:19 · Conduit, Discussion Needed, Feature Requests

Jun 16 2023

valerio.bozzolan moved T15256: Diffusion file: add a way to copy permalink from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Jun 16 2023, 23:37 · User-valerio.bozzolan, Diffusion
valerio.bozzolan retitled D25302: Workboard Columns: avoid page reload on Edit > Cancel from Workboard: avoid page reload when clicking on Edit > Cancel
Jun 16 2023, 23:37
valerio.bozzolan moved T15471: Hide Column: the "Undo" button should just close the popup (without reloading the page) from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Jun 16 2023, 23:33 · User-valerio.bozzolan, UX, Workboard
valerio.bozzolan claimed T15471: Hide Column: the "Undo" button should just close the popup (without reloading the page).
Jun 16 2023, 23:33 · User-valerio.bozzolan, UX, Workboard
valerio.bozzolan requested review of D25302: Workboard Columns: avoid page reload on Edit > Cancel.
Jun 16 2023, 23:33
valerio.bozzolan added a revision to T15471: Hide Column: the "Undo" button should just close the popup (without reloading the page): D25302: Workboard Columns: avoid page reload on Edit > Cancel.
Jun 16 2023, 23:33 · User-valerio.bozzolan, UX, Workboard
valerio.bozzolan updated the summary of D25301: Diffusion: add "Permalink" button.
Jun 16 2023, 23:22
valerio.bozzolan updated the test plan for D25301: Diffusion: add "Permalink" button.
Jun 16 2023, 23:11
valerio.bozzolan requested review of D25301: Diffusion: add "Permalink" button.
Jun 16 2023, 23:09
valerio.bozzolan added a revision to T15256: Diffusion file: add a way to copy permalink: D25301: Diffusion: add "Permalink" button.
Jun 16 2023, 23:09 · User-valerio.bozzolan, Diffusion
valerio.bozzolan updated the task description for T15152: MFA: Avoid to having to wait a minute so often, for example right after login.
Jun 16 2023, 21:41 · User-valerio.bozzolan
valerio.bozzolan moved T15467: Document a systemd daemon from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Jun 16 2023, 21:38 · User-valerio.bozzolan, Documentation
valerio.bozzolan moved T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies from Backlog to 🔥 Trap on the User-valerio.bozzolan board.
Jun 16 2023, 21:38 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan closed T15058: Improve page layout for mobile devices as Invalid.

Unsure how to help here :) If this happens again, please reopen. Thanks!

Jun 16 2023, 21:37
valerio.bozzolan added a comment to T15031: Track phabricator's changes.

At the moment I'm manually tracking things in this page:

Jun 16 2023, 21:34
valerio.bozzolan added a comment to D25291: Fix UX regression in Dashboard Tabs Panel.

I double-checked and I'm quite sure that this fixes the issue reported by the kind @speck

Jun 16 2023, 21:31
Sten updated the diff for D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.

Added unit test

Jun 16 2023, 18:57
valerio.bozzolan added a member for Trusted Contributors: Sten.
Jun 16 2023, 18:19
valerio.bozzolan added a comment to D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.

Can I ask how to reproduce this problem?

Jun 16 2023, 18:15
mturdus added a comment to D25267: Fix PHP 8.2 "trim(null)" exception which causes Conduit's user.whoami to fail.
__________________________________ < Overlap detected! Already fixed! > ---------------------------------- \ ^__^ \ (oo)\_______ (__)\ )\/\ ||----w | || ||

Mistery resolved! Git was right. The patch was not successfully land-able since the kind user @aklapper already landed a fix for this 3 days ago

rP1c098c273d06: Fix PHP 8.1 "strlen(null)" exception calling Conduit's user.whoami

Ouch :D

Thank you very much anyway @mturdus - For consolation, you unlocked this command:

arc anoid
Jun 16 2023, 16:33
aklapper renamed T15483: EditEngine: allow to Duplicate a Form from EditEngine: allo to Duplicate a Form to EditEngine: allow to Duplicate a Form.
Jun 16 2023, 16:18 · Affects-Wikimedia
Sten updated the summary of D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.
Jun 16 2023, 16:13
Sten requested review of D25300: Fix strlen() being passed a null in ArcanistUnitConsoleRenderer.php.
Jun 16 2023, 16:10
valerio.bozzolan merged T15127: Allow for reordering of milestones into T15082: Consider allowing milestone columns to be ordered arbitrarily on workboards.
Jun 16 2023, 15:22 · Discussion Needed, Affects-Wikimedia, Workboard
valerio.bozzolan merged task T15127: Allow for reordering of milestones into T15082: Consider allowing milestone columns to be ordered arbitrarily on workboards.
Jun 16 2023, 15:22 · Workboard
valerio.bozzolan awarded T15473: Give embedded image files with transparency (alpha channel) a checkered background a Love token.
Jun 16 2023, 15:19
valerio.bozzolan accepted D25295: Fix PHP 8.1 "strlen(null)" exception on History page of Diffusion repo after setting maintenance mode.

Indeed the maintenance message should always be null or a string. Soft +1 for a week. Then hard +1.

Jun 16 2023, 15:16
valerio.bozzolan added a comment to D25296: Fix PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of Diffusion repo.

Another possible idea: we can approve this change (again, premising that isset($message) and $message !== null are equivalent - but I don't have an opinion - so OK to keep isset($message))

Jun 16 2023, 15:12
valerio.bozzolan accepted D25296: Fix PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of Diffusion repo.

Premising that - to me - there was a bug in the already-existing code.

Jun 16 2023, 14:50
valerio.bozzolan resigned from D25034: support language highlighting for GFM-style code blocks.
Jun 16 2023, 14:26
valerio.bozzolan accepted D25281: Fix Pholio RuntimeException: Undefined variable $dictionary (when adding an empty Inline Comment).

What do you think about this? In this way there are no exceptions in the error log

Jun 16 2023, 14:24
valerio.bozzolan updated the diff for D25281: Fix Pholio RuntimeException: Undefined variable $dictionary (when adding an empty Inline Comment).

propose the soft error

Jun 16 2023, 14:21
valerio.bozzolan triaged T15050: Add Monograms to Phame Post Titles as Wishlist priority.
Jun 16 2023, 13:18
valerio.bozzolan closed T15059: Phabricator doesn't email @outlook.com addresses as Invalid.

I think this problem is infrastructure-related and not software-related. But feel free to reopen attaching more details

Jun 16 2023, 13:18 · phorge.it install
valerio.bozzolan triaged T15473: Give embedded image files with transparency (alpha channel) a checkered background as Low priority.
Jun 16 2023, 13:14
valerio.bozzolan added a comment to T15477: Event names in Calendar monthly view can become unreadable, lack tooltips.

Another compromise could be, on small screens, hiding the time details and enlarge a bit the title. Example:

Jun 16 2023, 13:06
valerio.bozzolan updated the name of F310627: Calendar tablet proposal.png from "Screenshot_2023_06_16_150453.png" to "Calendar tablet proposal.png".
Jun 16 2023, 13:05
valerio.bozzolan triaged T15472: Support Open Graph protocol (at least in Maniphest) as Low priority.

Somehow "Normal" in 2023 I think - at least in Maniphest. But probably not so important.

Jun 16 2023, 13:03 · User-valerio.bozzolan, Affects-Wikimedia, Maniphest
valerio.bozzolan triaged T15470: Include user email address in Conduit output when query is run by admin as Wishlist priority.
Jun 16 2023, 13:02 · Conduit, Discussion Needed, Feature Requests
valerio.bozzolan added a comment to T15470: Include user email address in Conduit output when query is run by admin.

On this I think it does more or less the same as MediaWiki: the sysop does not see the emails of participants, not even via API.

Jun 16 2023, 13:01 · Conduit, Discussion Needed, Feature Requests
valerio.bozzolan triaged T15467: Document a systemd daemon as Low priority.
Jun 16 2023, 12:59 · User-valerio.bozzolan, Documentation
valerio.bozzolan updated the task description for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Jun 16 2023, 12:48 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan triaged T15483: EditEngine: allow to Duplicate a Form as Low priority.
Jun 16 2023, 12:47 · Affects-Wikimedia
valerio.bozzolan added a subtask for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge: T15482: Conduit method for Legalpad signatures.
Jun 16 2023, 12:42 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan added a parent task for T15482: Conduit method for Legalpad signatures: T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Jun 16 2023, 12:42 · Legalpad, Conduit, Affects-Wikimedia
valerio.bozzolan triaged T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge as Low priority.
Jun 16 2023, 12:37 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan triaged T15482: Conduit method for Legalpad signatures as Low priority.
Jun 16 2023, 12:36 · Legalpad, Conduit, Affects-Wikimedia
valerio.bozzolan added a comment to D25038: Conduit column.search: add status, sequence and isDefault to API results.

Are you ready to laaand @20after4

Jun 16 2023, 12:33
aklapper closed T15480: Add serious business string for defrocking a user as Resolved by committing rP478012cd463d: Add serious business string for defrocking a user (remove admin rights).
Jun 16 2023, 11:58
aklapper closed D25298: Add serious business string for defrocking a user (remove admin rights).
Jun 16 2023, 11:58
aklapper committed rP478012cd463d: Add serious business string for defrocking a user (remove admin rights).
Add serious business string for defrocking a user (remove admin rights)
Jun 16 2023, 11:58
valerio.bozzolan updated the summary of D25299: Remarkup Code-block: parse language specifier in markdown.
Jun 16 2023, 10:42
valerio.bozzolan added inline comments to D25299: Remarkup Code-block: parse language specifier in markdown.
Jun 16 2023, 10:36
valerio.bozzolan added a comment to D25299: Remarkup Code-block: parse language specifier in markdown.

(Premising that I liked to write a wall of text against Microsoft, randomly)

Jun 16 2023, 10:33
valerio.bozzolan retitled D25299: Remarkup Code-block: parse language specifier in markdown from Remarkup: add support to code blocks in "GitHub Flavored Markdown" to Remarkup: add support to code blocks in "GitHub/GitLab Flavored Markdown".
Jun 16 2023, 10:30
valerio.bozzolan added inline comments to D25299: Remarkup Code-block: parse language specifier in markdown.
Jun 16 2023, 10:10
valerio.bozzolan updated the diff for D25299: Remarkup Code-block: parse language specifier in markdown.

cover all the cases

Jun 16 2023, 10:06
avivey added a comment to D25299: Remarkup Code-block: parse language specifier in markdown.

I didn't read the whole novel in the description, but keep in mind that remarkup is very performance sensitive, so make sure not to add any complex algorithms.

Jun 16 2023, 10:03
valerio.bozzolan updated the test plan for D25299: Remarkup Code-block: parse language specifier in markdown.
Jun 16 2023, 09:58
valerio.bozzolan updated the title for P16 Test Plan Remarkup code blocks for GitHub Flavored Markdown - D25299 from Test Plan Remarkup code blocks to Test Plan Remarkup code blocks for GitHub Flavored Markdown - D25299.
Jun 16 2023, 09:57
valerio.bozzolan planned changes to D25299: Remarkup Code-block: parse language specifier in markdown.
Jun 16 2023, 09:40
valerio.bozzolan created P16 Test Plan Remarkup code blocks for GitHub Flavored Markdown - D25299.
Jun 16 2023, 09:26
valerio.bozzolan added a revision to T15045: Support SSL/TLS for MariaDB connections: D25276: Add support for secure connections to the database.
Jun 16 2023, 09:23 · Security
valerio.bozzolan accepted D25298: Add serious business string for defrocking a user (remove admin rights).

Tested locally, both the feed and the history log, with without serious business mode

Jun 16 2023, 09:03
valerio.bozzolan updated subscribers of D25267: Fix PHP 8.2 "trim(null)" exception which causes Conduit's user.whoami to fail.
__________________________________ < Overlap detected! Already fixed! > ---------------------------------- \ ^__^ \ (oo)\_______ (__)\ )\/\ ||----w | || ||
Jun 16 2023, 08:03
valerio.bozzolan added a revision to T15469: PHP 8.1 "strlen(null)" exception calling Conduit's user.whoami: D25267: Fix PHP 8.2 "trim(null)" exception which causes Conduit's user.whoami to fail.
Jun 16 2023, 08:00 · PHP 8 support
valerio.bozzolan added a task to D25267: Fix PHP 8.2 "trim(null)" exception which causes Conduit's user.whoami to fail: T15469: PHP 8.1 "strlen(null)" exception calling Conduit's user.whoami.
Jun 16 2023, 08:00
mturdus added a comment to D25267: Fix PHP 8.2 "trim(null)" exception which causes Conduit's user.whoami to fail.

I uncommented a line in the editor executed by arc diff and it seemed to work

Jun 16 2023, 04:32
mturdus updated the diff for D25267: Fix PHP 8.2 "trim(null)" exception which causes Conduit's user.whoami to fail.

Updating D25267: Fix PHP 8.2 "trim(null)" exception which causes Conduit's user.whoami to fail

Jun 16 2023, 04:26

Jun 15 2023

aklapper added a comment to T15480: Add serious business string for defrocking a user.

Just for my curiosity, is serious business mode enabled in Wikimedia?

Yes, because I'd like to allow people to understand what is going on. Not everybody speaks perfectly "omg that's so phunny" English. "Set Sail for Adventure", really?

Jun 15 2023, 22:49
valerio.bozzolan added a comment to D25267: Fix PHP 8.2 "trim(null)" exception which causes Conduit's user.whoami to fail.

OK don't worry, you are almost there!

Jun 15 2023, 21:36
valerio.bozzolan added a comment to D25034: support language highlighting for GFM-style code blocks.

Thank you very much for this change. Hoping to be useful I tried to follow the indications from speck here:

Jun 15 2023, 20:59
valerio.bozzolan requested review of D25299: Remarkup Code-block: parse language specifier in markdown.
Jun 15 2023, 20:55
valerio.bozzolan added a revision to T15481: Support language highlighting for GitHub+StackOverflow+GitLab "Flavored Markdown" code blocks: D25299: Remarkup Code-block: parse language specifier in markdown.
Jun 15 2023, 20:55 · Feature Requests, Remarkup
valerio.bozzolan added a revision to T15481: Support language highlighting for GitHub+StackOverflow+GitLab "Flavored Markdown" code blocks: D25034: support language highlighting for GFM-style code blocks.
Jun 15 2023, 19:49 · Feature Requests, Remarkup
valerio.bozzolan updated the summary of D25034: support language highlighting for GFM-style code blocks.
Jun 15 2023, 19:49
valerio.bozzolan triaged T15481: Support language highlighting for GitHub+StackOverflow+GitLab "Flavored Markdown" code blocks as Low priority.
Jun 15 2023, 19:47 · Feature Requests, Remarkup
valerio.bozzolan awarded T15480: Add serious business string for defrocking a user a Pterodactyl token.
Jun 15 2023, 19:33
valerio.bozzolan added a comment to T15480: Add serious business string for defrocking a user.

Just for my curiosity, is serious business mode enabled in Wikimedia? I think nope

Jun 15 2023, 19:33
aklapper updated the summary of D25298: Add serious business string for defrocking a user (remove admin rights).
Jun 15 2023, 19:25
aklapper requested review of D25298: Add serious business string for defrocking a user (remove admin rights).
Jun 15 2023, 19:22
aklapper added a revision to T15480: Add serious business string for defrocking a user: D25298: Add serious business string for defrocking a user (remove admin rights).
Jun 15 2023, 19:22
aklapper created T15480: Add serious business string for defrocking a user.
Jun 15 2023, 19:20
mturdus added a comment to D25267: Fix PHP 8.2 "trim(null)" exception which causes Conduit's user.whoami to fail.

I'm sorry I didn't know I had to more.

Jun 15 2023, 18:19
valerio.bozzolan added a comment to D25281: Fix Pholio RuntimeException: Undefined variable $dictionary (when adding an empty Inline Comment).

Would you love an amend also here, to try the setError approach?

Jun 15 2023, 16:26
valerio.bozzolan updated the task description for T15472: Support Open Graph protocol (at least in Maniphest).
Jun 15 2023, 10:58 · User-valerio.bozzolan, Affects-Wikimedia, Maniphest
aklapper closed T15479: Update "Google" icon on Phorge OAuth as Resolved by committing rPc300f0e87416: Update Google icon on Auth Provider page.
Jun 15 2023, 10:37
aklapper closed D25297: Update Google icon on Auth Provider page.
Jun 15 2023, 10:37
aklapper committed rPc300f0e87416: Update Google icon on Auth Provider page.
Update Google icon on Auth Provider page
Jun 15 2023, 10:37
valerio.bozzolan accepted D25267: Fix PHP 8.2 "trim(null)" exception which causes Conduit's user.whoami to fail.

Thanks again for this patch

Jun 15 2023, 10:30
valerio.bozzolan accepted D25297: Update Google icon on Auth Provider page.

Tested, works, thanks :)

Jun 15 2023, 10:25
valerio.bozzolan updated the task description for T15479: Update "Google" icon on Phorge OAuth.
Jun 15 2023, 10:20
valerio.bozzolan edited the content of Next Up.
Jun 15 2023, 10:17
valerio.bozzolan edited the content of Next Up.
Jun 15 2023, 10:12