Page MenuHomePhorge

Add Status, sequence and isDefault to the conduit api results for column.search
Needs RevisionPublic

Authored by 20after4 on Sun, Apr 24, 18:29.

Details

Reviewers
0
Group Reviewers
Blessed Committers
Restricted Owners Package(Owns No Changed Paths)
Maniphest Tasks
T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge
Summary

This seems like a fairly obvious oversight with the column.search api.

Knowing

  1. the status (active vs archived)
  2. isDefaultColumn (the one that tasks get dropped in by default)
  3. sequence (order on the workboard)

are all necessary for a lot of things that very sensible real-world api clients need to do when working with columns.

Cherry-picked from https://phabricator.wikimedia.org/rPHABebfe30890b52784d222ec4ed36c05462b2a57f92

Test Plan

Tested on phabricator.wikimedia.org over many months and used by real client apps.

Diff Detail

Repository
rP Phorge
Branch
phorge.it (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 69
Build 69: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Sun, Apr 24, 18:29
20after4 retitled this revision from Add column sequence to the conduit api results for column.search to Add Status, sequence and isDefault to the conduit api results for column.search.Sun, Apr 24, 18:34
20after4 edited the summary of this revision. (Show Details)
0 requested changes to this revision.Sun, May 22, 19:22
0 added a subscriber: 0.
0 added inline comments.
src/applications/project/storage/PhabricatorProjectColumn.php
276

It seems odd to return the strings "0" and "1" for the status. Unless there's a reason to do this, an integer would be more reasonable. Even better would be an array containing the keys "value" and "name", like in a few other status fields.

281

The existing bool fields use the language "True if ..." rather than "Whether ...".

This revision now requires changes to proceed.Sun, May 22, 19:22