In D25696#22447, @valerio.bozzolan wrote:

Maybe relevant but PhabricatorObjectHandleData seems to do some magic

Yes maniphest.edit is the modern way to do it.

Maybe relevant but PhabricatorObjectHandleData seems to do some magic about filling PhabricatorObjectHandle with stuff like the name.

Thanks for the comment

Works on my machine!

Thanks :)

Also update the PhpDoc accordingly

Ignore PHP 8.3.0's new DateMalformedStringException and stick to generic Exception in all cases instead

@taavi: Uhm, thanks! If you have a chance to test D25839 that would be great. :)

Handle whitespace-only task and project titles correctly

This needs rework as the logic currently does not properly handle entering a title consisting of whitespace only. (Outcome gets unpleasant afterwards.)

It might be slightly safer to use PhutilURI, but this is in any case a potentially-unsafe configuration.

https://devina.io/redos-checker says the new regex is still prone to polynomial backtracking, but that can happen only on extremely contrived input, whereas the old one was exponential on a common case.

Fix lint

Digging deeper, the problem is specific to ProjectRemarkupRule::getObjectIDPattern. That returns:

Step 2: Remove irrelevant character class exclusions:

Disentangling that monster regex, step 1:

Indeed https://devina.io/redos-checker says the aformentioned regex is exponential time worst-case

I monkeypatched the code to print preg_last_error when the problematic preg_match returns null. The error is "Backtrack limit exhausted".

Thanks :)

This should be resolved by now in git master

Ah, the mythical Platypus Ornithopter!

Double-accept

In D25823#22340, @keithzg wrote:

... Conversely, arc browse . works for what I expected a pathless invocation to do, and funny enough that doesn't work on Git repos! So we have feature parity ;)

In D25823#22324, @valerio.bozzolan wrote:

Hi @keithzg (and any SVN hacker) do you like the new added Subversion support?

Yep. I'm up-to-date with master as of filing the issue^^.
This textbox isn't a Remarkup field (it's actually a ConpherenceDurableColumnView, which doesn't even have a metadata field in the first place)
In normal Conpherence views, the "Upload file" button works just fine. (except as mentioned in Z1, where reloading the page erases the metadata field)

Thanks. Can you reproduce with "Upload file" button too? If yes, maybe sub-task of: T15106: "Upload file" in remarkup text fields should attach by default

@avivey Thanks for the tip about arguments allow-list in getArguments() https://we.phorge.it/source/arcanist/browse/master/src/workflow/ArcanistLintWorkflow.php$67 but I was not able to use that since here it's using getWorkflowArguments() 🤔 So I've just added a warning. It works lol. Check "BRANCH OPTION NOT AVAILABLE"

found a corner case, fixed

I think that, after the hidden comment is loaded in its bulk, "some more comments" are loaded as context for the hidden comment 🤔 So I guess that extra loading is probably a feature and not a bug.

Wikimedia Foundation has this in production since years. I think it doesn't hurt.

Hi @keithzg (and any SVN hacker) do you like the new added Subversion support?