Differential D25840

mimemailparser: Fix implicitly nullable parameter declarations for PHP 8.4
ClosedPublic
Actions

Authored by aklapper on Tue, Nov 26, 13:53.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPb253675917c6: mimemailparser: Fix implicitly nullable parameter declarations for PHP 8.4

Summary

Backport upstream's https://github.com/php-mime-mail-parser/php-mime-mail-parser/commit/39633e054b4b3290775c5e9b43d3bb8f47128433 for PHP 8.4 compatibility.

Test Plan

Run static code analysis.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Tue, Nov 26, 13:53

Owners added a reviewer: O1: Blessed Committers.Tue, Nov 26, 13:53

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptTue, Nov 26, 13:53

aklapper requested review of this revision.Tue, Nov 26, 13:53

Harbormaster completed remote builds in B1629: Diff 2536.Tue, Nov 26, 13:53

sgtm

This revision is now accepted and ready to land.Tue, Nov 26, 13:59

Closed by commit rPb253675917c6: mimemailparser: Fix implicitly nullable parameter declarations for PHP 8.4. · Explain WhyTue, Nov 26, 14:02

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPb253675917c6: mimemailparser: Fix implicitly nullable parameter declarations for PHP 8.4.

Revision Contents
Changeset List

Path

Size

Packages

externals/

mimemailparser/

MiddlewareStack.php

2 lines

O1: Blessed Committers

2 lines

O1: Blessed Committers

Diff 2539

externals/mimemailparser/MiddlewareStack.php

Loading...

externals/mimemailparser/Parser.php

Loading...