Differential D25773
Fix submitting forms in a new tab using Ctrl+Return Authored by BlankEclair on Aug 13 2024, 05:30.
Details
This commit adds a keydown listener to <input> elements to activate a flag when This commit also modifies the click event listener for buttons to ignore Closes T15914 Open the Advanced Search form, and do Ctrl+Return inside one of the text boxes
Diff Detail
Event TimelineComment Actions Thanks. Tested and it works! no regressions. I really don't know why it works :D really, I need more coffee. Personal approve in the meanwhile. Let's test more intensively in the meantime. Comment Actions Thanks! While it does not work for all and anything (e.g. top bar search button), it is still an improvement when it comes to consistency between mouseclick and return/enter button, so I approve as I haven't seen any fallout and could not find collisions/interference with other existing functionality. (For the records, there is similar code existing in webroot/rsrc/externals/javelin/core/Event.js calling JX.Stratcom.listen() this way.) Please feel free to arc land this branch. Comment Actions @BlankEclair Do you want a little help to land this? Essentially you should be able to run this whenever you want: arc patch D25773 arc land |