Page MenuHomePhorge
Create Task
Maniphest T15914

Doing Ctrl+Enter on forms do not cause them to open in a new tab
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Find a form
  2. Do Ctrl+Enter

Expected behavior:
The results are opened in a new tab

Actual behavior:
The results are opened in the same tab

Screen recording:

Miscellaneous information:
This was reproduced on we.phorge.it at 2024-08-13 02:41:34 UTC. I was also able to reproduce this on a test instance running Phorge 58f1c83a5ac5 and Arcanist 84210cedc6ce.

Ctrl-clicking on the button opens the form in a new tab, so submitting forms in a new tab appears to be an intentional feature.

File which appears responsible: https://we.phorge.it/source/phorge/browse/master/webroot/rsrc/js/core/behavior-form.js;58f1c83a5ac56073a1960772c78c99ece72d4729

Revisions and Commits

rP Phorge
D25773rP0ea95d41a67f Fix submitting forms in a new tab using Ctrl+Return

Related Objects

Event Timeline

BlankEclair created this task.Aug 13 2024, 03:14
Herald added subscribers: Cigaryno, Matthew, chris, tobiaswiese. · View Herald TranscriptAug 13 2024, 03:14
BlankEclair added a revision: D25773: Fix submitting forms in a new tab using Ctrl+Return.Aug 13 2024, 05:30
valerio.bozzolan subscribed.Aug 13 2024, 09:07
aklapper subscribed.EditedAug 18 2024, 18:47

Ctrl-clicking on the button opens the form in a new tab

@BlankEclair: Hmm, at least for the magnifier search button in the top bar search field that doesn't seem the case for me (Firefox, Linux). Do I misunderstand?

Edit: Ah, yes, it works with the "Search" button at the bottom of maniphest/query/advanced/, I see.

BlankEclair added a comment.Aug 19 2024, 06:45
In T15914#19057, @aklapper wrote:

Ctrl-clicking on the button opens the form in a new tab

@BlankEclair: Hmm, at least for the magnifier search button in the top bar search field that doesn't seem the case for me (Firefox, Linux). Do I misunderstand?

Edit: Ah, yes, it works with the "Search" button at the bottom of maniphest/query/advanced/, I see.

Funny enough, that button also sometimes doesn't work for me on Librewolf under Linux. It only happens intermittently though, so I couldn't be too bothered to chase after it.

BlankEclair closed this task as Resolved by committing rP0ea95d41a67f: Fix submitting forms in a new tab using Ctrl+Return.Nov 25 2024, 10:09
BlankEclair claimed this task.
BlankEclair added a commit: rP0ea95d41a67f: Fix submitting forms in a new tab using Ctrl+Return.
valerio.bozzolan mentioned this in Next Up.Tue, Dec 10, 14:03
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0