Page MenuHomePhorge

'arc browse .' should work in git
Open, WishlistPublic

Description

This seems a minor bug report about a corner case in arc browse with a dot . as unique argument.

Kindly reported by Keith from https://we.phorge.it/D25823#22340 - thanks for that nice catch!

Steps to reproduce

On whatever local git repo, like from the Phorge repository, run arc browse .. Example:

cd /home/userlol/LOLCommunityRepos/phorge
arc browse .

What happens

You are redirected to something nonsense like here:

https://we.phorge.it/source/phorge/browse/master/home/userlol/LOLCommunityRepos/phorge

What should happen instead

Something non borked that does not try to expose your local filesystem to the remote Phorge server.

❌ Proposal 1 (maybe nonsense)

It should maybe visit the HEAD commit:

https://we.phorge.it/rARCb3d45c71041478c1410bfae2aaf88a95106cfc5b

✅ Proposal 2

Or, it should visit the homepage:

https://we.phorge.it/source/phorge/browse/master/

From my perspective this makes a lot of sense.

This was very probably the original intention, accordingly to this comment:

https://we.phorge.it/source/arcanist/browse/master/src/browse/query/ArcanistBrowseCommitHardpointQuery.php;29ca3df1122b0ef3bec335db14dfdc903a1e7582$23-27