Phorge

PublicGeneral discussions about Phorge. For long and complex questions, you may want to use Ponder.

• Join Room

I've added a link from that message to https://we.phorge.it/w/irc/ :)

at the risk of sounding cheeky, can i ask if someone would be willing to add me to Trusted Contributors? i occasionally feel like upstreaming tasks from https://phabricator.wikimedia.org/project/view/6/ and that would allow me to do it :p

Yup, added

thanks :)

Can someone provide me with some guidance/docs on how to read the task graph, please? I'm sure that I'm missing something obvious, but my ADHD brain is losing it! Thanks.

Do you have a specific task graph?
The general meaning is: children task (down) are sub-tasks, blocking your current task

As I already tried to say, you are visiting T1, so your point of view is that. To complete it, you have children sub-tasks (pointing down from T1).
You can easily see that you should first complete T140 to be able to close T139, and that you should then complete T139 to complete T1, etc

That frame of thinking actually helps me to make sense of it, so thank you very much! Appreciate it as ever, Bozz.

For that example screenshot: row with yellow background is current task; chevron-down icon in first column means direct subtask, all other ones are indirect subtasks.

This is also helpful! Thanks.

Any chance of an admin approving @chris18890, please?

Done!

Hey all, I'm gonna try cutting new stable and updating this install this week.

Thanks, @chris!

Ouch I forgot another release train for my beloved brand-new destroy workflow, now completely fixed D25772

hmm, just (i) don't be surprised if the site goes down for a few minutes, (ii) notice if the site goes down for long, and (iii) check that any important change in the last almost-year is noted in Next Up.

Uh new stable <3! I think D25963 and D25967 are the only ones on my list making me feel "This should _reeeally_ go in" (though ofc there are more low hanging fruit patches waiting for review).

Can anyone describe the difference between Atoms and Symbols in Diviner in a simple sentence?

P.S. I boldly create a new tag for the event Wikimedia Hackathon 2025 #wmhack-2025 in Istanbul, just to have more creative space to collect some stuff for the local code+review sprint and then archive that tag after the event.

Thanks for the upgrade!

didn't start it yet, system ran out of disk space

uhm :(

If we recover more space, after that, maybe we can recover even more disk space by shutting down web interface and calling OPTIMIZE TABLE phabricator_file.files or whatever its name;

mm, I'm gonna try that

(But don't try if we don't have enough disk space, since it needs disk space to free disk space lool)

I can also just increase the disk size on the linode instance later today. Sorry about that, didn't realize where we were on disk utilization

I've upgraded the install to today's master, so we have a new Phorge.
And probably enough free disk space for several months.

Thanks avivey! And enjoy in production the new filter by token... lol @taavi https://we.phorge.it/token/given/query/imgpytwdtshH/#R

Given we have no release this year yet, this is an opportunity to decide on which version naming we should use: YYYY.ww (YYYY Week ww) or YYYY.mm (mm/YYYY). Until 2015, Phabricator was using YYYY.mm before switching to weekly releases. However, we (Phorge) promote to stable only several times per year.

@avivey: maybe phd is not running

@Cigaryno: Which underlying problem would get solved by potentially changing the current naming scheme? Asking as I don't see a problem (yet).

@aklapper Honestly, the current naming scheme looks fine to me, it's just that Phorge stable releases are several times a year, not weekly (Phab was weekly from 2015 to 2021 with some exceptions) and Phorge is unlikely to have two releases per month (rare exception: security vulnerabilities).
During the beginning (when 2022.35 got promoted), I though Phorge may have weekly releases one day and today I think some may be thinking that Phorge releases could be weekly.

@avivey what's going on? why was the instance broken

phd looks to be running. Some massive activity

@Cigaryno: Ubuntu releases, twice a year, end in .04 and .10. They are not released monthly. So I guess I don't mind if people think that Phorge releases could be weekly. If they want to find out they could go to https://we.phorge.it/w/changelog/ :)

hey, yah, daemons were down.

We had disk issues, and after that I did an upgrade, and after that the daemons were still running, so I'm not sure why they died out.

Also, if the daemons are down, notifications/emails are not being sent...

In Z1#3558, @aklapper wrote:
@Cigaryno: Ubuntu releases, twice a year, end in .04 and .10. They are not released monthly. So I guess I don't mind if people think that Phorge releases could be weekly. If they want to find out they could go to https://we.phorge.it/w/changelog/ :)

Agree with you. Staying on YYYY.ww despite little releases is therefore the equivalent of Ubuntu release twice a year and using .04 and .10 (for April and October).

I've restarted the daemons now, I'm not sure why they stopped.
Maybe I forgot to stop them for the upgrade, and the old ones kept running.

I honestly don't have an opinion on week-number vs month in the version name.
Unless we make the release run automatically on a timer, I doubt we'll ever get more then 3-4 releases a year.

The new user @Chlod is a trusted user, thanks admin for accepting 👍

added (I think)

ihmo we shouldn't change the version scheme unless there are some clear advantage for the new scheme, otherwise it's just going to create some pointless confusion

Looks like https://secure.phabricator.com is dead? Receiving 503. Which is a shame because the old tasks/revisions is very useful for documentary purposes.

When I last checked, the amazon loadbalancer reported 503 Service Unavailable: Back-end server is at capacity; it has been having issues with full diskspace for a while. It's probably AI scraper bots that cause a flood of temporary files from commits and revisions. With some luck the garbage collector gets to them in a few days.

secure.phabricator.com still has valuable content such as some tasks and the changelog.

Aaaand here a Discussion Needed thing maybe interesting, maybe already discussed in secure dot (?): T16060: arc diff: it could auto-claim the Task, if unclaimed

@Cigaryno — I've archived a copy of all tasks + manifest transactions from secure if ever needed. It's easy enough to do the same for historic changelogs if we wanted to

If anyone runs macOS: Your input on removing font smoothing CSS might be welcome in T16059 / D25989

Do we have any guidelines or recommendations how to file Security issues? Am I supposed to manually set the View Policy to a bunch of folks I trust? What's the release process? :-/

You should have a "Create security task" link from the favorites (flag next to your profile picture on the top) that takes you to https://we.phorge.it/maniphest/task/edit/form/1/
It's possible that this form isn't configured properly though.

Argh I completely missed that link, indeed. Thank you!

Could a Blessed Committers take a look at D25955? It would make development a lot easier if that is landed.

I upgraded from Fedora 41 with PHP 8.3 to Fedora 42 with PHP 8.4. Now both Firefox and Chromium only display a "Content Encoding Error" instead of local Phorge. After applying D25887: Remove use of deprecated E_STRICT PHP constant Phorge works again.

Urgh... I cannot even arc diff anymore on PHP 8.4: https://we.phorge.it/D25887#26909

Uhm maybe we need a ./phorge/bin/diviner generate, from arcanist

Yes, I probably forgot to do that...

done

Whooo thanks avivey ⭐ woooo, finally example usages about X.$ and JX.DOM.scry and JX.DOM.find and JX.DOM.findAbove with jQuery-like examples wooo look mum I know Javelin! :O https://we.phorge.it/book/javelin/article/javelin_intro/

@avivey why was the instance down for a few hours?

disk space again. 18 gigs of mysql binlogs in about 2 weeks :(

Could Blessed Committers take a look at D25872? @valerio.bozzolan

Hi,

sorry, I'm on my phone because Home Internet is on break today. I'm typing in Docs and copypasting here.
Super short version: Nuance broke us.

It turns out that there's a broken importer in Nuance - the GitHub importer - that is broken, and that floods the Daemons’ log, which we keep in DB.
That log was expanding faster then the log GC was able to clean it up, and got to around 66 million lines - about 14GB.
Someone also tried to upload a 10gb file a few weeks ago, but I'm not sure how much actual bytes that took. I removed it before checking.
anyway, those were enough to consume our entire disk space, after which Phorge can't connect to the DB and crashes.
And since the bad connector was still up, we were generating garbage logs.

Now, I've stopped Nuance on this install, and I suggest you do the same on other installs. I'll file a ticket and probably just kill the bad code, assuming it doesn't work anyway.
I've also manually cleared the daemon_logevent table, which was over inflated, and the DB’s binlogs, which is another thing that takes lots of space.
Also took the opportunity to look for any possibility-evil files in the DB and only found the large one mentioned above.

And there may be a problem in the log GC code, I'll check more closely.

I'm kind of conflicted about whether it makes sense to keep logs in the db in 2025. I'm a fan of systemd journal and https://grafana.com/oss/loki/

yeah, but then that's another dependency to support...

Avivey - Just out of curiosity, are what are the errors from the GitHub importer? - Something like :"Failed to open stream: HTTP request failed! HTTP/1.1 429 Too Many Requests" ??

They look like this:

<cursor:events.repository> Polling GitHub Repository API endpoint "/repos///events".\n
[2025-02-10 22:16:47] EXCEPTION: (Exception) You must setAccessToken()! at [<arcanist>/src/future/github/PhutilGitHubFuture.php:49]

with different urls.
it looks like it didn't even make the rest call...