oh also something like waitingonviewer() too for status
maybe i can explain what Im trying to do to avoid xy problem. I want a dashboard for differential reviewers which shows the most important things to do and displays nothing the viewer doesn't need to do. This includes revisions the viewer has written (currently on the right) and revisions they need to review on the left. Revisions they have already approved or which another all packages which they are owners of have already been approved should not appear on the left. Revisions they are explicitly requested reivewer of should appear above ones they are implicit on (through an owners package). on the right (for revisions the viewer is an author of) first should contain approved, then changes required, then other revisions
You can use custom Bucket function for sorting revisions based on action/category - that's what the Active Revisions (default) page in Differential currently does (DifferentialRevisionRequiredActionResultBucket). Using custom bucketing is nice because you can make sure each revision shows up only once. On the other hand, you'll need to craft a single query that returns ~all the interesting revisions (You can probably filter some out in the code, though).
You can easily(ish) use Dashboard to control the layout; Make a Query Panel for each part, place them in the right place, etc.
I think this (waitingonviewer?) cannot be expressed using query alone:
- (Hide) Revisions that are in "need review" status, but not from me/any of my packages/projects.
and it's probably better to implement this as a Bucket then as a Reviewers function.
Using Dashboard, you can use 2 different queries for "explicitly requested" vs package/project - use the | Responsible User as viewer() or exact(username)[1] to separate them. Alternatively, a Bucketing function that's similar to what you're asking can probably be added upstream.
[1] There's no exact(viewer()), and also no packages(viewer()), but I think it would be reasonable to add something like that (because viewer() is free). Need to dig more to see if it's hard.
@avivey it looks like we have got viewerprojects() would it be the case of just adding `
diff --git a/src/applications/project/typeahead/PhabricatorProjectOrUserFunctionDatasource.php b/src/applications/project/typeahead/PhabricatorProjectOrUserFunctionDatasource.php index 6a6bc25ee0..11d78ffa5b 100644 --- a/src/applications/project/typeahead/PhabricatorProjectOrUserFunctionDatasource.php +++ b/src/applications/project/typeahead/PhabricatorProjectOrUserFunctionDatasource.php @@ -17,6 +17,7 @@ final class PhabricatorProjectOrUserFunctionDatasource new PhabricatorPeopleDatasource(), new PhabricatorProjectDatasource(), new PhabricatorProjectMembersDatasource(), + new PhabricatorProjectLogicalViewerDatasource(), new PhabricatorProjectUserFunctionDatasource(), ); }
and doing something similar for viewerpackages()
Would anyone have opinions or recommendations how to proceed with slowly updating the PHPMailer copy (see D25723 for a first step)? We have quite some bitrot in upstream code copied into Phorge decades ago. If everyone's too busy or too uninterested or too "this is a PITA to test" (all of that is legitimate!), what could I do? Deploy on my own production instance and let it run for a few weeks and ping again here with "This works in downstream", maybe?
I was gonna try applying D25723 to my personal instance to help test, but I shoulda read Next Up because I first updated to latest master and ran into You are running PHP version '7.2.24-0ubuntu0.18.04.17', which is older than the minimum version, '7.2.25, whoops, well good reminder to finally upgrade that server from Ubuntu 18.04 😅
@keithzg: Thanks! Uhm, I went for 7.2.25 (emphasis on .25) simply because Wordpress also does now: https://we.phorge.it/T15047#19338. You can lower the "$required_version" in support/startup/PhabricatorStartup.php without any problems as long as it is 7.2.something
@aklapper Ah yeah in my scenario it was a good reminder to finally upgrade that server, 18.04 has been out of extended-but-free support since June 2023, and sits abandoned on 7.2.24 if strictly sticking to the official repos and unpaid support. That seems like kinda an arbitrary version for Wordpress to peg to, I wonder if it was literally to avoid having to support stock Ubuntu 18.04, hah! (I don't see anything special about it at https://www.php.net/ChangeLog-7.php#7.2.25 and funny enough https://wordpress.org/about/requirements/ still lists it as "7.2.24+", I wonder if they're distracted ;))
Would anyone be willing to review and rubberstamp D25831 and D25832? Same game as rPdb61eb20. TIA!
Also, if anyone feels like harvesting some low-hanging cleanup fruits, I'd welcome reviews in https://we.phorge.it/differential/?ids=25749,25751,25752,25787,25742#R - thanks! :)
Lol D25363 is ready since 2023 but today is state of the art, I really don't know how to further improve test plan lol
Could someone create a tag for the 2024.35 release, please? https://we.phorge.it/source/arcanist/tags/master/ https://we.phorge.it/source/phorge/tags/master/
Phorge Horoscope:
Aries: Your bold energy is needed! Dive into D25363 and share your insights. Your Calendar experience will inspire others! lol
Taurus: Your practical nature to "seems good to me" will serve you well as you review the patch. Take your time, and carefully consider each line. The Test Plan will pay off in the long run D25823
re: T15956, there's also a secondary bug report I'd like to file since they're 2 different systems, but I'd like to ask before making them separate:
When attaching a file via the upload button or pasting when in a proper Conpherence room, if you reload the page, the metadata is lost & upon submission, files are not attached.
I think the answer is, propose a patch :D or at least a task
This is mostly from a user perspective as I would like to use Facts. I am not a developer (I joined with the aim to contribute to the infra side of things such as T15025 and Q148 since that is more my area) so don't think I can contribute in that way. I have done all the searching I can but I cannot find a way to create a chart in Facts, should I be able to do that currently, or is it still being developed?
If you want something simple to copy I can suggest to look at this example
https://we.phorge.it/fact/chart/IjqAU8i23.7S/
https://we.phorge.it/source/phorge/browse/master/src/applications/fact/engine/PhabricatorDemoChartEngine.php
This component is surely not plug&play, but at least you can play :D
Other Facts hacky things in that directory
This is why I have trust issues
CVE-2024-48990 https://www.qualys.com/2024/11/19/needrestart/needrestart.txt
the Python adapter of needrestart takes a user-space envvar (PYTHONPATH) and just runs it as root when you run apt upgrade.
Could someone accept the regression fix in https://we.phorge.it/D25839 ? Reporter says that it works for him. TIA!
Why I cannot see this anymore?
https://we.phorge.it/D25839
This user, so probably spammer 🌈 https://we.phorge.it/p/3tayesh/
(author was aklapper)
There's exactly one other hidden revisions (Out of 845), although there are 2 that are only visible to Trusted Contributors.
The hidden one is D25604.
Yeah you discovered D25604, was ancient private stub who is D25363 since last hot July 2023
I think it could be nice to introduce a permission such like "has verified email". So we can set that as default Edit permission, for most things, I think
@aklapper: is it a question to me? <3 I was thinking that it could be nice to be able to:
- keep registration without verification (false in auth.require-email-verification)
- but have most edits with mandatory email verification (so, a new policy I guess)
I think the answer is "maybe yes but too complicated lol"
BTW maybe Microsoft is discarding our emails also because of this T15036: Phorge upstream mail should not use @upstream.phorge.dev addresses
Because of T15036 I think ihih
I don't get why [[ /\evil.com ]] should become a link. It's in our unit tests as desired situation
https://we.phorge.it/source/phorge/browse/master/src/infrastructure/markup/remarkup/__tests__/remarkup/link-noreferrer.txt
I mean, it becomes an absolute link to https://evil.com/
OK no, sorry, I'm stupid. It's Firefox that expands that
https://we.phorge.it/w/changelog/next_up/#form-submission-in-new-tab
isn't this supposed to be ctrl+enter?
Thanks, fixed, sorry 💃🏼
Proudly by mouse hackers
i'm both a mouse and a keyboard hacker xD
I suspect that's the reason why the test plan was not working for me LOL
xD how-
If someone feels like running grep, https://we.phorge.it/differential/?ids=25752,25749,25742#R is some long hanging cleanup fruit welcoming reviews
i just realized that the video in https://we.phorge.it/w/changelog/next_up/#form-submission-in-new-tab shows it not working
here's a new one:
and also, slight grammar fix:
The forms can be submitted in a new tab with Ctrl-enter. Proudly by keyboard hackers.
Forms can now be submitted in a new tab with CTRL+enter. Proudly by keyboard hackers.
oh, you can't quite easily get the file from that
here: F2670828
Why was not working? not visible?
it showed ctrl+enter opening the search results in the current tab, not a new one
also, what chat is more suitable for heavy traffic/slight banter? Z1: Phorge or Z5: Phorge (flame)
Indeed you can flame in Z5, enjoy its description :)
does anyone know how to properly tackle T15972: Add config option for maximum file size? (as in, know where to modify specifically that fully works)
So we are trying to remove some very large files (say up to 11gb) that are eating up all the disk space for our install, and in at least one case we hit the error described in T15125 but either way it seems that the files aren’t being deleted on disk, and phorge’s file structure makes it hard to delete them manually. So we are trying to find some way to fully delete.