Phorge

PublicGeneral discussions about Phorge. For long and complex questions, you may want to use Ponder.

• Join Room

@aklapper: is it a question to me? <3 I was thinking that it could be nice to be able to:

• keep registration without verification (false in auth.require-email-verification)
• but have most edits with mandatory email verification (so, a new policy I guess)

I think the answer is "maybe yes but too complicated lol"

Why not just require email verification then, instead of adding more code complexity to maintain for years to come? I guess I've personally never understood why /not/ requiring a valid email address seems important for some installations :)

Because of T15036 I think ihih

+1. That will drive potential contributors away with at least two major providers discarding verification emails.

I don't get why [[ /\evil.com ]] should become a link. It's in our unit tests as desired situation
https://we.phorge.it/source/phorge/browse/master/src/infrastructure/markup/remarkup/__tests__/remarkup/link-noreferrer.txt

When/where was this file created?
https://we.phorge.it/source/phorge/history/master/src/infrastructure/markup/remarkup/__tests__/remarkup/link-noreferrer.txt

https://secure.phabricator.com/D19117

https://we.phorge.it/w/changelog/next_up/#form-submission-in-new-tab
isn't this supposed to be ctrl+enter?

Thanks, fixed, sorry 💃🏼

Proudly by mouse hackers

i'm both a mouse and a keyboard hacker xD

I suspect that's the reason why the test plan was not working for me LOL

xD how-

If someone feels like running grep, https://we.phorge.it/differential/?ids=25752,25749,25742#R is some long hanging cleanup fruit welcoming reviews

i just realized that the video in https://we.phorge.it/w/changelog/next_up/#form-submission-in-new-tab shows it not working
here's a new one:

and also, slight grammar fix:

The forms can be submitted in a new tab with Ctrl-enter. Proudly by keyboard hackers.

Forms can now be submitted in a new tab with CTRL+enter. Proudly by keyboard hackers.

Why was not working? not visible?

it showed ctrl+enter opening the search results in the current tab, not a new one

also, what chat is more suitable for heavy traffic/slight banter? Z1: Phorge or Z5: Phorge (flame)

Indeed you can flame in Z5, enjoy its description :)

does anyone know how to properly tackle T15972: Add config option for maximum file size? (as in, know where to modify specifically that fully works)

So we are trying to remove some very large files (say up to 11gb) that are eating up all the disk space for our install, and in at least one case we hit the error described in T15125 but either way it seems that the files aren’t being deleted on disk, and phorge’s file structure makes it hard to delete them manually. So we are trying to find some way to fully delete.

maybe backup - remove - restore? I think there's a script that will only copy out the used data. Or maybe it's the storage engine migration script.

Does cloning the rP and rARC repositories from this install clone the stable or master branch?

Both, but the default checkout is master.

How to instead clone the stable branch? I know setting the branch to stable on GitHub and clicking on the download ZIP button there is the easy way, but I'd like to clone using git bash (it doesn't matter if from the GitHub clone).

git clone -b stable <uri>

To commit on Arcanist, do I type arc diff "Replace some Phabricator references in PhabricatorStartup.php" or I remove the quotes?

arc diff, to commit all files,
or arc diff file1 file2 to commit these files

It is failing to patch with 6 rejects (shows Rejected hunk 6 times).

Forget the rejects error, I switched to arc land -D25857 but there is a merge conflict, so

Typing arc land --revision D25857, Git asks for we.phorge.it credentials, typing them (even with MFA disabled), it returns error 403.

I suppose you are working on the master directly. Ideally, don't work in master.

Keep the master in sync with upstream. Do changes in other local git branches.

That's simple. If you want to totally reset your master, do this:

git fetch
git reset --hard origin/master

If you want to download again your changes, do this as I said:

arc patch D25857
arc diff
arc diff
arc diff
arc land

(Note, arc land without any argument)

If you want to work on something else, do this instead:

git branch   featurelol1
git checkout featurelol1
arc diff
arc diff
arc diff
arc diff
arc diff
arc land # when approved

If you want to work on something else, repeat above.

If you want to focus on something else:

git checkout featurelol2
arc diff
arc diff
arc diff

git checkout featurelol1
arc diff
arc diff
arc diff

So with git branch a you create a branch, with git checkout you switch branch.

Useful git features that allows you to don't touch master and avoid extra complications when proposing changes

To Subversion users: enjoy D25823 \o/

Do those actualyy exist? I thought they were a bedtime story

@valerio.bozzolan For arc diff, should I use origin or master?

I changed the tag color for Mobile to violet to distinguish it from appliction-related tags.

👍

Re: cloning from here vs GitHub, GH should be much faster because they have multiple sites and clouds and stuff.
The GH repos are mirrors of the ones here; Any commit made should be available in GH a few seconds later (but we had some problems with that before).
You can't land (push) to GH, but I think arc land will know to handle that anyway.

T15207: Don't you think only admins should create Legalpad documents?

No; "admin" should be considered more of "janitor" then "super owner".

ho, on this install specifically - yeah, maybe. I've set it to Trusted Contributors for now.

Maybe we need an example Subversion repository here, with just a README, to test D25823 in this production. Otherwise I think nobody will test

mm, probably.
We'll need to install svn first :)

Yah! so we can apt install svn for extra easy lazy fun (not really critical for nothing) - T15983

Anybody at next FOSDEM for a small meetup with laptops?
https://fosdem.org/2025/

Are there too many jokes in the new Diviner documentation of the new project destruction workflow D25772 ?
Feel free to say so. But also please indicate what should be removed lol

I should be at Fosdem

@Arkus404: please stop tests, or your account may be disabled

hmm is it somehow possible to upload a patch that depends on D25863 without landing that one first?

Yep, create a branch starting from your patch, and arc diff that, with this trick: arc diff HEAD as extra care I think

Interesting. In GitLab.com the "this task depends on that" is usually "not available for the current subscription tier".

I am unable to land D25857 using arc land and I get error 403 after typing my we.phorge.it credentials on the Git credentials prompt.

Click here on Clone then Manager Password https://we.phorge.it/source/phorge/
The git has a dedicated "VCS" password

@valerio.bozzolan Thanks for the help!

How do I make git prompt me for a new VCS password. After changing it, I don't get prompted for my username and VCS password. Instead, I get error 403.

I had to revert to my old (insecure) VCS password to run arc land to D25874. Still not sure on making Git ask for credentials for a Phorge install.

If it's windows, search for credential manager in the start menu and then delete / change the relevant credential. There may be more than one.

Could a Blessed Committers review D25877?

why didn't you set the Reviewers field on it?

I can't land as the push policy for rHP is Blessed Committers. Could it be lowered to Trusted Contributors?

@avivey

yeah, sure

Thanks!

I'd appreciate if someone could accept https://we.phorge.it/D25885 . Looks like I again screwed up somehow when rebasing (Would love to see "bin/celerity map" run somehow automagically)

Are you still able to run ./bin/diviner generate in latest master arcanist/phorge locally?

OK nothing, I've just a monster query running since hours in my laptop on diviner_liveatom and stucking everything (even if it does not seem a good news lol)

Do you know how often should this install be updated to the latest master commits (T15092)? How would Almanac, Drydock, and/or Harbormaster be used for this?

I'd welcome your opinionated, heated arguments on https://we.phorge.it/T15998 (adding an "Authored Tasks" item to the user profile menu panel) in the spectrum between "omg yesh lol" and "hell no!!!1". TIA!

Do you know how often should this install be updated to the latest master commits

Whenever I feel like doing it, which is usually the same time as we promote to stable.

Should the .gitignore file in both rP and rARC have the entry ./vscode/settings.json by default to help users with the CRLF end of line problem (like me)?

I'd be in favor of actually the whole .vscode directory and maybe even .code-workspace being in .gitignore. Alternatively, including an .editorconfig or even some a settings file for vscode (and other editors) might be really helpful, too.