Phorge

PublicGeneral discussions about Phorge. For long and complex questions, you may want to use Ponder.

• Join Room

Lol D25363 is ready since 2023 but today is state of the art, I really don't know how to further improve test plan lol

Crossing fingers that I find time to test it in the next two weeks when I took some workdays off. If not please gently slap me

Could someone create a tag for the 2024.35 release, please? https://we.phorge.it/source/arcanist/tags/master/ https://we.phorge.it/source/phorge/tags/master/

Done, sorry

Phorge Horoscope:
Aries: Your bold energy is needed! Dive into D25363 and share your insights. Your Calendar experience will inspire others! lol

Taurus: Your practical nature to "seems good to me" will serve you well as you review the patch. Take your time, and carefully consider each line. The Test Plan will pay off in the long run D25823

re: T15956, there's also a secondary bug report I'd like to file since they're 2 different systems, but I'd like to ask before making them separate:
When attaching a file via the upload button or pasting when in a proper Conpherence room, if you reload the page, the metadata is lost & upon submission, files are not attached.

Hey I have a question regarding the status of the Facts application, where is the best place to ask that?

I think the answer is, propose a patch :D or at least a task

This is mostly from a user perspective as I would like to use Facts. I am not a developer (I joined with the aim to contribute to the infra side of things such as T15025 and Q148 since that is more my area) so don't think I can contribute in that way. I have done all the searching I can but I cannot find a way to create a chart in Facts, should I be able to do that currently, or is it still being developed?

If you want something simple to copy I can suggest to look at this example
https://we.phorge.it/fact/chart/IjqAU8i23.7S/
https://we.phorge.it/source/phorge/browse/master/src/applications/fact/engine/PhabricatorDemoChartEngine.php

This component is surely not plug&play, but at least you can play :D

Awesome, I will have a play, thanks :)

This is why I have trust issues

CVE-2024-48990 https://www.qualys.com/2024/11/19/needrestart/needrestart.txt

the Python adapter of needrestart takes a user-space envvar (PYTHONPATH) and just runs it as root when you run apt upgrade.

@avivey wow that's terrible

easy fix: sudo apt remove needrestart

Could someone accept the regression fix in https://we.phorge.it/D25839 ? Reporter says that it works for him. TIA!

Why I cannot see this anymore?
https://we.phorge.it/D25839

Looks like the user hid it from the world

This user, so probably spammer 🌈 https://we.phorge.it/p/3tayesh/

arg.

fixed for now.

There's exactly one other hidden revisions (Out of 845), although there are 2 that are only visible to Trusted Contributors.
The hidden one is D25604.

Yeah you discovered D25604, was ancient private stub who is D25363 since last hot July 2023

I think it could be nice to introduce a permission such like "has verified email". So we can set that as default Edit permission, for most things, I think

Maybe we just require all accounts to verify email. I just disabled about 10 unverified all with names and emails that look like garbage

"has verified email" is basically existing auth.require-email-verification ?

Yeah, it'll just prevent anyone with Microsoft as their email host from registering -- Outlook has historically liked to eat our emails instead of delivering them. Perils of self-hosted email :-/

@aklapper: is it a question to me? <3 I was thinking that it could be nice to be able to:

• keep registration without verification (false in auth.require-email-verification)
• but have most edits with mandatory email verification (so, a new policy I guess)

I think the answer is "maybe yes but too complicated lol"

Why not just require email verification then, instead of adding more code complexity to maintain for years to come? I guess I've personally never understood why /not/ requiring a valid email address seems important for some installations :)

Because of T15036 I think ihih

+1. That will drive potential contributors away with at least two major providers discarding verification emails.

I don't get why [[ /\evil.com ]] should become a link. It's in our unit tests as desired situation
https://we.phorge.it/source/phorge/browse/master/src/infrastructure/markup/remarkup/__tests__/remarkup/link-noreferrer.txt

When/where was this file created?
https://we.phorge.it/source/phorge/history/master/src/infrastructure/markup/remarkup/__tests__/remarkup/link-noreferrer.txt

https://secure.phabricator.com/D19117

https://we.phorge.it/w/changelog/next_up/#form-submission-in-new-tab
isn't this supposed to be ctrl+enter?

Thanks, fixed, sorry 💃🏼

Proudly by mouse hackers

i'm both a mouse and a keyboard hacker xD

I suspect that's the reason why the test plan was not working for me LOL

xD how-

If someone feels like running grep, https://we.phorge.it/differential/?ids=25752,25749,25742#R is some long hanging cleanup fruit welcoming reviews

i just realized that the video in https://we.phorge.it/w/changelog/next_up/#form-submission-in-new-tab shows it not working
here's a new one:

and also, slight grammar fix:

The forms can be submitted in a new tab with Ctrl-enter. Proudly by keyboard hackers.

Forms can now be submitted in a new tab with CTRL+enter. Proudly by keyboard hackers.

Why was not working? not visible?

it showed ctrl+enter opening the search results in the current tab, not a new one

also, what chat is more suitable for heavy traffic/slight banter? Z1: Phorge or Z5: Phorge (flame)

Indeed you can flame in Z5, enjoy its description :)

does anyone know how to properly tackle T15972: Add config option for maximum file size? (as in, know where to modify specifically that fully works)

So we are trying to remove some very large files (say up to 11gb) that are eating up all the disk space for our install, and in at least one case we hit the error described in T15125 but either way it seems that the files aren’t being deleted on disk, and phorge’s file structure makes it hard to delete them manually. So we are trying to find some way to fully delete.

maybe backup - remove - restore? I think there's a script that will only copy out the used data. Or maybe it's the storage engine migration script.

Does cloning the rP and rARC repositories from this install clone the stable or master branch?

Both, but the default checkout is master.

How to instead clone the stable branch? I know setting the branch to stable on GitHub and clicking on the download ZIP button there is the easy way, but I'd like to clone using git bash (it doesn't matter if from the GitHub clone).

git clone -b stable <uri>

To commit on Arcanist, do I type arc diff "Replace some Phabricator references in PhabricatorStartup.php" or I remove the quotes?

arc diff, to commit all files,
or arc diff file1 file2 to commit these files

It is failing to patch with 6 rejects (shows Rejected hunk 6 times).

Forget the rejects error, I switched to arc land -D25857 but there is a merge conflict, so

Typing arc land --revision D25857, Git asks for we.phorge.it credentials, typing them (even with MFA disabled), it returns error 403.

I suppose you are working on the master directly. Ideally, don't work in master.

Keep the master in sync with upstream. Do changes in other local git branches.

That's simple. If you want to totally reset your master, do this:

git fetch
git reset --hard origin/master

If you want to download again your changes, do this as I said:

arc patch D25857
arc diff
arc diff
arc diff
arc land

(Note, arc land without any argument)

If you want to work on something else, do this instead:

git branch   featurelol1
git checkout featurelol1
arc diff
arc diff
arc diff
arc diff
arc diff
arc land # when approved

If you want to work on something else, repeat above.

If you want to focus on something else:

git checkout featurelol2
arc diff
arc diff
arc diff

git checkout featurelol1
arc diff
arc diff
arc diff

So with git branch a you create a branch, with git checkout you switch branch.

Useful git features that allows you to don't touch master and avoid extra complications when proposing changes

To Subversion users: enjoy D25823 \o/

Do those actualyy exist? I thought they were a bedtime story

@valerio.bozzolan For arc diff, should I use origin or master?

I changed the tag color for Mobile to violet to distinguish it from appliction-related tags.

👍

Re: cloning from here vs GitHub, GH should be much faster because they have multiple sites and clouds and stuff.
The GH repos are mirrors of the ones here; Any commit made should be available in GH a few seconds later (but we had some problems with that before).
You can't land (push) to GH, but I think arc land will know to handle that anyway.

T15207: Don't you think only admins should create Legalpad documents?

No; "admin" should be considered more of "janitor" then "super owner".

ho, on this install specifically - yeah, maybe. I've set it to Trusted Contributors for now.

Maybe we need an example Subversion repository here, with just a README, to test D25823 in this production. Otherwise I think nobody will test

mm, probably.
We'll need to install svn first :)

Yah! so we can apt install svn for extra easy lazy fun (not really critical for nothing) - T15983

Anybody at next FOSDEM for a small meetup with laptops?
https://fosdem.org/2025/

Are there too many jokes in the new Diviner documentation of the new project destruction workflow D25772 ?
Feel free to say so. But also please indicate what should be removed lol

I should be at Fosdem