back in the phabricator days we needed to have two domains: one for the web interface and one for serving files.
Is that still the case? I'm looking at https://we.phorge.it/book/phorge/article/installation_guide/ and it suggests "a domain".
Would anyone be willing to give the four lines in https://we.phorge.it/D25694 another review? TIA
Also, would anyone share opinions in+on T15882: When archiving a project, reset its default menu item to Profile / D25731? Because if folks think it's a bad idea (maybe D25774: Strike through archived projects in navigation crumbs makes more sense?) I'm happy to abandon and patch in our downstream instance. Thanks! :)
Maybe soon a good moment for the release candidate, looking at our cute changelog size
Where's a good point to cut the RC, @valerio.bozzolan/ @aklapper ?
I would say to include b02615bd5027 - so keeping out d4d620fa6df1 that may need further testing from master users from different browser webs
Thanks. Aaand... announced in the non-official mastodon lol https://fosstodon.org/@phorge/113039127738202977
I love that all these damn "Unknown Object" are disappeared now
Ops we forgot to check how many rows we had in prod. But what about now?
EXPLAIN SELECT * FROM phabricator_file.file;
EXPLAIN SELECT * FROM phabricator_file.file_attachment;
P.S. it's 2024 and installing the forum Discourse is still broken if you have port 80 already used 🌈 I guess old-things 'n PHP are still designed better than popular sparkling Ruby things
Could someone set up https://we.phorge.it/w/changelog/next_up/ to list changes after https://we.phorge.it/w/changelog/2024.35/ ? (Sorry, never done that before, that's why I'm asking)
Done I think
https://we.phorge.it/p/THYDUX/ looks like a spammer based on their last acitivity.
Does anybody know the origin of this code? https://secure.phabricator.com/D20774
I probably need some help to write some documentation "in the style of Phabricator" but without exxagerating .
(I cannot access https://we.phorge.it/D20774 and maybe that is totally fine. Just saying.)
Thanks speck. I was trying to blame this https://secure.phabricator.com/D20774 - because I was not able to find its origin - that is this \o/ https://secure.phabricator.com/D20773 (lol - it was quite evident from the commit msg)
I was talking with Andre. Who pay the bills of phorge VPS and domain? Can we donate something to this person? or at least say "thank you" to the right person. lol
BTW since "phorge.it" "seems Italian" to some people because of that ".it" lol, if we need a quick fiscal sponsor, I would be glad to offer Italian Linux Society; so, to expose PayPal and bank donations, and cumulate an amount to pay bills for this project. Feasible to propose to my board if there is interest. It is not the most nonsensical thing we have done.
The VPS is out of my Linode account. The it domain was originally registered by @deadalnix (EU-based and was eligible to make the initial domain purchase) although I believe that @avivey is mostly the one who maintains that nowadays
Uh thanks! Hoping to be useful I've wrote down these here so I don't ask again tomorrow because of my short memory lol Internal Documentation
At this point user Wikivu won a cute spam ban I guess
hi x3.14
hey I would like to do some more advanced things with queries than I think is currently possible for example I would like a differential dashboard which queries for reviewers: packages(viewer()) and I would like to do things like filter out revisions which have been approved by viewer(). please let me know if there is currently a way to do this. I think the current query language is relatively limiting but I may not be aware of all the quirks
I'll try to find the code I used to make T15512#15803 - IIRC, the language will allow for that, but it needs a new class for each function (packages()) times each possible-argument (viewer()); And possibly, each indirection requires a synchronized call to the DB to be resolved, so reviewers: members(projects(viewer())) will:
- get viewer() for free,
- round trip for projects(),
- another one for members(),
- and then build the real query (reviewers in (%Ls)) and run that.
"DB Round-trip" is, arguably, the slowest part in the Phorge experience, and we don't have a good way to optimize this particular flow. And once you allow users to nest queries arbitrarily, they will.
yea was having a little look at the code and it feels like its not the easiest thing to implement. I tried patching a few things to add a new function which I think would work something like viewerpackages() but obviously that isn't terribly flexible
I think exactviewer() for responsible users and viewerpackages() for reviewers would be all that I would require for my needs
oh also something like waitingonviewer() too for status
maybe i can explain what Im trying to do to avoid xy problem. I want a dashboard for differential reviewers which shows the most important things to do and displays nothing the viewer doesn't need to do. This includes revisions the viewer has written (currently on the right) and revisions they need to review on the left. Revisions they have already approved or which another all packages which they are owners of have already been approved should not appear on the left. Revisions they are explicitly requested reivewer of should appear above ones they are implicit on (through an owners package). on the right (for revisions the viewer is an author of) first should contain approved, then changes required, then other revisions
You can use custom Bucket function for sorting revisions based on action/category - that's what the Active Revisions (default) page in Differential currently does (DifferentialRevisionRequiredActionResultBucket). Using custom bucketing is nice because you can make sure each revision shows up only once. On the other hand, you'll need to craft a single query that returns ~all the interesting revisions (You can probably filter some out in the code, though).
You can easily(ish) use Dashboard to control the layout; Make a Query Panel for each part, place them in the right place, etc.
I think this (waitingonviewer?) cannot be expressed using query alone:
- (Hide) Revisions that are in "need review" status, but not from me/any of my packages/projects.
and it's probably better to implement this as a Bucket then as a Reviewers function.
Using Dashboard, you can use 2 different queries for "explicitly requested" vs package/project - use the | Responsible User as viewer() or exact(username)[1] to separate them. Alternatively, a Bucketing function that's similar to what you're asking can probably be added upstream.
[1] There's no exact(viewer()), and also no packages(viewer()), but I think it would be reasonable to add something like that (because viewer() is free). Need to dig more to see if it's hard.
@avivey it looks like we have got viewerprojects() would it be the case of just adding `
diff --git a/src/applications/project/typeahead/PhabricatorProjectOrUserFunctionDatasource.php b/src/applications/project/typeahead/PhabricatorProjectOrUserFunctionDatasource.php index 6a6bc25ee0..11d78ffa5b 100644 --- a/src/applications/project/typeahead/PhabricatorProjectOrUserFunctionDatasource.php +++ b/src/applications/project/typeahead/PhabricatorProjectOrUserFunctionDatasource.php @@ -17,6 +17,7 @@ final class PhabricatorProjectOrUserFunctionDatasource new PhabricatorPeopleDatasource(), new PhabricatorProjectDatasource(), new PhabricatorProjectMembersDatasource(), + new PhabricatorProjectLogicalViewerDatasource(), new PhabricatorProjectUserFunctionDatasource(), ); }
and doing something similar for viewerpackages()
Would anyone have opinions or recommendations how to proceed with slowly updating the PHPMailer copy (see D25723 for a first step)? We have quite some bitrot in upstream code copied into Phorge decades ago. If everyone's too busy or too uninterested or too "this is a PITA to test" (all of that is legitimate!), what could I do? Deploy on my own production instance and let it run for a few weeks and ping again here with "This works in downstream", maybe?
I was gonna try applying D25723 to my personal instance to help test, but I shoulda read Next Up because I first updated to latest master and ran into You are running PHP version '7.2.24-0ubuntu0.18.04.17', which is older than the minimum version, '7.2.25, whoops, well good reminder to finally upgrade that server from Ubuntu 18.04 😅
@keithzg: Thanks! Uhm, I went for 7.2.25 (emphasis on .25) simply because Wordpress also does now: https://we.phorge.it/T15047#19338. You can lower the "$required_version" in support/startup/PhabricatorStartup.php without any problems as long as it is 7.2.something
@aklapper Ah yeah in my scenario it was a good reminder to finally upgrade that server, 18.04 has been out of extended-but-free support since June 2023, and sits abandoned on 7.2.24 if strictly sticking to the official repos and unpaid support. That seems like kinda an arbitrary version for Wordpress to peg to, I wonder if it was literally to avoid having to support stock Ubuntu 18.04, hah! (I don't see anything special about it at https://www.php.net/ChangeLog-7.php#7.2.25 and funny enough https://wordpress.org/about/requirements/ still lists it as "7.2.24+", I wonder if they're distracted ;))
Would anyone be willing to review and rubberstamp D25831 and D25832? Same game as rPdb61eb20. TIA!
Also, if anyone feels like harvesting some low-hanging cleanup fruits, I'd welcome reviews in https://we.phorge.it/differential/?ids=25749,25751,25752,25787,25742#R - thanks! :)
Lol D25363 is ready since 2023 but today is state of the art, I really don't know how to further improve test plan lol
Could someone create a tag for the 2024.35 release, please? https://we.phorge.it/source/arcanist/tags/master/ https://we.phorge.it/source/phorge/tags/master/
Phorge Horoscope:
Aries: Your bold energy is needed! Dive into D25363 and share your insights. Your Calendar experience will inspire others! lol
Taurus: Your practical nature to "seems good to me" will serve you well as you review the patch. Take your time, and carefully consider each line. The Test Plan will pay off in the long run D25823
re: T15956, there's also a secondary bug report I'd like to file since they're 2 different systems, but I'd like to ask before making them separate:
When attaching a file via the upload button or pasting when in a proper Conpherence room, if you reload the page, the metadata is lost & upon submission, files are not attached.