P.S. try applying D25809 to check if the red unit test becomes green

cc: @avivey

@avivey I added task T15928 and will get started with that.

Thanks again. Let's see if we receive some feedback from users in master branch

I had to rebase and rebuild resources/celerity/map.php to fix a merge conflict. I hope that worked.

Oh, I have to land it… Let's see if I still remember how.

Thanks. Premising that I also don't like projects with "automagic getters" so I agree with you; here how every getter works in Phabricator/Phorge:

Also related: T15025

Change offset to optional as requested by speck

As usual I'm confused about the PHP magic which does not require defining the method PhabricatorRepositoryCommit::getEpoch() in its class or parent classes, but I assume you tested locally that your patch works, plus PhabricatorRepositoryCommit does have some calls already to $this->getEpoch(), so I'll accept - worst case would be the very same behavior as now.

@valerio.bozzolan Thanks, this unblocks a few more things on my list. I admit that I have not looked into the unit test failure here and I assume you understand it and that it is fine to merge this patch. :)

FYI T15927: Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal

Width overflow fixed

Remove unecessary comment

I personally prefer option 1, so, removing the duplicate body. So there is more creative space to then add a more useful body in the future.

Indeed, we seem to prefer throwing exceptions after if (!($foo instanceof PhutilSortVector)), or use assert_instances_of() on an array, using gettype() and get_class().

This is becoming quite frustrating in my workplace in Torino. Let's start immersion mode.

Ironically, adding missing variable names to @param lines increases the amount of errors in PHPStan output: