Page MenuHomePhorge
Feed Advanced Search

May 5 2024

valerio.bozzolan added a comment to T15813: Being subscribed by others should generate a notification.

I can reproduce but the title is so generic that makes this not actionable.

May 5 2024, 01:13 · Bug Reports

May 4 2024

waldyrious created T15813: Being subscribed by others should generate a notification.
May 4 2024, 23:48 · Bug Reports
aklapper added a comment to T15372: "RuntimeException: Undefined array key" when pasting "a {{{a}}} a" comment (due to regex in PhutilRemarkupInterpreterBlockRule.php).

That's because we applied D25415

May 4 2024, 20:34 · Bug Reports
valerio.bozzolan closed T15372: "RuntimeException: Undefined array key" when pasting "a {{{a}}} a" comment (due to regex in PhutilRemarkupInterpreterBlockRule.php) as Resolved.

Cannot reproduce anymore / fixed?

May 4 2024, 19:51 · Bug Reports
mainframe98 created T15812: Double escaped text when adding an auth provider.
May 4 2024, 17:48 · Bug Reports

May 1 2024

aklapper removed a project from T15372: "RuntimeException: Undefined array key" when pasting "a {{{a}}} a" comment (due to regex in PhutilRemarkupInterpreterBlockRule.php): Affects-Wikimedia.
May 1 2024, 17:31 · Bug Reports

Apr 30 2024

aklapper added a revision to T15436: "TypeError: config.datasets is undefined" in Facts when logged out: D25608: Facts: Fix displaying charts for anonymous users.
Apr 30 2024, 16:02 · Bug Reports
valerio.bozzolan triaged T15805: Cannot patch a diff that edits files with non-ascii filenames as High priority.
Apr 30 2024, 13:09 · Arcanist, Bug Reports
kuba-orlik created T15805: Cannot patch a diff that edits files with non-ascii filenames.
Apr 30 2024, 12:56 · Arcanist, Bug Reports
valerio.bozzolan reassigned T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML. from valerio.bozzolan to avivey.

Thanks again :) Giving right credits

Apr 30 2024, 09:53 · Auth, Bug Reports

Apr 29 2024

valerio.bozzolan closed T15703: Workboard Cover Image: the cropped "Transform" is orphan as Resolved by committing rP3367fe0017b1: Drag & Drop Task Cover Image: also attach.
Apr 29 2024, 15:34 · Bug Reports, User-valerio.bozzolan, Cover Image
zhe closed Q134: [BUG] ManiphestDefaultPriorityEditCapability.php failed to load since b32b84b64515669d6f566d77673b78e08d2a0864 as resolved.
Apr 29 2024, 01:01 · Phorge, Bug Reports

Apr 28 2024

zhe updated Q134: [BUG] ManiphestDefaultPriorityEditCapability.php failed to load since b32b84b64515669d6f566d77673b78e08d2a0864 from [BUG] to [BUG] ManiphestDefaultPriorityEditCapability.php failed to load since b32b84b64515669d6f566d77673b78e08d2a0864.
Apr 28 2024, 15:22 · Phorge, Bug Reports
zhe asked Q134: [BUG] ManiphestDefaultPriorityEditCapability.php failed to load since b32b84b64515669d6f566d77673b78e08d2a0864.
Apr 28 2024, 15:21 · Phorge, Bug Reports

Apr 26 2024

avivey closed T15731: Editing Ponder Comments is broken as Resolved.

Can't reproduce either - 🤷🏻‍♂️

Apr 26 2024, 06:38 · Ponder, Bug Reports

Apr 25 2024

Iniquity added a comment to T15731: Editing Ponder Comments is broken.

@avivey hi!
I cant reproduce it. Is the problem still there?

Apr 25 2024, 20:16 · Ponder, Bug Reports
valerio.bozzolan attached a referenced file: F706889: image.png.
Apr 25 2024, 19:26 · Ponder, Bug Reports, UX
valerio.bozzolan attached a referenced file: F706886: image.png.
Apr 25 2024, 19:26 · Ponder, Bug Reports, UX
valerio.bozzolan attached a referenced file: F706925: image.png.
Apr 25 2024, 19:26 · Ponder, Bug Reports, UX
Jack_who_built_the_house updated the task description for T15797: Ponder: edits to answers are not reflected consistently in comments to it.
Apr 25 2024, 19:09 · Bug Reports, Ponder
Iniquity moved T15711: Ponder: "New Answer" input box should be hidden for those without permissions. from Backlog to Bug Reports on the Ponder board.
Apr 25 2024, 18:10 · Ponder, Bug Reports, UX
Iniquity moved T15731: Editing Ponder Comments is broken from Backlog to Bug Reports on the Ponder board.
Apr 25 2024, 18:10 · Ponder, Bug Reports
Iniquity moved T15797: Ponder: edits to answers are not reflected consistently in comments to it from Backlog to Bug Reports on the Ponder board.
Apr 25 2024, 18:10 · Bug Reports, Ponder
Iniquity added a project to T15731: Editing Ponder Comments is broken: Ponder.
Apr 25 2024, 18:07 · Ponder, Bug Reports
Iniquity added a project to T15711: Ponder: "New Answer" input box should be hidden for those without permissions.: Ponder.
Apr 25 2024, 18:05 · Ponder, Bug Reports, UX
Iniquity added a project to T15797: Ponder: edits to answers are not reflected consistently in comments to it: Bug Reports.
Apr 25 2024, 18:04 · Bug Reports, Ponder

Apr 18 2024

Mormegil added a comment to T15788: “Form data changed” confirmation is shown after even read-only keyboard interaction.

Yeah, that might help (like specifically in the case of the Clone dialog) even though it wouldn't help with dialogs containing writable inputs. (E.g. on the repository page, click Flag For Later instead and press Shift+Tab and Escape.) A better fix would lie at https://we.phorge.it/source/phorge/browse/master/webroot/rsrc/externals/javelin/lib/Workflow.js$413 where either the getSpecialKey would need improvement itself to return true for these non-modifying keys, or it would need to be amended with a custom check in that regard. However, I don't know where that function comes from.

Apr 18 2024, 15:40 · Bug Reports, Phorge
valerio.bozzolan added a comment to T15788: “Form data changed” confirmation is shown after even read-only keyboard interaction.

Probably something here should be expanded to check if the form contains at least a visible input without read-only

Apr 18 2024, 15:17 · Bug Reports, Phorge
Mormegil created T15788: “Form data changed” confirmation is shown after even read-only keyboard interaction.
Apr 18 2024, 15:11 · Bug Reports, Phorge

Apr 15 2024

avivey added a comment to T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..

done...

Apr 15 2024, 16:36 · Auth, Bug Reports
avivey added a comment to T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..

Yeah, probably. I'll try to do it tonight.

Apr 15 2024, 08:31 · Auth, Bug Reports

Apr 14 2024

revi added a comment to T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..

Can this (I mean rPb445e1d80df9 )be backported into stable?

Apr 14 2024, 12:24 · Auth, Bug Reports

Apr 2 2024

valerio.bozzolan triaged T15612: Missing "Authored on" commit date for Subversion commits as Normal priority.

I can reproduce this, on an hosted Subversion repository.

Apr 2 2024, 11:17 · User-valerio.bozzolan, Diffusion, Bug Reports

Mar 28 2024

aklapper placed T15650: AphrontDuplicateKeyQueryException dragging task from milestone column to main board column: Duplicate entry for key 'boardPHID' up for grabs.
Mar 28 2024, 19:54 · Affects-Wikimedia, Bug Reports
aklapper added a subtask for T15650: AphrontDuplicateKeyQueryException dragging task from milestone column to main board column: Duplicate entry for key 'boardPHID': T15764: Moving tasks on a workboard via the "Add Action" dropdown does not update column and column positions tables.
Mar 28 2024, 19:54 · Affects-Wikimedia, Bug Reports
aklapper added a parent task for T15764: Moving tasks on a workboard via the "Add Action" dropdown does not update column and column positions tables: T15650: AphrontDuplicateKeyQueryException dragging task from milestone column to main board column: Duplicate entry for key 'boardPHID'.
Mar 28 2024, 19:54 · Workboard, Bug Reports
aklapper created T15764: Moving tasks on a workboard via the "Add Action" dropdown does not update column and column positions tables.
Mar 28 2024, 19:50 · Workboard, Bug Reports

Mar 26 2024

avivey closed T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description as Resolved by committing rP216d308507ed: Fix Project Hovercard rendering @mention.
Mar 26 2024, 18:07 · Affects-Wikimedia, Bug Reports
avivey added a revision to T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description: D25562: Fix Project Hovercard rendering @mention.
Mar 26 2024, 15:40 · Affects-Wikimedia, Bug Reports
avivey added a comment to T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.

It might not happen on any other card, because we might not be rendering Remarkup on any other card. Interesting....

Mar 26 2024, 10:46 · Affects-Wikimedia, Bug Reports
avivey added a comment to T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.

So this is quite an edge-case:

  • PhabricatorMentionRemarkupRule wants to give the mention a different color, depending on if the user can view the "context object", in this case the Project.
  • There's an automatic rule, saying a member of a project can always view the project
  • When loading the project for the hovercard, we don't bother loading all the member list
  • When loading the user for the mention, we don't bother loading all its projects
  • so data is not available at the rendering point.
Mar 26 2024, 10:39 · Affects-Wikimedia, Bug Reports
avivey claimed T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.
Mar 26 2024, 10:23 · Affects-Wikimedia, Bug Reports
valerio.bozzolan closed T15763: [Search Bug] Refusing to redirect to local resource "foo". This URI is not formatted in a recognizable way. as Resolved by committing rP27f4b8321a5e: Fix important regression in search engine.
Mar 26 2024, 06:30 · Bug Reports

Mar 25 2024

valerio.bozzolan added a revision to T15763: [Search Bug] Refusing to redirect to local resource "foo". This URI is not formatted in a recognizable way.: D25561: Fix important regression in search engine.
Mar 25 2024, 12:50 · Bug Reports
valerio.bozzolan attached a referenced file: F2036615: image.png.
Mar 25 2024, 12:35 · Bug Reports
valerio.bozzolan attached a referenced file: F2036661: image.png.
Mar 25 2024, 12:35 · Bug Reports
zhe closed Q121: [Search Bug] Refusing to redirect to local resource "foo". This URI is not formatted in a recognizable way. as obsolete.
Mar 25 2024, 12:29 · Phorge, Bug Reports
zhe created T15763: [Search Bug] Refusing to redirect to local resource "foo". This URI is not formatted in a recognizable way..
Mar 25 2024, 12:29 · Bug Reports
zhe closed Q122: [Bug] Can't setup Admin account as resolved.
Mar 25 2024, 12:27 · Bug Reports
zhe added a comment to Q122: [Bug] Can't setup Admin account.

DisableUsernameEditEventListener.php is the root cause.

Mar 25 2024, 12:27 · Bug Reports
valerio.bozzolan added a comment to Q121: [Search Bug] Refusing to redirect to local resource "foo". This URI is not formatted in a recognizable way..

Premising that we may want to rollback 328aee033fbd, probably this line is broken:

Mar 25 2024, 08:59 · Phorge, Bug Reports
valerio.bozzolan added a comment to Q121: [Search Bug] Refusing to redirect to local resource "foo". This URI is not formatted in a recognizable way..

Ouch. Probably partially my fault. Feel free to escalate this as Task under Bug Reports - close this as obsolete then

Mar 25 2024, 08:53 · Phorge, Bug Reports
avivey added a comment to Q122: [Bug] Can't setup Admin account.

I can't immediately reproduce with that version either. I'll try again later.
In the meanwhile:

  • Try clearing your browser's cache
  • Try updating Phorge to the latest commit
  • Try disabling this extension: assets/DisableUsernameEditEventListener.php
Mar 25 2024, 08:41 · Bug Reports
avivey added a comment to Q121: [Search Bug] Refusing to redirect to local resource "foo". This URI is not formatted in a recognizable way..

I can reproduce this on master with basically any string search.

Mar 25 2024, 08:30 · Phorge, Bug Reports
zhe added a comment to Q121: [Search Bug] Refusing to redirect to local resource "foo". This URI is not formatted in a recognizable way..

https://we.phorge.it just works fine. :L

Mar 25 2024, 08:30 · Phorge, Bug Reports
zhe added a comment to Q122: [Bug] Can't setup Admin account.
  1. Phorge installation
Mar 25 2024, 08:26 · Bug Reports
avivey added a comment to Q122: [Bug] Can't setup Admin account.

I can't reproduce this.
Which version of phorge/arc do you have (git log -1)?
How did you install the new Instance?

Mar 25 2024, 07:44 · Bug Reports
valerio.bozzolan added a comment to Q121: [Search Bug] Refusing to redirect to local resource "foo". This URI is not formatted in a recognizable way..

Interesting. This cannot be reproduced here in this website https://we.phorge.it? isn't it? I think no

Mar 25 2024, 07:24 · Phorge, Bug Reports
zhe added a comment to Q121: [Search Bug] Refusing to redirect to local resource "foo". This URI is not formatted in a recognizable way..

:p

Mar 25 2024, 07:22 · Phorge, Bug Reports
valerio.bozzolan added a comment to Q121: [Search Bug] Refusing to redirect to local resource "foo". This URI is not formatted in a recognizable way..

(Please edit file Visibility to make them Public :D It's another bug ihih - thanks! <3)

Mar 25 2024, 07:21 · Phorge, Bug Reports
zhe added a comment to Q121: [Search Bug] Refusing to redirect to local resource "foo". This URI is not formatted in a recognizable way..

The exception throw out when I search text in search bar:

image.png (277×808 px, 26 KB)

Mar 25 2024, 07:20 · Phorge, Bug Reports
valerio.bozzolan added a revision to T15372: "RuntimeException: Undefined array key" when pasting "a {{{a}}} a" comment (due to regex in PhutilRemarkupInterpreterBlockRule.php): D25559: Update unit test of InterpreterBlockRule for "a {{{a}}}".
Mar 25 2024, 07:18 · Bug Reports
valerio.bozzolan added a revision to T15372: "RuntimeException: Undefined array key" when pasting "a {{{a}}} a" comment (due to regex in PhutilRemarkupInterpreterBlockRule.php): D25415: Make InterpreterBlockRule regex only match on valid interpreter names.
Mar 25 2024, 07:12 · Bug Reports
valerio.bozzolan added a comment to Q121: [Search Bug] Refusing to redirect to local resource "foo". This URI is not formatted in a recognizable way..

Please also include your exact search. I think you are searching by https://foo and that is unfortunately not possible without "doing this"

Mar 25 2024, 06:29 · Phorge, Bug Reports
zhe added projects to Q121: [Search Bug] Refusing to redirect to local resource "foo". This URI is not formatted in a recognizable way.: Bug Reports, Phorge.
Mar 25 2024, 04:50 · Phorge, Bug Reports
zhe asked Q122: [Bug] Can't setup Admin account.
Mar 25 2024, 04:49 · Bug Reports

Mar 24 2024

valerio.bozzolan triaged T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description as High priority.

Ouch

Mar 24 2024, 15:46 · Affects-Wikimedia, Bug Reports

Mar 21 2024

aklapper updated the task description for T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.
Mar 21 2024, 22:34 · Affects-Wikimedia, Bug Reports
aklapper added a comment to T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.

Also note that we have a similar PhabricatorDataNotAttachedException in PhabricatorRepositoryCommit (via getRepository()) in downstream https://phabricator.wikimedia.org/T360714. It's without reproduction steps but sounds a bit similar.

Mar 21 2024, 20:40 · Affects-Wikimedia, Bug Reports
aklapper updated the task description for T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.
Mar 21 2024, 20:21 · Affects-Wikimedia, Bug Reports
aklapper created T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.
Mar 21 2024, 20:19 · Affects-Wikimedia, Bug Reports
aklapper closed T15631: "Map returned omits required key" exception for second result page (cursor) for Maniphest search ordered by custom field as Resolved by committing rPd42b3eb0b17a: Fix "Map omits required key" exception by comparing result order against modern….
Mar 21 2024, 18:26 · Affects-Wikimedia, Bug Reports

Mar 15 2024

aklapper claimed T15650: AphrontDuplicateKeyQueryException dragging task from milestone column to main board column: Duplicate entry for key 'boardPHID'.
Mar 15 2024, 16:45 · Affects-Wikimedia, Bug Reports

Mar 12 2024

valerio.bozzolan added a comment to T15754: PHP creation of Tasks - problem with Title in feed.

Yeah sorry. That exception also occurred to me, before this change: https://we.phorge.it/transactions/detail/PHID-XACT-TASK-tuchgj42nb2ujtc/

Mar 12 2024, 13:46 · Maniphest, Bug Reports
aklapper added a comment to T15754: PHP creation of Tasks - problem with Title in feed.

I could not even reproduce but get an informative error instead:

Mar 12 2024, 13:39 · Maniphest, Bug Reports
valerio.bozzolan closed T15754: PHP creation of Tasks - problem with Title in feed as Invalid.

Thanks avivey. Added this:

Mar 12 2024, 07:12 · Maniphest, Bug Reports
avivey added a comment to T15754: PHP creation of Tasks - problem with Title in feed.

Look into the "is creation xaction" - we had a similar diff recently about creating Revision from raw diff that had a similar behavior.

Mar 12 2024, 06:49 · Maniphest, Bug Reports
valerio.bozzolan updated the task description for T15754: PHP creation of Tasks - problem with Title in feed.
Mar 12 2024, 06:47 · Maniphest, Bug Reports

Mar 11 2024

valerio.bozzolan changed the visibility for T15754: PHP creation of Tasks - problem with Title in feed.
Mar 11 2024, 18:27 · Maniphest, Bug Reports
valerio.bozzolan renamed T15754: PHP creation of Tasks - problem with Title in feed from ASD to PHP creation of Tasks - problem with Title in feed.
Mar 11 2024, 18:27 · Maniphest, Bug Reports

Mar 10 2024

valerio.bozzolan added a comment to T15631: "Map returned omits required key" exception for second result page (cursor) for Maniphest search ordered by custom field.

Maybe unrelated. But after we fix PhabricatorCursorPagedPolicyAwareQuery, maybe we will find a crash test also for the first two lines:

Mar 10 2024, 16:25 · Affects-Wikimedia, Bug Reports
valerio.bozzolan triaged T15631: "Map returned omits required key" exception for second result page (cursor) for Maniphest search ordered by custom field as Normal priority.

Interestingly I was able to reproduce, but only creating 101+ tasks manually and going to the next page. So after that ?after=100 is introduced.

Mar 10 2024, 12:05 · Affects-Wikimedia, Bug Reports

Feb 12 2024

valerio.bozzolan closed T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML. as Resolved by committing rPb445e1d80df9: Fix config transaction rendering error on auth page by allowing PhutilSafeHTML.
Feb 12 2024, 10:52 · Auth, Bug Reports
sirocyl added a comment to T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..

Heck yeah, changing phutil_nonempty_string() to phutil_nonempty_stringlike() there fixed the issue I had mentioned in a comment in T15737: Include information for installing required PHP version in Diviner docs.

Feb 12 2024, 10:50 · Auth, Bug Reports

Feb 7 2024

revi attached a referenced file: F1263882: image.png.
Feb 7 2024, 11:03 · Remarkup, Bug Reports
revi created T15733: IDN not in a punycode format is not recognized as a link.
Feb 7 2024, 11:03 · Remarkup, Bug Reports

Feb 3 2024

avivey created T15731: Editing Ponder Comments is broken.
Feb 3 2024, 12:01 · Ponder, Bug Reports
avivey triaged T15722: Phorge is inaccessible while waiting for approval after registration as Wishlist priority.

I'm triaging as "wishlist" for now, but realistically - I don't believe will ever reach a point where we'll try to fix this -- see https://secure.phabricator.com/T13154 for discussion.

Feb 3 2024, 10:39 · Bug Reports, UX

Feb 1 2024

20after4 added a comment to T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out.

can confirm, https://we.phorge.it/D25342?id=1111 does show an error for me in an incognito window.

Feb 1 2024, 15:52 · Bug Reports, Differential
valerio.bozzolan added a comment to T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out.

Probably, something should "Attach" these files by default to that Diff, during the upload phase.

Feb 1 2024, 12:09 · Bug Reports, Differential
valerio.bozzolan added a comment to T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out.

A workaround is to make all files as "Public". I fixed for example the diff D25079: Trigger: Add Sound "Coin" by setting the audio file F1271256 as public.

Feb 1 2024, 12:08 · Bug Reports, Differential
valerio.bozzolan raised the priority of T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out from Normal to High.
Feb 1 2024, 12:03 · Bug Reports, Differential

Jan 27 2024

pppery added a comment to T15722: Phorge is inaccessible while waiting for approval after registration.

Old upstream WONTFIXed this in https://secure.phabricator.com/T13154

Jan 27 2024, 22:20 · Bug Reports, UX

Jan 25 2024

Tgr created T15722: Phorge is inaccessible while waiting for approval after registration.
Jan 25 2024, 18:56 · Bug Reports, UX
CryingWolf created T15721: Commits in Phorge stuck on 'Still Importing'.
Jan 25 2024, 14:06

Jan 19 2024

aklapper added a comment to T15579: Legalpad and Phame: "Quote Comment" destination is a "not found" page.

Note that at least for Phame, http://phorge.localhost/J1 seems to always redirect to http://phorge.localhost/phame/post/view/1/blogpost/ instead of keeping the monogram in the URI.
So the baseURI is already wrong (not being http://phorge.localhost/ only) before concatenating the $ref (monogram and anchor).
As an ugly workardound, could probably make "Quote Comment" work by calling getObjectNamePrefix() in PhamePostRemarkupRule and LegalpadDocumentRemarkupRule and then use them in a preg_match to remove the monogram from the $ref but function is protected and... still ugly.

Jan 19 2024, 01:49 · Phame, Bug Reports, User-valerio.bozzolan

Jan 15 2024

sirocyl created T15711: Ponder: "New Answer" input box should be hidden for those without permissions..
Jan 15 2024, 05:41 · Ponder, Bug Reports, UX

Jan 12 2024

doommius added a revision to T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML.: D25512: Fix config transaction rendering error on auth page by allowing PhutilSafeHTML.
Jan 12 2024, 11:35 · Auth, Bug Reports
valerio.bozzolan added a comment to T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..

Can you try changing this line in your local install?

Jan 12 2024, 08:58 · Auth, Bug Reports

Jan 11 2024

doommius updated the task description for T15706: Phorge/auth/config/view/3/ Call to phutil_nonempty_string() expected null or a string, got: PhutilSafeHTML..
Jan 11 2024, 17:23 · Auth, Bug Reports