Page MenuHomePhorge
Feed Advanced Search

Mon, Sep 9

valerio.bozzolan added a parent task for T15872: Understand how to defuse localization in GNU Gettext: T15927: Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal.
Mon, Sep 9, 13:52 · Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan added a subtask for T15927: Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal: T15872: Understand how to defuse localization in GNU Gettext.
Mon, Sep 9, 13:52 · User-valerio.bozzolan

Thu, Sep 5

tiantiandas asked Q149: [BUG] Conduit API call error: Call to phutil_nonempty_string() expected null or a string, got: float..
Thu, Sep 5, 06:29 · Bug Reports, Phorge

Wed, Sep 4

aklapper merged T15937: Exception when viewing diff while not logged in into T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out.
Wed, Sep 4, 07:51 · Bug Reports, Differential

Wed, Aug 28

valerio.bozzolan closed T15905: Linter: do not break "ics" files as Resolved by committing rP3e5315181555: Calendar Import: add unit tests to cover participants.
Wed, Aug 28, 07:31 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist

Mon, Aug 26

valerio.bozzolan added a revision to T15927: Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal: D25809: ArcanistBundleTestCase: fix support of non-English environments.
Mon, Aug 26, 14:23 · User-valerio.bozzolan

Sat, Aug 24

valerio.bozzolan closed T15612: Missing "Authored on" commit date for Subversion commits as Resolved by committing rPb02615bd5027: Subversion: fix empty "Authored on" date on commit pages.
Sat, Aug 24, 13:34 · User-valerio.bozzolan, Diffusion, Bug Reports

Fri, Aug 23

aklapper renamed T15612: Missing "Authored on" commit date for Subversion commits from Missing subversion commit information to Missing "Authored on" commit date for Subversion commits.
Fri, Aug 23, 18:30 · User-valerio.bozzolan, Diffusion, Bug Reports
valerio.bozzolan renamed T15927: Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal from Fix Arcanist unit test - Diff Parse Exception: Expected '\ No newline at end of file' to Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal.
Fri, Aug 23, 13:40 · User-valerio.bozzolan
valerio.bozzolan created T15927: Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal.
Fri, Aug 23, 13:38 · User-valerio.bozzolan

Wed, Aug 21

valerio.bozzolan moved T15612: Missing "Authored on" commit date for Subversion commits from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Wed, Aug 21, 13:33 · User-valerio.bozzolan, Diffusion, Bug Reports
valerio.bozzolan claimed T15612: Missing "Authored on" commit date for Subversion commits.
Wed, Aug 21, 13:33 · User-valerio.bozzolan, Diffusion, Bug Reports
valerio.bozzolan added a revision to T15612: Missing "Authored on" commit date for Subversion commits: D25796: Subversion: fix empty "Authored on" date on commit pages.
Wed, Aug 21, 13:33 · User-valerio.bozzolan, Diffusion, Bug Reports
valerio.bozzolan edited projects for T15612: Missing "Authored on" commit date for Subversion commits, added: Diffusion; removed Phorge.

This is becoming quite frustrating in my workplace in Torino. Let's start immersion mode.

Wed, Aug 21, 13:29 · User-valerio.bozzolan, Diffusion, Bug Reports

Sat, Aug 17

valerio.bozzolan added a project to T15918: When destroying a Project, all Sub-Projects are "You Shall Not Pass: Restricted Project": User-valerio.bozzolan.

The solution was to take direct children project and call $child->setParentProjectPHID($my_parent_phid).

Sat, Aug 17, 13:49 · User-valerio.bozzolan, Bug Reports, Projects
valerio.bozzolan added a project to T15913: When deleting a Project, its direct Milestones remain orphan (should instead be dropped): User-valerio.bozzolan.

Finally in my Phorge I can kill these milestones \o/

Sat, Aug 17, 13:45 · User-valerio.bozzolan, Bug Reports, Projects
valerio.bozzolan added a revision to T15918: When destroying a Project, all Sub-Projects are "You Shall Not Pass: Restricted Project": D25772: Projects: improve quality of destroy workflow.
Sat, Aug 17, 13:29 · User-valerio.bozzolan, Bug Reports, Projects

Fri, Aug 16

valerio.bozzolan created T15918: When destroying a Project, all Sub-Projects are "You Shall Not Pass: Restricted Project".
Fri, Aug 16, 13:24 · User-valerio.bozzolan, Bug Reports, Projects

Aug 12 2024

valerio.bozzolan added a revision to T15913: When deleting a Project, its direct Milestones remain orphan (should instead be dropped): D25772: Projects: improve quality of destroy workflow.
Aug 12 2024, 21:21 · User-valerio.bozzolan, Bug Reports, Projects
valerio.bozzolan created T15913: When deleting a Project, its direct Milestones remain orphan (should instead be dropped).
Aug 12 2024, 20:54 · User-valerio.bozzolan, Bug Reports, Projects

Aug 11 2024

valerio.bozzolan added a revision to T15905: Linter: do not break "ics" files: D25767: Calendar Import: add unit tests to cover participants.
Aug 11 2024, 14:59 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist

Aug 10 2024

valerio.bozzolan closed T15110: File reference not removed when file is deleted as Resolved by committing rP2b7c0ec92f6c: Destroy file attachments when file is deleted, or object is deleted.
Aug 10 2024, 20:17 · Files, Bug Reports
valerio.bozzolan closed T15896: Explore How-To Permanently Destroy Things in Phorge, a subtask of T15110: File reference not removed when file is deleted, as Resolved.
Aug 10 2024, 20:14 · Files, Bug Reports

Aug 9 2024

valerio.bozzolan added a project to T15905: Linter: do not break "ics" files: User-valerio.bozzolan.
Aug 9 2024, 20:50 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist

Aug 7 2024

valerio.bozzolan added a revision to T15905: Linter: do not break "ics" files: D25766: Arcanist Text Linter: do not break the "ics" special format.
Aug 7 2024, 10:08 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist
valerio.bozzolan triaged T15905: Linter: do not break "ics" files as Normal priority.
Aug 7 2024, 09:58 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist

Aug 5 2024

aklapper added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing.

This is an issue in https://we.phorge.it/source/phorge/browse/master/src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php . In getObjectEmbedPattern(), preg_quote($prefix) returns \# and the method finally returns (\B{\#([^.\s?!,:;{}#\(\)"'\*/~]+(?:[^\s?!,:;{}#\(\)"'\*/~]*[^.\s?!,:;{}#\(\)"'\*/~]+)*)([,\s](?:[^}\\]|\\.)*)?}\B)u.
Within apply($text), $text becomes null after that first preg_replace_callback, so the second call barks.

Aug 5 2024, 12:44 · Bug Reports, Remarkup, Affects-Wikimedia

Aug 2 2024

valerio.bozzolan added a comment to T15110: File reference not removed when file is deleted.

Yep. In all cases it's at least a full-table-scan on file_attachment. Probably a bit more RAM-efficient with the NOT EXISTS thing since it does not need to have all file PHIDs in memory.

Aug 2 2024, 09:59 · Files, Bug Reports

Jul 30 2024

aklapper closed T15378: PhabricatorApplicationTransactionStructureException trying to mute File notifications: "Attempting to apply a transaction which has not been constructed correctly" as Resolved by committing rPe2919211f3c2: Avoid PhabricatorApplicationTransactionStructureException on editors not….
Jul 30 2024, 08:52 · Bug Reports
aklapper closed T15827: Possible to award a badge without selecting a recipient as Resolved by committing rP8793bdbaa87c: Disallow awarding a badge without selecting recipient.
Jul 30 2024, 08:50 · Bug Reports

Jul 24 2024

valerio.bozzolan created T15892: Post-Commit Audit review: authors cannot "Raise Concern".
Jul 24 2024, 09:27 · Discussion Needed, Bug Reports, Diffusion

Jul 23 2024

aklapper added a comment to T15378: PhabricatorApplicationTransactionStructureException trying to mute File notifications: "Attempting to apply a transaction which has not been constructed correctly".

My userbase is stellar in relentlessly clicking every button you provide them :P

Jul 23 2024, 09:34 · Bug Reports
valerio.bozzolan triaged T15378: PhabricatorApplicationTransactionStructureException trying to mute File notifications: "Attempting to apply a transaction which has not been constructed correctly" as Normal priority.

(Wow. I've never clicked on that button in my life, also when working)

Jul 23 2024, 08:27 · Bug Reports
valerio.bozzolan triaged T15827: Possible to award a badge without selecting a recipient as Normal priority.

Thanks :) Interesting weird transaction.

Jul 23 2024, 07:36 · Bug Reports

Jul 19 2024

aklapper added a comment to T15110: File reference not removed when file is deleted.

I'd be worried about DB performance running such a query as our DB has dozens of millions of files... (This is basically SELECT COUNT(*) FROM file_attachment fa WHERE fa.filePHID NOT IN (SELECT f.phid FROM file); in my understanding?)

Jul 19 2024, 15:30 · Files, Bug Reports
valerio.bozzolan added a comment to T15110: File reference not removed when file is deleted.

Unrelated but @aklapper I'm curious about the situation in WMF. If you can maybe report something like this:

Jul 19 2024, 13:18 · Files, Bug Reports

Jul 8 2024

valerio.bozzolan closed T15855: Fix "arc diff" in Subversion for non-English languages as Resolved by committing rARC72e59da8047c: Fix arc diff in Subversion for non-English languages.
Jul 8 2024, 08:06 · Bug Reports, User-valerio.bozzolan, Arcanist

Jul 3 2024

BlankEclair added a comment to T15875: Maniphest: Tasks can be closed as duplicate onto another task multiple times.

I haven't looked at Phorge's internals much yet, but perhaps the user could unmark a task as duplicate, or have the "Close As Duplicate" box be prefilled with the task that closed it and let the user deselect that and choose another one?

Jul 3 2024, 08:33 · Maniphest, Bug Reports
avivey added a comment to T15875: Maniphest: Tasks can be closed as duplicate onto another task multiple times.

Once we remove this, we'll need to handle this edge-case:

  • I've closed a ticket as "duplicate of T1", but I was wrong and want to mark it as "duplicate of T2" instead (and say it's not a dup of T1).
Jul 3 2024, 07:54 · Maniphest, Bug Reports
BlankEclair created T15875: Maniphest: Tasks can be closed as duplicate onto another task multiple times.
Jul 3 2024, 06:56 · Maniphest, Bug Reports

Jul 1 2024

valerio.bozzolan added a project to T15575: Moving a Phriction page does not move its Tags: Phriction.

Partially related to T15822: When a phriction page is moved, history should follow the page move

Jul 1 2024, 16:55 · Phriction, User-valerio.bozzolan, Bug Reports
valerio.bozzolan updated the task description for T15855: Fix "arc diff" in Subversion for non-English languages.
Jul 1 2024, 13:15 · Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan closed T15872: Understand how to defuse localization in GNU Gettext, a subtask of T15855: Fix "arc diff" in Subversion for non-English languages, as Resolved.
Jul 1 2024, 13:09 · Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan closed T15872: Understand how to defuse localization in GNU Gettext as Resolved.

OK. Well, thaanks \o/

Jul 1 2024, 13:09 · Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan updated the task description for T15872: Understand how to defuse localization in GNU Gettext.
Jul 1 2024, 12:56 · Bug Reports, User-valerio.bozzolan, Arcanist
l2dy added a comment to T15872: Understand how to defuse localization in GNU Gettext.

About this:

unset LC_ALL + LC_MESSAGES=C

I think it's not safe since other LC_STUFF can still be read 🤔

Jul 1 2024, 12:54 · Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan added a comment to T15872: Understand how to defuse localization in GNU Gettext.

About this:

Jul 1 2024, 12:52 · Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan updated the task description for T15872: Understand how to defuse localization in GNU Gettext.
Jul 1 2024, 12:49 · Bug Reports, User-valerio.bozzolan, Arcanist
l2dy added a comment to T15872: Understand how to defuse localization in GNU Gettext.

This [LANG=C] is supposed to be the default for missing LC_stuff

Jul 1 2024, 12:46 · Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan added a comment to T15872: Understand how to defuse localization in GNU Gettext.

OK thanks! you persuaded me

Jul 1 2024, 12:41 · Bug Reports, User-valerio.bozzolan, Arcanist
l2dy updated the task description for T15872: Understand how to defuse localization in GNU Gettext.
Jul 1 2024, 12:39 · Bug Reports, User-valerio.bozzolan, Arcanist
l2dy updated the task description for T15872: Understand how to defuse localization in GNU Gettext.
Jul 1 2024, 12:34 · Bug Reports, User-valerio.bozzolan, Arcanist
l2dy added a comment to T15872: Understand how to defuse localization in GNU Gettext.

LC_ALL=C is not risky on GNU systems.

Jul 1 2024, 12:22 · Bug Reports, User-valerio.bozzolan, Arcanist

Jun 30 2024

valerio.bozzolan updated the task description for T15872: Understand how to defuse localization in GNU Gettext.
Jun 30 2024, 19:27 · Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan created T15872: Understand how to defuse localization in GNU Gettext.
Jun 30 2024, 19:21 · Bug Reports, User-valerio.bozzolan, Arcanist

Jun 26 2024

valerio.bozzolan closed T15867: Fix legacy crash on Motivator backend from anonymous as Resolved by committing rP8825a09f676a: Fix legacy crash when visiting Motivator backend as anon.
Jun 26 2024, 21:26 · Bug Reports
valerio.bozzolan added a revision to T15867: Fix legacy crash on Motivator backend from anonymous: D25700: Fix legacy crash when visiting Motivator backend as anon.
Jun 26 2024, 21:10 · Bug Reports
valerio.bozzolan claimed T15867: Fix legacy crash on Motivator backend from anonymous.
Jun 26 2024, 21:08 · Bug Reports
valerio.bozzolan created T15867: Fix legacy crash on Motivator backend from anonymous.
Jun 26 2024, 21:08 · Bug Reports

Jun 21 2024

valerio.bozzolan updated the task description for T15855: Fix "arc diff" in Subversion for non-English languages.
Jun 21 2024, 14:46 · Bug Reports, User-valerio.bozzolan, Arcanist

Jun 20 2024

valerio.bozzolan assigned T15110: File reference not removed when file is deleted to Dylsss.
Jun 20 2024, 20:36 · Files, Bug Reports

Jun 11 2024

valerio.bozzolan added a revision to T15855: Fix "arc diff" in Subversion for non-English languages: D25691: Fix arc diff in Subversion for non-English languages.
Jun 11 2024, 16:09 · Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan triaged T15855: Fix "arc diff" in Subversion for non-English languages as Normal priority.
Jun 11 2024, 16:06 · Bug Reports, User-valerio.bozzolan, Arcanist

Jun 6 2024

pppery added a project to T15851: Support proper pluralization in mock task activity: Bug Reports.
Jun 6 2024, 05:39 · Bug Reports

Jun 5 2024

valerio.bozzolan triaged T15110: File reference not removed when file is deleted as High priority.

A bit more than Normal, since it reflects on a database with orphan elements that creates "ghosts in the UI".

Jun 5 2024, 07:59 · Files, Bug Reports

Jun 4 2024

valerio.bozzolan closed T15704: Cryptic exception when listing tasks "Closed By: Current Viewer" while logged out as Resolved by committing rP5a40739451c1: Show login page if a search token requires a valid viewer.
Jun 4 2024, 14:10 · Bug Reports, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15704: Cryptic exception when listing tasks "Closed By: Current Viewer" while logged out.
Jun 4 2024, 14:09 · Bug Reports, User-valerio.bozzolan
valerio.bozzolan added a project to T15704: Cryptic exception when listing tasks "Closed By: Current Viewer" while logged out: Bug Reports.
Jun 4 2024, 14:07 · Bug Reports, User-valerio.bozzolan

Jun 3 2024

valerio.bozzolan closed T15844: Dashboard Panel list: missing welcome page as Resolved by committing rP89dcbe125c6c: Panels list: fix missing welcome page.
Jun 3 2024, 23:45 · Dashboards, Bug Reports

May 31 2024

valerio.bozzolan added a revision to T15844: Dashboard Panel list: missing welcome page: D25674: Panels list: fix missing welcome page.
May 31 2024, 12:24 · Dashboards, Bug Reports
valerio.bozzolan added a project to T15844: Dashboard Panel list: missing welcome page: Dashboards.
May 31 2024, 09:13 · Dashboards, Bug Reports
valerio.bozzolan added a revision to T15844: Dashboard Panel list: missing welcome page: D25649: Fix call to non-existing getApplication() in PhabricatorDashboardPanelListController.
May 31 2024, 08:49 · Dashboards, Bug Reports
valerio.bozzolan created T15844: Dashboard Panel list: missing welcome page.
May 31 2024, 08:48 · Dashboards, Bug Reports

May 18 2024

valerio.bozzolan closed T15816: The feed "created this task" should be the first one as Resolved.

Probably OK now

May 18 2024, 08:10 · Bug Reports, User-valerio.bozzolan

May 15 2024

valerio.bozzolan added a comment to T15110: File reference not removed when file is deleted.

Relevant old upstream comment (from an unrelated task) that describes this problem as "ghosts in the UI":

May 15 2024, 00:21 · Files, Bug Reports

May 14 2024

revi attached a referenced file: F2191753: image.png.
May 14 2024, 22:01 · Arcanist, Bug Reports
revi added a comment to T15805: Cannot patch a diff that edits files with non-ascii filenames.

git config --global core.quotepath false

May 14 2024, 21:54 · Arcanist, Bug Reports
revi created T15830: files upload page cannot handle chunked upload.
May 14 2024, 18:00 · Files, Bug Reports
revi added a comment to T15805: Cannot patch a diff that edits files with non-ascii filenames.

Posted question at git@vger.kernel.org.

May 14 2024, 15:35 · Arcanist, Bug Reports

May 11 2024

revi added a comment to T15805: Cannot patch a diff that edits files with non-ascii filenames.

I also faced this, tested @ D25623, and found out git format-patch was emitting that result which causes git apply to fail. See this git format-patch example.

May 11 2024, 09:56 · Arcanist, Bug Reports

May 10 2024

valerio.bozzolan added projects to T15575: Moving a Phriction page does not move its Tags: Bug Reports, User-valerio.bozzolan.
May 10 2024, 05:39 · Phriction, User-valerio.bozzolan, Bug Reports
valerio.bozzolan added projects to T15453: Diffusion: Create Identity form is incomplete: Diffusion, Bug Reports.
May 10 2024, 05:38 · Bug Reports, Diffusion

May 9 2024

valerio.bozzolan moved T15816: The feed "created this task" should be the first one from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
May 9 2024, 19:51 · Bug Reports, User-valerio.bozzolan
valerio.bozzolan closed T15626: [Web] Persistent chat settings should not be clickable or visible when the chat is minimized as Resolved by committing rP5b90567f6453: Persistent Chat: fix de-minimize misclick.
May 9 2024, 11:56 · Bug Reports
valerio.bozzolan claimed T15626: [Web] Persistent chat settings should not be clickable or visible when the chat is minimized.
May 9 2024, 10:25 · Bug Reports
valerio.bozzolan added a revision to T15626: [Web] Persistent chat settings should not be clickable or visible when the chat is minimized: D25628: Persistent Chat: fix de-minimize misclick.
May 9 2024, 10:19 · Bug Reports

May 8 2024

valerio.bozzolan added a revision to T15816: The feed "created this task" should be the first one: D25626: The feed "created this task" should be the first one.
May 8 2024, 10:08 · Bug Reports, User-valerio.bozzolan
valerio.bozzolan removed a revision from T15816: The feed "created this task" should be the first one: D25625: Dashboard Text Panel: improve feed when changing Description.
May 8 2024, 09:52 · Bug Reports, User-valerio.bozzolan
valerio.bozzolan added a revision to T15816: The feed "created this task" should be the first one: D25625: Dashboard Text Panel: improve feed when changing Description.
May 8 2024, 09:46 · Bug Reports, User-valerio.bozzolan
valerio.bozzolan renamed T15816: The feed "created this task" should be the first one from The feed "created this task" should be the first one, not the last one to The feed "created this task" should be the first one.
May 8 2024, 09:22 · Bug Reports, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15816: The feed "created this task" should be the first one.
May 8 2024, 09:05 · Bug Reports, User-valerio.bozzolan
valerio.bozzolan reopened T15816: The feed "created this task" should be the first one as "Open".
May 8 2024, 08:31 · Bug Reports, User-valerio.bozzolan
valerio.bozzolan added a project to T15816: The feed "created this task" should be the first one: Bug Reports.
May 8 2024, 08:30 · Bug Reports, User-valerio.bozzolan

May 6 2024

valerio.bozzolan closed Q136: [BUG] Arcanist exception during the initialization on PHP 8.1 as resolved.
May 6 2024, 12:34 · Arcanist, Bug Reports
valerio.bozzolan added a comment to Q136: [BUG] Arcanist exception during the initialization on PHP 8.1.
May 6 2024, 12:33 · Arcanist, Bug Reports
valerio.bozzolan added a comment to Q136: [BUG] Arcanist exception during the initialization on PHP 8.1.
May 6 2024, 12:33 · Arcanist, Bug Reports
zhe asked Q136: [BUG] Arcanist exception during the initialization on PHP 8.1.
May 6 2024, 09:54 · Arcanist, Bug Reports

May 5 2024

aklapper closed T15436: "TypeError: config.datasets is undefined" in Facts when logged out as Resolved by committing rP960a1ab1ecd6: Facts: Fix displaying charts for anonymous users.
May 5 2024, 15:35 · Bug Reports
valerio.bozzolan triaged T15813: Being subscribed by others should generate a notification as Normal priority.
May 5 2024, 01:15 · Bug Reports
valerio.bozzolan renamed T15813: Being subscribed by others should generate a notification from Any action involving a given user should generate a notification for that user to Being subscribed by others should generate a notification.
May 5 2024, 01:15 · Bug Reports