We end up in the depths of ArcanistBundle::newBase85Data() here.
Which tries to copy behavior of https://github.com/git/git/blob/master/diff.c#L3325-L3395 which may have changed over time (or not).
I'm still wondering if this is a change in git (the software) creating a binary diff which Phorge then compares to https://we.phorge.it/source/arcanist/browse/master/src/parser/__tests__/patches//5dec8bf28557f078d1987c4e8cfb53d08310f522.gitpatch.

@valerio.bozzolan See last code block in the task description

Questions about the steps:

@A_smart_kitten you are super-super-welcome if you create another parent task like this https://web.archive.org/web/20250218071010/https://secure.phabricator.com/T12486 so " Search exclude-by-tag doesn't work consistently with subprojects" - since I completely agree on your point but I'm unsure how to manage it, so here T15828 we become just one of your sub-tasks.

• 🔶 this task (T15828) is not reporting a real-world thing about this use with sub-projects

FWIW, my use case from today in terms of sub-projects was attempting to search tasks on Wikimedia Phabricator that were tagged with either #MediaWiki-Recent-changes or #Edit-Review-Improvements (or a subproject thereof).

Triaging a bit more than "Wishlist" and a bit less than "Normal" since a prototype is actionable but we still lived years without this... so, "Low".

OK hackers, thanks for stimulating a follow-up. I've studied this a bit and I have a more clear opinion. Let's write some notes down.

Gonna boldly call it a bug, given that I was about to file an upstream bug report for https://phabricator.wikimedia.org/T386830 before I came across this task :)

In T15957#22436, @keithzg wrote:

Testing this a bit myself again, I discovered that actually this problem affects both Git and SVN

Testing this a bit myself again, I discovered that actually this problem affects both Git and SVN, it just wasn't being noticed in my SVN testing because it doesn't go wrong if run from any subfolder. So for example in a checkout of rARC, running arc browse . in the root directory will pop one into the bogus path of, say, https://we.phorge.it/source/arcanist/browse/master/home/keithzg/Code/git/arcanist, but if I'm in my local ~/Code/git/arcanist/src/ then arc browse . pops open https://we.phorge.it/source/arcanist/browse/master/src as intended.

Thanks, @valerio.bozzolan! :D

Thanks @Chlod for this bug report and please also enjoy T16057 and the new documentation table (D25988) that is provided to you for free :3

Thanks. I pinpoint also here your super-relevant extra details: https://we.phorge.it/D25887#26924

Covered, thanks for review :3

Thaanks. Can reproduce in latest master. Premising that uhmmmm probably it seems we are not using the API correctly as the correct usage seems with objectType=TASK. Example to get my transactions:

This project is now abandonware without you. 😆

Gents, you’re both nothing short of geniuses

Gents, you’re both nothing short of geniuses—fixed before I’d even blinked! Thanks. Will look at fixing it permanently in T15513.

Fix was reverted for now as it had bad side effects.

I can reproduce, looks like the change in src/applications/conpherence/controller/ConpherenceViewController.php is the culprit.
No clue what's a correct fix, thus proposing to revert the entire commit.

Eventually please try reverting this change in your local copy:

Tip: activate DarkConsole and check requests there 👍

From checking the network requests when I load an unrelated page and the dialog appears, I can see a POST request to /conpherence/edit/1/ which returns the dialog. I've attached both the request and the response, with light redactions, to P48 and P49.

Can confirm that this appears on all commands rather than just unit, so have renamed the task accordingly.

That's true of all projects - Remarkup here for instance.

In T16028#21601, @pppery wrote:

{#js-draw-lib} does work.

{#js-draw-lib} does work.

@pppery I don't know if you wanna step in, since the change was introduced by you.

I'm still a bit shocked by how PHP is so weird. So:

Wow. 10 years of PHP, first time that I notice this

https://www.php.net/manual/en/language.types.array.php#language.types.array.syntax :

Strings containing valid decimal ints, unless the number is preceded by a + sign, will be cast to the int type.

The culprit is $map[$branch] = $branch_head; in https://we.phorge.it/source/phorge/browse/master/src/applications/diffusion/data/DiffusionGitBranch.php$105.
Before $branch was a string, afterwards it is an integer.

Looks like a Good Starter Task.

@valerio.bozzolan could you please add to either H28 or H29 Affected files contains none of map.php?