I'm stupid and should have really checked the commit history first. Sorry!

Uh thanks, I had no idea where the upstream is, good to know because there are a few more issues. :)

shot at line 1162

Thanks :3 Hoping to be useful I will amend with a minimal sed -i 's/QRbitrtream/QRbitstream/' externals/phpqrcode/phpqrcode.php

I tested this with the following snippet:

Thanks :3 It makes sense, and I've also tested that snippet in PHP 5.5 and PHP 8.1 obtaining same results (premising that each() is not available anymore in PHP 8 as already clarified)

It was probably confused with the internal API executeRemovePath

Uh? It seems in use to me, in legacy lines 142, 145, 154, 155, etc.

Uh! I like this.

Probably OK now

Hmm, I also found this mentioned in https://secure.phabricator.com/T12404#256288 proposing a slightly different approach.

Indentation is awesome

Improvicate some things that valerio mentioned. (I prefer "Average" to "Normal" though; I consider "normal" a problematic term in this context.)

It's line 1162. Sorry for the line-ending collision noise, ./bin/arc diff did not want to accept my --ignore-cr-at-eol.

I felt it's not necessarily needed but it cannot hurt either. :)

Interesting triage. In legacy upstream this was a "feature request 🌈" - https://secure.phabricator.com/T12438

@valerio.bozzolan thanks for copy-pasting my comment, I didn't see a task was already created because I only checked the Bug Reports workboard. Should the Bug Reports tag be added to this task?

Super-useful comment:

I also ran into this issue, as reported in https://secure.phabricator.com/T12438 it also affects the "In Any" (or any()) searches, and makes it impossible to search for tasks that are in projectA or projectB, which seems quite a common use case:

I don't know if the file is really related, but PhabricatorDocumentRenderingEngine can be seen in scene while surfing a Diffusion repository and playing with View Options.