Page MenuHomePhorge

PHP 8.1 "strlen(null)" exception in PhabricatorAuthStartController.php
Closed, ResolvedPublic

Description

  1. PHP 8.3.7; Phorge at 8a3b70aa7d4c3376dabf5dfd5d3a0df68998711c with the branch rmBuildStandardPage from D25634 checked out on top.
  2. Run arc unit.
[acko@fedora phorge (rmBuildStandardPage $|u+1)]$ ../arcanist/bin/arc unit
[2024-05-15 12:18:04] ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/controller/PhabricatorAuthStartController.php:34]
arcanist(head=master, ref.master=7f28d7266f81), phorge(head=rmBuildStandardPage, ref.master=8a3b70aa7d4c, ref.rmBuildStandardPage=5231a873d7b2), translations(head=wmf/stable, ref.master=09fe573a932a, ref.wmf/stable=e45c643766c8)
  #0 PhabricatorAuthStartController::handleRequest(AphrontRequest) called at [<phorge>/src/aphront/AphrontController.php:71]
  #1 AphrontController::delegateToController(PhabricatorAuthStartController) called at [<phorge>/src/applications/base/controller/PhabricatorController.php:197]
  #2 PhabricatorController::willBeginExecution() called at [<phorge>/src/applications/base/controller/__tests__/PhabricatorAccessControlTestCase.php:269]
  #3 PhabricatorAccessControlTestCase::checkAccess(string, PhabricatorTestController, AphrontRequest, array, array) called at [<phorge>/src/applications/base/controller/__tests__/PhabricatorAccessControlTestCase.php:211]
  #4 PhabricatorAccessControlTestCase::testControllerAccessControls() called at [<arcanist>/src/unit/engine/phutil/PhutilTestCase.php:634]
  #5 PhutilTestCase::run() called at [<arcanist>/src/unit/engine/PhutilUnitTestEngine.php:69]
  #6 PhutilUnitTestEngine::run() called at [<arcanist>/src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php:148]
  #7 ArcanistConfigurationDrivenUnitTestEngine::run() called at [<arcanist>/src/workflow/ArcanistUnitWorkflow.php:170]
  #8 ArcanistUnitWorkflow::run() called at [<arcanist>/scripts/arcanist.php:427]
   PASS  259ms   PhabricatorAccessControlTestCase::testControllerAccessControls
   PASS   <1ms★  PhabricatorApplicationTestCase::testGetAllApplications
Done.                                                                         
   PASS   1.7s   PhabricatorLibraryTestCase::testLibraryMap                   
   PASS   2.1s   PhabricatorLibraryTestCase::testMethodVisibility
   PASS    6ms★  PhabricatorLibraryTestCase::testEverythingImplemented
   PASS  230ms   PhabricatorCelerityTestCase::testCelerityMaps
   PASS   14ms★  PhabricatorConduitTestCase::testConduitMethods
   PASS   <1ms★  PhabricatorInfrastructureTestCase::testApplicationsInstalled
   PASS   <1ms★  PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.