Page MenuHomePhorge

Correct PHPDoc or add default return for numerous methods
ClosedPublic

Authored by aklapper on May 16 2024, 14:42.
Tags
None
Referenced Files
F2985700: D25650.1740082607.diff
Wed, Feb 19, 20:16
F2978977: D25650.1739738297.diff
Sat, Feb 15, 20:38
F2964586: D25650.1739374847.diff
Tue, Feb 11, 15:40
F2963625: D25650.1739215814.diff
Sun, Feb 9, 19:30
F2946720: D25650.1738411878.diff
Fri, Jan 31, 12:11
F2945775: D25650.1738361359.diff
Thu, Jan 30, 22:09
F2944001: D25650.1738235840.diff
Wed, Jan 29, 11:17
F2942997: D25650.1738154118.diff
Tue, Jan 28, 12:35

Details

Summary

Correct PHPDoc when none of the method calls try to handle a return value.
Add missing fallback return statements (which may never be reached if previous condition checks were always true).

This reduces the amount of errors reported by static code analysis tools.

Test Plan

Carefully read the code and check all places in which a function gets called whether a return value is expected.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable