I created this Task as "Resolved" and it will be probably created with the following feed, in this order:
- valerio.bozzolan closed this task as Resolved.Wed, May 8, 10:13 AM
- valerio.bozzolan triaged this task as High priority.
- valerio.bozzolan created this task.
Here, reproduced:
Instead, this is the expected feed order:
- valerio.bozzolan created this task.
- valerio.bozzolan closed this task as Resolved.Wed, May 8, 10:13 AM
- valerio.bozzolan triaged this task as High priority.
Troubleshooting
It seems the "created this task" phrase comes from the ManiphestTransactionEditor method getCreateObjectTitle():
That seems in use by PhabricatorCoreCreateTransaction method getTitle():
Note that the above class inherits this default getActionStrength() returning null:
Also some probably relevant code:
- ManiphestTaskTitleTransaction (that seems not in use here for this specific bug report):
- ManiphestTaskStatusTransaction
- ManiphestTaskStatusTransaction
Proposal n. 1
So, probably, PhabricatorCoreCreateTransaction should have a getActionStrength() of 140.
Just like ManiphestTaskTitleTransaction or similar ones.
Example:
diff --git a/src/applications/transactions/xaction/PhabricatorCoreCreateTransaction.php b/src/applications/transactions/xaction/PhabricatorCoreCreateTransaction.php index 0c8c337193..03255afbc6 100644 --- a/src/applications/transactions/xaction/PhabricatorCoreCreateTransaction.php +++ b/src/applications/transactions/xaction/PhabricatorCoreCreateTransaction.php @@ -27,4 +27,8 @@ final class PhabricatorCoreCreateTransaction return $editor->getCreateObjectTitleForFeed($author, $object); } + public function getActionStrength() { + return 140; + } + }
โ This approach was tested and seems to work.
It improves the situation in: Maniphest, Phriction.
It has no negative impact on these that seem already OK: Calendar, Dashboard, Dashboard Panel, Diffusion, Macro, Paste, Ponder, Project, Pholio.
It has no positive impact on these that seem still in the wrong order: Differential.
Proposal n. 2
...