Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception rendering files/documents
ClosedPublic

Authored by aklapper on May 13 2024, 17:49.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 24, 03:51
Unknown Object (File)
Wed, Jul 24, 03:51
Unknown Object (File)
Wed, Jul 24, 01:59
Unknown Object (File)
Tue, Jul 23, 00:28
Unknown Object (File)
Sat, Jul 20, 10:00
Unknown Object (File)
Fri, Jul 19, 19:30
Unknown Object (File)
Fri, Jul 19, 00:50
Unknown Object (File)
Mon, Jul 8, 18:14

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php:211]

Closes T15826

Test Plan

Surf a Diffusion repository and play with View Options.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable