Seems to be unused. Plus it calls Filesystem::digestForIndex() which does not exist. So if this method was ever called then it would through an exception and not reach the parent::save() call either in the line after.
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Commits
- rP9a44a81e797d: Remove unused save() method in PhabricatorUserCache
Grep and read the codebase.
Tried things that may use cache and they still work, including:
- running ./bin/cache purge --caches user successfully shows Purging "user" cache...
- the button "Purge cache" in /config/cache/ still work.
- editing a user
- changing user picture using default one
- uploading new user picture
- creating Calendar event and inviting yourself
- visiting user settings
- changing a user setting, including Timezone, Display preferences
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
It would be nice to understand why nothing calls save() 🤔 since I guess nothing calls it, or we would have a crash report.
plus, who is calling the parent::save(). Boh.
Comment Actions
Indeed, I could not find a spot calling save() in the codebase, and great-grandparent LiskDAO does not define as abstract. Maybe it's just time to remove it here?
Comment Actions
OK. Giving that also the parent::save() will fail, I think yes, feel free to nuke this method to see what happens. lol