Paths

Table of Contentst

MimeMailParser: Remove an unused variable
AbandonedPublic
Actions

Authored by aklapper on May 18 2024, 07:41.

Tags

None

Referenced Files

	F3337975: D25662.1743597392.diff
	Tue, Apr 1, 12:36

	F3321282: D25662.1743351028.diff
	Sat, Mar 29, 16:10

	F3307425: D25662.1743145570.diff
	Thu, Mar 27, 07:06

	F3305566: D25662.1743116386.diff
	Wed, Mar 26, 22:59

	F3303122: D25662.1743077059.diff
	Wed, Mar 26, 12:04

	F3296585: D25662.1742975406.diff
	Tue, Mar 25, 07:50

	F3294738: D25662.1742941961.diff
	Mon, Mar 24, 22:32

	F3284010: D25662.1742764854.diff
	Sat, Mar 22, 21:20

Subscribers

Tokens

"Love" token, awarded by valerio.bozzolan.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Summary

$parts is not used anywhere.

Test Plan

Carefully read the code.

Diff Detail

Repository

rP Phorge

Branch

mimemailparserUnusedVar (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 1286
Build 1286: arc lint + arc unit

Event Timeline

aklapper created this revision.May 18 2024, 07:41

Owners added a reviewer: O1: Blessed Committers.May 18 2024, 07:41

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMay 18 2024, 07:41

aklapper requested review of this revision.May 18 2024, 07:41

Harbormaster completed remote builds in B1286: Diff 2018.May 18 2024, 07:41

Uh? It seems in use to me, in legacy lines 142, 145, 154, 155, etc.

This revision now requires changes to proceed.May 18 2024, 12:56

I'm stupid and should have really checked the commit history first. Sorry!

valerio.bozzolan awarded a token.May 18 2024, 19:50

Revision Contents
Changeset List

Path

Size

Packages

externals/

mimemailparser/

MimeMailParser.class.php

5 lines

O1: Blessed Committers

Diff 2018

View Options

externals/mimemailparser/MimeMailParser.class.php

MimeMailParser: Remove an unused variableAbandonedPublicActions