Page MenuHomePhorge

Correct call to non-existing PhutilFileLockException in support/unit/lock.php
ClosedPublic

Authored by aklapper on May 16 2024, 08:53.
Tags
None
Referenced Files
F2982093: D25641.1739944766.diff
Tue, Feb 18, 05:59
F2960630: D25641.1739151496.diff
Sun, Feb 9, 01:38
F2960577: D25641.1739151376.diff
Sun, Feb 9, 01:36
F2941274: D25641.1738106569.diff
Mon, Jan 27, 23:22
F2941272: D25641.1738106567.diff
Mon, Jan 27, 23:22
F2936916: D25641.1737943355.diff
Sun, Jan 26, 02:02
F2904877: D25641.1737335561.diff
Jan 19 2025, 01:12
F2868482: D25641.1736669594.diff
Jan 11 2025, 08:13

Details

Summary

PhutilFileLockException does not exist. Per https://we.phorge.it/source/arcanist/browse/master/src/filesystem/PhutilFileLock.php$54-66 , if lock acquisition fails it is supposed to throw a PhutilLockException instead.

Test Plan

Grep the code base.

Or, run this, from arcanist, from two different terminals:

php ./support/unit/lock.php asd.txt

After this change, the exception is correctly managed.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable