Page MenuHomePhorge

Correct call to non-existing PhutilFileLockException in support/unit/lock.php
ClosedPublic

Authored by aklapper on May 16 2024, 08:53.
Tags
None
Referenced Files
F3331576: D25641.1743509839.diff
Mon, Mar 31, 12:17
F3331202: D25641.1743503001.diff
Mon, Mar 31, 10:23
F3328976: D25641.1743467330.diff
Mon, Mar 31, 00:28
F3328022: D25641.1743448516.diff
Sun, Mar 30, 19:15
F3318697: D25641.1743290427.diff
Fri, Mar 28, 23:20
F3293521: D25641.1742916000.diff
Mon, Mar 24, 15:20
F3292578: D25641.1742895180.diff
Mon, Mar 24, 09:33
F3283793: D25641.1742760123.diff
Sat, Mar 22, 20:02

Details

Summary

PhutilFileLockException does not exist. Per https://we.phorge.it/source/arcanist/browse/master/src/filesystem/PhutilFileLock.php$54-66 , if lock acquisition fails it is supposed to throw a PhutilLockException instead.

Test Plan

Grep the code base.

Or, run this, from arcanist, from two different terminals:

php ./support/unit/lock.php asd.txt

After this change, the exception is correctly managed.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable