Differential D25649
Fix call to non-existing getApplication() in PhabricatorDashboardPanelListController Authored by aklapper on May 16 2024, 11:28.
Details
PhabricatorDashboardPanelListController twice calls $this->getApplication() which is not defined in this class or any of its parent classes. Thus call existing getCurrentApplication() in great-grandparent class AphrontController instead. ($this->getApplication() was likely incorrectly copied from *SearchEngine classes where that method exists.) Ref T15844 Carefully read the code and check available methods in its parent classes.
Diff Detail
Event TimelineComment Actions The test plan should be:
Comment Actions Hi, could you elaborate a bit (which exact method, from which class to which class)? Thanks. Comment Actions Yup. I noticed that probably the method getNewUserBody() should be just moved from PhabricatorDashboardPanelListController to PhabricatorDashboardPanelSearchEngine. Additional details in T15844. Comment Actions Sorry again for the confusion, I don't want to create extra work. I will create another patch as clarification. Unfortunate legacy situation. Comment Actions Nah, appreciated if you think that there is a better / more correct way to fix this which also covers a bigger underlying issue that you found. :) Comment Actions
A good captain never abandon its ship (?) But you have Italian friends, so, abandoning ship, and "lying to the authorities", it's our dirty business - ref: https://en.wikipedia.org/wiki/Francesco_Schettino Comment Actions Okay I'll just re-arrange the chairs on the ship deck a bit then, double-swear! Abandoning in favor of D25674 |