@valerio.bozzolan & @avivey What is the best practice for setting up the role/server check when new users attempt to auth via the oauth, you can't set limits on the oauth from discords side of view so you'd need to set them up on phorge, I've put down some ideas in the above comment.

In D25513#14722, @aklapper wrote:

Also, apart from the linter results, this patch should not include the changes from D25512

How would i go about implementing it such that for a user to sign in with discord they need to have certain roles.

In D25513#14724, @valerio.bozzolan wrote:

(Small tip: never work in master. Create a git branch for each feature, in sync with origin/master, and with your commits on top of that, so your patch is minimal and arc diff works)

(Small tip: never work in master. Create a git branch for each feature, in sync with origin/master, and with your commits on top of that, so your patch is minimal and arc diff works)

Also, apart from the linter results, this patch should not include the changes from D25512

Also hide "Buckets" search field on diffusion/commit/query/advanced/ when Audit is uninstalled

In D25507#14682, @valerio.bozzolan wrote:

Yeah I honestly don't know if uppercase or lowercase.

manual rebase

LGTM. Tested locally and works as expected, use case also makes sense, plus this is only about public keys.

In D25390#11765, @valerio.bozzolan wrote:

if (!is_array($value)) {  // ←←←←←←←←← May be this needs to be converted to is_string($value) or similar thing

This seems reasonable since it's nonsense to me to decode an integer, or decode a float. Only decoding a string makes sense to me.

Only call json_decode() in PhabricatorStandardCustomFieldPHIDs.php on string values, instead of not calling setValueFromApplicationTransactions() in PhabricatorCustomFieldEditField.php as proposed by Valerio

Yeah I honestly don't know if uppercase or lowercase.

Tested locally, all in all +1 but capitalization is inconsistent comparing to maniphest.custom-field-definitions: Custom Fields twice and User Profiles once should use lower-case.

I sincerely think this is lovely. Thanks. I do not understand how you figure it out all these keywords and in what order and associated to what, but hey, it works.

I set this to unbreak now just to give extra visibility on the homepage :^)

Ah, before landing, please consider an additional line in the comment (like the proposed one)

As far as I can understand, the generated file name here is 100% for commodity purposes: not used for anything on the filesystem, not used as unique key in something, not used to check whenever the file should be created again or not.

I'm testing this. It works and this makes me happy. Please wait Sunday before landing this, so others can give an eye.

Can you try changing this line in your local install?

Probably causing problems with Facebook OAuth

Use strlen() instead of empty string check

Same comment about keeping strlen. Up to you if you want to switch before landing.

Simplify some code / fix TODOs as proposed by Valerio

ty

Just for the records and bystanders: All expectations described in D25503#14539 are also what the patch currently does.

Use strlen() instead of empty string check

Ideally, comments are a general things and should be kept. Also changing Tags and Subscribers etc. is generic and should be kept.

Does anyone dare to accept the last revision? :)

The updated one-liner welcomes another review :)

Noticed a few dangling phacility references in URLs in documentation, which could lead users to grabbing upstream Phabricator versions by mistake:

phorge/src/docs/user/field/xhprof.diviner:  $ git clone https://github.com/phacility/xhprof.git
phorge/src/docs/user/userguide/arcanist.diviner:  some_install_path/ $ git clone https://github.com/phacility/arcanist.git
phorge/src/docs/user/userguide/arcanist_quick_start.diviner:  somewhere/ $ git clone https://github.com/phacility/arcanist.git

corresponding to:
https://we.phorge.it/book/phorge/article/xhprof/#installing-xhprof
https://we.phorge.it/book/phorge/article/arcanist/#installing-arcanist
https://we.phorge.it/book/phorge/article/arcanist_quick_start/#installing-arcanist

Under the hood branches are already supported by the locate feature. The whole file tree is loaded via AJAX, when you first click in the input field. This tree represents the current selected branch.

did you find a solution for this?

Run arc diff from my computer that has Xdebug enabled

Can someone explain what these "Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage'" messages mean ?
Are these automated unit tests run on we.phorge.it or on my system ?

Completely agree on lowering their ranking as default

@fgaz - did you find a solution for this?
For the "make Phorge extensions easy to install" feature (which I can't find the ticket for), I have a vague plan of adding another file describing available/installed extensions. I'd like to make packaging harder if I can avoid it, so possibly whatever solves local.json can solve this file too.

I have some containers I put together for development which could provide a place to start
https://github.com/neandrake/phab-dev

In T15566#14934, @valerio.bozzolan wrote:

I've just found again this

https://github.com/cooperspencer/phorge/

In T15673#14931, @valerio.bozzolan wrote:

OH MY GOD FOR SOME REASONS THEY RE-OPENED OUR PROPOSAL \o/ IT'S HAPPENING!

https://pretalx.fosdem.org/fosdem-2024/talk/review/EXZNAUXQKMJ7HRYYRD7MKFXTTV8JFQDJ

I do not remember who was developing Docker stuff for this. I've just found again this

OH MY GOD FOR SOME REASONS THEY RE-OPENED OUR PROPOSAL \o/ IT'S HAPPENING!

Just discovered this from secure dot, 2017

This works as long as getFieldValue() never returns an object (that has a toString, that may be empty)

Thanks. Don't take my comments seriously. Probably they have no sense.