This is exactly the same as I've done on the system I patched at my workplace. I apologize for not submitting my own patch, I didn't have access to my work systems during the holidays.

Hoping to be useful I've added you as reviewer in D25508: Add support for FIDO2-backed SSH keys

Some possibilities:

fix missing Transform entry

Also instead of “Goodie” maybe “Helper” or something. Maybe there’s a similar naming elsewhere in the code base

I forgot I had this requesting changes. Any idea of the performance hit in markup rendering now that PhutilURI is constructed for every link? I think its constructor does a fair amount.

You are doing a nice work.

Hi deric,

Alternatively, maybe catch the existing exception and show a nice error message + the form?

Still red light? Thanks :)

the simplest other-solution would be to extract the exception thrown to its own method, and override that method in the child-class:

How about other functions that might require a logged-in user? "current Viewer's Projects" for example?

In D25505#14525, @20after4 wrote:

Is this needed simply because PhabricatorApplicationSearchController doesn't actually have a try { } block to catch this particular case? Maybe we could improve the exception handling instead of return null?

Is this needed simply because PhabricatorApplicationSearchController doesn't actually have a try { } block to catch this particular case? Maybe we could improve the exception handling instead of return null?

Without D25505 applied:

Remove a forgotten debug line

This is not ready for merge yet.

Indeed ideally I'd prefer to convert the current use of PhabricatorSearchTextField for an integer value to a functioning PhabricatorSearchIntField (which should return a future new AphrontFormIntControl()) instead, thus I'm reluctant to land this (though it remains a mystery to me how to set a default value (not: placeholder) in any non-dropdown field).

Replace minus dash by its UTF8 representation to pass lint

In D25501#14443, @aklapper wrote:

This also needs rework because I still get a Query overheated when not being logged in and going to http://phorge.localhost/feed/transactions/query/all/

So, as default, a transform is created. Should we attach that transform instead?

Would you like to propose a small cute patch for this? It's just a matter of running arc diff or ../arcanist/bin/arc diff

In addition, it seems only the owner can see their stuff here.

unknown magic accepts any kind of input (e.g. letters) and converts it into a 0.

Thanks! some quick tips maybe relevant:

In D25479#14404, @avivey wrote:

Yeah, looks like IntField isn't doing much now (yet?). It could get setDefault() like PhabricatorSearchSelectField, plus validateControlValue()

This also needs rework because I still get a Query overheated when not being logged in and going to http://phorge.localhost/feed/transactions/query/all/

There might be room for performance improvements - currently for each $query, PhabricatorApplication::isClassInstalledForViewer is called again though some queries share the same application.

Document abstract function that it can return string|null

Also looked into very hackish $application_of_query = preg_split('/(?=[A-Z])/', get_class($query)); but the *TransactionQuery.php class naming scheme is too inconsistent, e.g. PhabricatorSpacesTransactionQuery instead of SpacesTransactionQuery (same for Slowvote, Phurl, Owners, Badges, Calendar, Packages, Paste, maybe more).

If it still works, feel free to land

probably "low", but might be interesting to investigate.

Improve performance (as proposed by Valerio)

Yeah, looks like IntField isn't doing much now (yet?)

That's so weird! My instinct is of course to say that it should be completely unrelated to this patch since no CSS is touched in this one-line change... I have no idea how to debug this ☹️