@valerio.bozzolan I actually think the right place to look at the usage of getSpecialRules() might be here: https://we.phorge.it/source/phorge/browse/master/src/applications/policy/filter/PhabricatorPolicyFilter.php;4f845d8f8c77$693-719

By the way, is there a task or project about UI text improvements that this task could be made part of? I am looking e.g. at the button in this very comment box saying "Set Sail for Adventure", which, while amusing, is also prone to cause confusion.

How about something like "Endorse"? That might remove the connotations of speaking for the project position that something like "approve" or "accept" may imply.

In T15640#13668, @valerio.bozzolan wrote:

Are you aware of any non-git repository in Wikimedia?

Makes sense; let's close for now. (I need to get used to Conduit throwing exceptions into our server log for random broken input. I do not like that Conduit behavior.)

I'm generally scared by strlen() things since it means it was probably relying on implicit cast-to-string.

I'm trying to imagine a title that also involves the UX in general about accepting revisions, since it's also about the "Accept Revision" button, but my brain is not helping me right now in this

Honestly, I don't know why we have old commits improperly filled, you can maybe play with svnadmin command on a dummy repo as described here : Change author of SVN commit

Tested locally, works as advertised.

No further changes requested in 13 days, so am going to land this diff.

I was trying to test this, but I don't know how to do a Subversion commit without a committer name 🤔

PhabricatorFileAttachmentQuery seems to eagerly load the object relation, however since the DestructionEngine extensions run after the object is already deleted, this fails and nothing is returned in the query. Changed to LiskDAO loadAllWhere, which also seems to use less queries in general (due to not eagerly loading), so changed the query in PhabricatorFile as well. Changed mpull to foreach per suggestion.

Decreasing just a bit the priority since we are a bit confused about how to proceed but feel free to change

It could also be some bots sending you fuzzy input. Consider to mark as invalid, until a real human being elevates this as a problem affecting some workflows.

Note that the upstream solution from Phabricator does not fix your problem, since

Are you aware of any non-git repository in Wikimedia?

Kindly marking as "request changes" only to indicate "waiting for author feedback"

Commit fixup/update author details

Organised attachment deletion from the file side into the File object and deletion from the object side into the destruction engine extension. Also updated the SQL patch date in the file name.

Without a reproduction, this is speculative.

Why would a branch name be an integer and not a string?

Looks like this created a regression: T15639: Exception: Value passed to "phutil_string_cast()" is an array in PhabricatorApplicationSearchEngine.php

Fixed my dirty tree, sorry

In D25066#8893, @valerio.bozzolan wrote:

Hi @20after4 :) Can I ask you if this could be useful in Wikimedia? I think yep

I like it but I haven't tested locally.

Yeah, I generally agree with "let the user set the width of the page"...

Thanks Eyal for the quick answer.

Update unit test

Updates as per reviews

Add a note about figlet

Can you add a couple of tests to https://we.phorge.it/source/arcanist/browse/master/src/utils/__tests__/cowsay/ ?

I'm talking about Herald Webhook, not Herald Rule. So you can write some web code that is visited when something happens, so you can run custom code when that happens, and you can edit your Tasks.

Thanks for the Answer @valerio.bozzolan.
I have created those checklists as custom fields. The problem I have is all these lists are shown in all types of tickets and statuses.
But later with this checklist, I want to control the the status transition.
Eg: Only when "Checklist 1" and "Checklist 2" are selected, User should be able to change the status from In progress - Ready for testing.