Page MenuHomePhorge
Create Task
Maniphest T15642

Feed Transaction Logs: Exception: Query overheated: examined more than 1,010 raw rows without finding 101 visible objects.
Open, Needs TriagePublic
Actions

Description

Steps to reproduce:

  1. PHP 8.2.10; Phorge at 91faf16cace9308440087d64f17c068e04313c50
  2. Create 900 tasks with a View Policy set to User1
  3. Log into Phorge as User2
  4. As User2, go to see all transaction logs in the Feed at http://phorge.localhost/feed/transactions/query/all/

Actual outcome:

[2023-09-21 11:08:47] EXCEPTION: (Exception) Query (of class "ManiphestTransactionQuery") overheated: examined more than 1,010 raw rows without finding 101 visible objects. at [<phorge>/src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php:342]
arcanist(head=customOAuthUrlencodeNull, ref.master=df6c315ace5f, ref.customOAuthUrlencodeNull=c69b9749027f), phorge(head=master, ref.master=91faf16cace9)
  #0 <#2> PhabricatorPolicyAwareQuery::execute() called at [<phorge>/src/applications/feed/query/PhabricatorFeedTransactionQuery.php:107]
  #1 <#2> PhabricatorFeedTransactionQuery::loadPage() called at [<phorge>/src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php:251]
  #2 <#2> PhabricatorPolicyAwareQuery::execute() called at [<phorge>/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php:400]
  #3 <#2> PhabricatorCursorPagedPolicyAwareQuery::executeWithCursorPager(AphrontCursorPagerView) called at [<phorge>/src/applications/search/engine/PhabricatorApplicationSearchEngine.php:1038]
  #4 <#2> PhabricatorApplicationSearchEngine::executeQuery(PhabricatorFeedTransactionQuery, AphrontCursorPagerView) called at [<phorge>/src/applications/search/controller/PhabricatorApplicationSearchController.php:256]
  #5 <#2> PhabricatorApplicationSearchController::processSearchRequest() called at [<phorge>/src/applications/search/controller/PhabricatorApplicationSearchController.php:91]
  #6 <#2> PhabricatorApplicationSearchController::processRequest() called at [<phorge>/src/aphront/AphrontController.php:29]
  #7 <#2> AphrontController::handleRequest(AphrontRequest) called at [<phorge>/src/aphront/AphrontController.php:71]
  #8 <#2> AphrontController::delegateToController(PhabricatorApplicationSearchController) called at [<phorge>/src/applications/search/engine/PhabricatorApplicationSearchEngine.php:50]
  #9 <#2> PhabricatorApplicationSearchEngine::buildResponse() called at [<phorge>/src/applications/feed/controller/PhabricatorFeedTransactionListController.php:13]
  #10 <#2> PhabricatorFeedTransactionListController::handleRequest(AphrontRequest) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:284]
  #11 phlog(Exception) called at [<phorge>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:41]
  #12 PhabricatorDefaultRequestExceptionHandler::handleRequestThrowable(AphrontRequest, Exception) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:751]
  #13 AphrontApplicationConfiguration::handleThrowable(Exception) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:296]
  #14 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:203]
  #15 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35]

See also:

Upstreamed from https://phabricator.wikimedia.org/T344232

Related Objects

Mentioned Here
P24 T15642

Event Timeline

aklapper created this task.Sep 21 2023, 11:12
Herald added subscribers: Cigaryno, Matthew, chris, tobiaswiese. · View Herald TranscriptSep 21 2023, 11:12
aklapper updated the task description. (Show Details)Nov 1 2023, 22:25

However, it would make sense not to query transactions in applications which once were installed and are now uninstalled and not accessible anymore anyway.
In downstream https://phabricator.wikimedia.org/T344232 , the exception is Query (of class "ConpherenceTransactionQuery") overheated.
However we uninstalled Conpherence more than four years ago in https://phabricator.wikimedia.org/T127640 (but of course the DB data is still around).

If anyone knows how to best determine the application class related to a TransactionQuery class, please share. See this proof of concept patch (which would require adding a getApplicationClassName() method to many *TransactionQuery.php classes):

P24 T15642
1diff --git a/src/applications/feed/query/PhabricatorFeedTransactionQuery.php b/src/applications/feed/query/PhabricatorFeedTransactionQuery.php
2index d0a9f53e35..42ee332c1c 100644
3--- a/src/applications/feed/query/PhabricatorFeedTransactionQuery.php
4+++ b/src/applications/feed/query/PhabricatorFeedTransactionQuery.php
5@@ -155,6 +155,20 @@ final class PhabricatorFeedTransactionQuery
6 ->setAncestorClass('PhabricatorApplicationTransactionQuery')
7 ->execute();
8
9+ // Remove TransactionQuery classes that belong to previously installed apps
10+ // which got uninstalled in the meantime: Increases query performance and
11+ // decreases likeliness that a "Query Overheated" error will be displayed.
12+ // See https://secure.phabricator.com/T13133, https://we.phorge.it/T15642
13+ foreach ($queries as $key => $query) {
14+ if (method_exists($query, 'getApplicationClassName')) {
15+ $application_class_name = $query->getApplicationClassName();
16+ $application = new $application_class_name();
17+ if (!$application->isInstalled()) {
18+ unset($queries[$key]);
19+ }
20+ }
21+ }
22+
23 $type_map = array();
24
25 // If we're querying for specific transaction PHIDs, we only need to
26diff --git a/src/applications/maniphest/query/ManiphestTransactionQuery.php b/src/applications/maniphest/query/ManiphestTransactionQuery.php
27index 9826107b77..49efe36a20 100644
28--- a/src/applications/maniphest/query/ManiphestTransactionQuery.php
29+++ b/src/applications/maniphest/query/ManiphestTransactionQuery.php
30@@ -7,4 +7,8 @@ final class ManiphestTransactionQuery
31 return new ManiphestTransaction();
32 }
33
34+ public function getApplicationClassName() {
35+ return 'PhabricatorManiphestApplication';
36+ }
37+
38 }

valerio.bozzolan subscribed.Thu, Nov 2, 08:08
20after4 subscribed.Mon, Nov 13, 14:58

Maybe this is a clue?

/source/phorge/browse/master/src/applications/transactions/storage/PhabricatorModularTransactionType.php$407

protected function requireApplicationCapability($capability) {
    $application_class = $this->getEditor()->getEditorApplicationClass();
    $application = newv($application_class, array());
}

so something like this might work?

$xaction = $query->getTemplateApplicationTransaction();
$application_class = $xaction->getEditor()->getEditorApplicationClass();
$application = newv($application_class, array());
aklapper added a comment.Wed, Nov 29, 19:37

so something like this might work?

I don't see how to get any editor information from within that class. (Bad getter call: getEditor)