D25360 is probably the fix for the bug, but I'm not sure about how to test it yet. It's probably fine. No idea what would happen if you just re-encode a file and select an encoding...

Cool, I'll play with it and see what I can find.

Do you know off the top of your head whether the binary-detection in the commit view and the code browser view differ in some way?

You should be more reluctant to make critical comments, especially as you're obviously not familiar with the project or its history (hint: it was never a commercial product).

a php 8 fix

Ok, I got bored.

I'm going to open this question's visibility, and also answer your questions here - in the hopes we can put this issue behind us.

ah, the original intention for the second query was "even if the diff is closed", circa 2015. Back then, it was probably not possible to update a diff owned by someone else, so it made sense to add the withAuthor..

I was finally able to read the code and understand what's going on here.
The original code is strange, and the withAuthors() part in it is definitely wrong in context.

(Implementation notice: in both phorge and arc, this is handled in PhutilErrorHandler::handleError(), and the check is simply $num === E_DEPRECATED), and maybe E_USER_DEPRECATED.

@kwisatz maybe file a new task / re-open the old one? the screnshots are not unreadable, but if its bad enough that people complain then maybe we can find a solution.
Didn't somebody invent "webfonts" or something, so we can just package Segoe-UI and know that everyone is getting a decent view?

My plan is:

• If there's a commit information in the revision, use the author name and email from there. Not that this might not be the same as the revision's Author
• If there's no git commit - use author name from Author field, and make up email address (annonymos@example.com).

@ton - this is what I have so far:

In D25355#10291, @valerio.bozzolan wrote:

How would you describe the syntax of this?

Interestingly, I think arc unit didn't find any tests to run... I triggered this explicitly.

D25355 fixes the jshint test.

I've patched the branch and ran the tests on Linux.
Of the 6 failed test files (13 tests):

• 1 fails in master (ArcanistJSHintLinterTestCase)
• 2 are skipped locally because I don't have the external binaries (ArcanistJscsLinterTestCase, ArcanistRuboCopLinterTestCase)
• and the rest pass with these changes

To be clear - it's a single file in a single commit, in the equivalent of this page: https://we.phorge.it/rARCa604548101025875de20a9c263df3790fea425b3 - is that right?

Are you using Phorge? Administrating it?
Are you related to Softaculous?

Turns out the "Create Security Task" form doesn't allow users to create tasks, because they can't see the S2 space.

In D25021#10243, @kwisatz wrote:

...but it looks really bad to all of us here at the office (all Debian machines).
We all preferred the previous configuration which was ending up being Lato for us.

I've tried sort of reverting this diff on my system, but not knowing how to make celerity regenerate what is finally being served to clients, had little to no success.

Created R7 arc-vscode, but it's currently Observing the GH one.

PhutilURI is obviously a better type for href then string. It should not log anything in this case...

We don't allow cross-application table joins

Created Semi Structured (Extension) and R6 Semi Structured:

remove bool

Looks good - I'll try to figure out the failed tests issue(s).

@aklapper can you please re-write this ticket with the information required from a feature request?

I think this should be implemented using the getHead() method that's already defined.

I'm reasonably sure that "branches" and "bookmarks" are always strings, but not so much about "base revision" and svn.