Page MenuHomePhorge
Differential D25351

Fix PHP 8.1 substr(null) in People > Activity Logs
ClosedPublic
Actions

Authored by Sten on Jul 17 2023, 12:05.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 21, 06:27
Unknown Object (File)
Sun, Sep 3, 02:15
Unknown Object (File)
Sat, Sep 2, 05:24
Unknown Object (File)
Aug 15 2023, 10:26
Unknown Object (File)
Aug 13 2023, 20:32
Unknown Object (File)
Aug 12 2023, 02:15
Unknown Object (File)
Aug 9 2023, 00:56
Unknown Object (File)
Aug 7 2023, 20:45
View All 9 Files
Subscribers
Cigaryno
Matthew
speck
tobiaswiese
valerio.bozzolan

Details

Reviewers
avivey
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15555: PHP 8.2: "substr(null) exception" in People > Activity Logs
Commits
rPdbc101ca8ae1: Fix PHP 8.1 substr(null) in People > Activity Logs
Summary

When someone tries to log on with invalid credentials, a record is inserted in the phabricator_user.user_log table with action = login-fail.
The session value of this record is set to null in this case.

When you open the People → Activity Logs screen, you will see an exception because of this.

Fixes T15555

Test Plan

Go to https://my.phorge.site/people/logs/ after a login failure and a login success.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSizePackages
src/
applications/
people/
view/
2 linesO1: Blessed Committers

Diff 1136

View Options

src/applications/people/view/PhabricatorUserLogView.php

Loading...