Differential D25351

Fix PHP 8.1 substr(null) in People > Activity Logs
ClosedPublic
Actions

Authored by Sten on Jul 17 2023, 12:05.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15555: PHP 8.2: "substr(null) exception" in People > Activity Logs

Commits

rPdbc101ca8ae1: Fix PHP 8.1 substr(null) in People > Activity Logs

Summary

When someone tries to log on with invalid credentials, a record is inserted in the phabricator_user.user_log table with action = login-fail.
The session value of this record is set to null in this case.

When you open the People → Activity Logs screen, you will see an exception because of this.

Fixes T15555

Test Plan

Go to https://my.phorge.site/people/logs/ after a login failure and a login success.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Sten created this revision.Jul 17 2023, 12:05

Owners added a reviewer: O1: Blessed Committers.Jul 17 2023, 12:05

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 17 2023, 12:05

Sten requested review of this revision.Jul 17 2023, 12:05

Harbormaster completed remote builds in B674: Diff 1132.Jul 17 2023, 12:05

avivey accepted this revision.Jul 17 2023, 13:08

This revision is now accepted and ready to land.Jul 17 2023, 13:08

Closed by commit rPdbc101ca8ae1: Fix PHP 8.1 substr(null) in People > Activity Logs. · Explain WhyJul 17 2023, 13:23

This revision was automatically updated to reflect the committed changes.

Sten added a commit: rPdbc101ca8ae1: Fix PHP 8.1 substr(null) in People > Activity Logs.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

people/

view/

PhabricatorUserLogView.php

2 lines

O1: Blessed Committers

Diff 1136

View Options

src/applications/people/view/PhabricatorUserLogView.php

Fix PHP 8.1 substr(null) in People > Activity LogsClosedPublicActions