Page MenuHomePhorge

Fix PHP 8.1 substr(null) in People > Activity Logs
ClosedPublic

Authored by Sten on Jul 17 2023, 12:05.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 14, 10:51
Unknown Object (File)
Sun, Apr 14, 08:28
Unknown Object (File)
Mon, Apr 1, 02:26
Unknown Object (File)
Sun, Mar 31, 02:04
Unknown Object (File)
Wed, Mar 27, 15:12
Unknown Object (File)
Mar 19 2024, 22:47
Unknown Object (File)
Mar 17 2024, 18:06
Unknown Object (File)
Mar 15 2024, 13:53

Details

Summary

When someone tries to log on with invalid credentials, a record is inserted in the phabricator_user.user_log table with action = login-fail.
The session value of this record is set to null in this case.

When you open the People → Activity Logs screen, you will see an exception because of this.

Fixes T15555

Test Plan

Go to https://my.phorge.site/people/logs/ after a login failure and a login success.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable