When running './bin/diviner generate' under PHP 8.1, we get a trim(null) exception.
Fixes T15548
Details
Details
- Reviewers
avivey - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15548: PHP 8.2 "ltrim(null)" exception while executing ./bin/diviner generate
- Commits
- rP9c8b9a6bbf04: Fix PHP 8.1 trim(null) exception in ./bin/diviner generate
Run './bin/diviner generate'
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/applications/diviner/atom/DivinerAtom.php | ||
|---|---|---|
| 349 | idx-with-default | |
| src/applications/diviner/atom/DivinerAtom.php | ||
|---|---|---|
| 349 | In idx we have: if ($default === null || array_key_exists($key, $array)) {
return null;
}And as the key is set, idx returns null even if we specify a non-null default. Hence coalesce works, idx with default fails. | |
| src/applications/diviner/atom/DivinerAtom.php | ||
|---|---|---|
| 349 | ha. I never realized that! | |