I contribute mainly in Maniphest and Phriction, and sometimes look at revisions.
I also go explore Phorge and seek bugs.
Tasks I create are on this project: User-Cigaryno.
I contribute mainly in Maniphest and Phriction, and sometimes look at revisions.
I also go explore Phorge and seek bugs.
Tasks I create are on this project: User-Cigaryno.
@valerio.bozzolan could you please add to either H28 or H29 Affected files contains none of map.php?
This is one great Wikimedia patch being upstreamed. Should I make this a sub-task of T15081?
Took the opportunity to fix a typo in the summary.
On Outbound Email rules, does the Do Nothing action neither send an email nor a notification?
In T15203#21226, @valerio.bozzolan wrote:(M is short for Mockup probably)
In T16007#21223, @avivey wrote:In T16007#21196, @Cigaryno wrote:In T16007#21194, @avivey wrote:Ideally, any current Prototype can be either promoted to Core, extracted to its own extension, or removed completely. Each extension/author can have their own policy on contributing.
Already, any new app that would be considered "Prototype" today should just go in its own extension, and we decided to remove a couple.
It depends on who on the wild (including large private companies developing closed-source software) is using prototype applications on Phorge. This should let us know if it should be promoted to core, separated into an extension, or removed completely if no one uses it (like Releeph and Phragments). Or even better, hold a Slowvote for each prototype application's future and possibly have Phorge's customers to vote (maybe notify as much as possible by creating a blog post about the vote to notify those who use the Atom feed).
I'm not sure that "usage" is really the best way to choose between "promote to core" and "extension"; The way I imagine it, in addition to the Core, we'll have a set of "highly recommended extensions" maintained, and a single step to install all of them when setting up a new machine. In that world, any app that can be separated out to an extension will be.
The prototypes can usually be curved out easily, without effecting the rest of the code.
In T15203#21219, @avivey wrote:The V123 syntax is disabled by remarkup.ignored-object-names config by default; The default is /^(Q|V|M|P)\d$/ (basically anything starting with Q, V, M, or P), for "Q1" (biz-talk for April), "V1" (for versions), "M1" (for ?????) and "P1" (Jira for "important bug").
I'm honestly surprised about layout=inline working for {T123} - I thought is only works for images. But it can probably be made to work for Votes (or rather, all objects) like it does for tasks.
What you see is 100% normal regardless of your pixel density, display size and resolution.
With a similar approach to T15920, this can be achieved. However, I think there is one disadvantage: text may be crammed with a side hierarchy, resulting in lots of newlines for documents with long titles.
You can create a task now that you are member of Trusted Contributors.
In D25889#24581, @aklapper wrote:Hmm, maybe should not change ->setURI("/people/tasks/{$id}/") because there might be external third-party code relying on this?
@vabocharov please set the view policy of F3250825 to Public.
In T16007#21194, @avivey wrote:My thought on this is that long term, we'll remove the concept of "prototype" completely in favor of Extensions.
Prototypes that need a long way before being promoted to Core are those that should be separated into extensions.
In D25905#24572, @aklapper wrote:
Obsoleted by D25909: Diviner: Contributing Code: Update section on Prototype Changes. I think @aklapper should have instead commandeered this rev but it's still okay to have a new revision instead.
In T16007#21080, @aklapper wrote:I do not think changes are necessarily needed, because it already says "With rare exceptions".
Bug fixes and security patches are indeed exceptions but not rare exceptions, assuming they fix problems with rough prototypes.
@valerio.bozzolan try to create the global rule now.
Sounds good. It should have no CAPTCHA configured (maybe we.phorge.it needs CAPTCHA to reduce unused account creations) and just like on secure.phabricator.com (see this), there should be a notice for users willing to demo the software on the demo instance and not the upstream instance (in Phabricator you can create a Phacility test instance and even to this day, this is still possible).
@speck if you think this thing works properly, you can either resign or click on Accept Revision, because when @valerio.bozzolan accepted the revision, it still appeared as Needs Revision.
This is a great proposal. Did anyone think of showing two separate queries on Tasks: Assigned and Authored. In my opinion, it just makes it harder to scroll down to authored tasks which is why it makes more sense to have separate Assigned Tasks and Authored Tasks views on the profile menu.
@Tgr you want something like this?: T16008: Provide an easy way to link to a Phorge task in a user-friendly way
If so, just enclose the task ID in {} (ie {T16008}
Fix the typo in line 167
In D25881#24380, @aklapper wrote:Thanks. I'm personally fine with bug fixes for prototype apps.
In D25904#24401, @valerio.bozzolan wrote:
Would sending messages be pevented on archived rooms and would all participants be removed (unless Can Edit is set to Room Participants)?
In T15237#14300, @valerio.bozzolan wrote:I think a dedicated policy for "Can send messages" would be better, to cover more cases. It would be strange that all participants must also be allowed to edit all settings.
In D25881#24322, @aklapper wrote:@Cigaryno: Please provide references when you quote something from somewhere so others don't have to guess where to find things. Thanks!
@mainframe98's patch for fixing Packages makes me think about the current contribution policy for prototype applications. It currently states:
With rare exceptions, we do not accept patches for prototype applications for the same reasons that we don't accept feature requests or bug reports.
Maybe this is one obsolete Phabricator-specific contributing policy?
Because the email address is set no noreply@secure.phorge.dev, it does not seem to be possible with standard emailers to email replies. Blessed Roots may try to add Application Emails to Maniphest and Differential.
Don't find a problem with this at all.
I can't see an Edit Task option in the dropdown. What actually enables this?
Most of these can be done by adding the following to controller files related to query, list, and view files:
In D25874#23455, @aklapper wrote:I'm a bit worried that people will create Pull Requests on Github after downloading from Github...
Apart from download speed, are there other reasons why to recommend an external service?
I think you are right for unnecessary catetorization and sending notifications.