Page MenuHomePhorge

Add "Authored Tasks" view / item to user profile menu
Needs ReviewPublic

Authored by aklapper on Tue, Feb 18, 07:57.
Tags
None
Referenced Files
F2988404: D25889.1740150763.diff
Thu, Feb 20, 15:12
F2988353: D25889.1740147557.diff
Thu, Feb 20, 14:19
F2988214: D25889.1740133840.diff
Thu, Feb 20, 10:30
F2982822: D25889.1739971932.diff
Tue, Feb 18, 13:32
F2982774: D25889.1739971816.diff
Tue, Feb 18, 13:30
F2982554: D25889.1739963352.diff
Tue, Feb 18, 11:09
F2982519: D25889.1739962500.diff
Tue, Feb 18, 10:55
F2982489: D25889.1739960407.diff
Tue, Feb 18, 10:20

Details

Summary

The sidebar menu items in the People view (user profiles) currently include User, Tasks, Revisions, Commits, Badges, Manage.
Tasks implicitly refers to assigned tasks, while Revisions implicitly refers to authored revisions.
However, some (maybe less developer workflow oriented) users have expected Tasks to link to their authored tasks instead.
Thus add an additional menu item called Authored Tasks which allows a quick view of the tasks created by the user.

Also be more explicit about the relationship between user and objects by adding an adjective ("Authored", "Assigned", "Received") to their names.
We have two Tasks related items now, so we need to differentiate anyway.

Closes T15998

fix some lint stuff

Test Plan
  • As user1, create tasks and assign tasks to yourself.
  • Go to http://phorge.localhost/p/user1/ and click the menu items in the sidebar, including the new option "Authored Tasks".

Diff Detail

Repository
rP Phorge
Branch
profileSidebarCreatedTasks (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1728
Build 1728: arc lint + arc unit

Event Timeline

For consistency, I'm wondering whether to

  • rename src/applications/people/menuitem/PhabricatorPeopleTasksProfileMenuItem.php to src/applications/people/menuitem/PhabricatorPeopleTasksAssignedProfileMenuItem.php,
  • rename src/applications/people/controller/PhabricatorPeopleProfileTasksController.php to src/applications/people/controller/PhabricatorPeopleProfileTasksAssignedController.php,
  • update const ITEM_TASKS = 'people.tasks' to const ITEM_TASKS_ASSIGNED = 'people.tasks.assigned;,
  • update 'tasks/(?P<id>[1-9]\d*)/' =>'PhabricatorPeopleProfileTasksController' to 'tasks-assigned/(?P<id>[1-9]\d*)/' =>'PhabricatorPeopleProfileTasksAssignedController'

as there is more than one "task" thingie now?