Add "Authored Tasks" view / item to user profile menu
Needs ReviewPublic
Actions

Authored by aklapper on Feb 18 2025, 07:57.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15998: Add an "Authored Tasks" view/item to People profile menu

Summary

The sidebar menu items in the People view (user profiles) currently include User, Tasks, Revisions, Commits, Badges, Manage.
Tasks implicitly refers to assigned tasks, while Revisions implicitly refers to authored revisions.
However, some (maybe less developer workflow oriented) users have expected Tasks to link to their authored tasks instead.
Thus add an additional menu item called Authored Tasks which allows a quick view of the tasks created by the user.

Also be more explicit about the relationship between user and objects by adding an adjective ("Authored", "Assigned", "Received") to their names.
We have two Tasks related items now, so we need to differentiate anyway.

Closes T15998

fix some lint stuff

Test Plan

As user1, create tasks and assign tasks to yourself.
Go to http://phorge.localhost/p/user1/ and click the menu items in the sidebar, including the new option "Authored Tasks".
Click both "Assigned Tasks" and "Authored Tasks" in the sidebar on http://phorge.localhost/p/user1/ and get results displayed.
Being logged in, on a default installation go to http://phorge.localhost/maniphest/ to still see your assigned tasks and "Assigned" and "Authored" as Query options in the sidebar (no change in behavior).

Diff Detail

Repository

rP Phorge

Branch

profileSidebarCreatedTasks (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1800
Build 1800: arc lint + arc unit

Event Timeline

aklapper created this revision.Feb 18 2025, 07:57

Owners added a reviewer: O1: Blessed Committers.Feb 18 2025, 07:57

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFeb 18 2025, 07:57

aklapper requested review of this revision.Feb 18 2025, 07:57

Harbormaster completed remote builds in B1728: Diff 2676.Feb 18 2025, 07:57

For consistency, I'm wondering whether to

rename src/applications/people/menuitem/PhabricatorPeopleTasksProfileMenuItem.php to src/applications/people/menuitem/PhabricatorPeopleTasksAssignedProfileMenuItem.php,
rename src/applications/people/controller/PhabricatorPeopleProfileTasksController.php to src/applications/people/controller/PhabricatorPeopleProfileTasksAssignedController.php,
update const ITEM_TASKS = 'people.tasks' to const ITEM_TASKS_ASSIGNED = 'people.tasks.assigned;,
update 'tasks/(?P<id>[1-9]\d*)/' =>'PhabricatorPeopleProfileTasksController' to 'tasks-assigned/(?P<id>[1-9]\d*)/' =>'PhabricatorPeopleProfileTasksAssignedController'

as there is more than one "task" thingie now?

aklapper edited the test plan for this revision. (Show Details)Sat, Mar 1, 18:18

Rename source files from Tasks to TasksAssigned for consistency; update two more exposed strings

Harbormaster completed remote builds in B1755: Diff 2708.Sat, Mar 1, 18:29

aklapper edited the test plan for this revision. (Show Details)Sat, Mar 1, 18:29

Fix a typo

Harbormaster completed remote builds in B1775: Diff 2735.Sat, Mar 8, 17:34

Hmm, maybe should not change ->setURI("/people/tasks/{$id}/") because there might be external third-party code relying on this?

In D25889#24581, @aklapper wrote:

Hmm, maybe should not change ->setURI("/people/tasks/{$id}/") because there might be external third-party code relying on this?

Sounds reasonable. If not, the patch could be landed as is and we can mention a breaking change for the Assigned Tasks URI in the Change Log.