Page MenuHomePhorge

Update TOTP suggestions to open-source applications
ClosedPublic

Authored by Cigaryno on Sat, Mar 29, 13:21.

Details

Summary

Replaces Authy and Google Authenticator, both proprietary with FreeOTP, Bitwarden Authenticator, Aegis, and 2FAS, all free and open-source.
Closes T16018

Test Plan
  • Setup TOTP factor in the Auth app.
  • Setup the TOTP factor on your account.
  • On both, double check the text for any typo or missing app. If any, click on Request Changes.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I'd prefer not to remove common proprietary software options but list FOSS options first.

I'd prefer not to remove common proprietary software options but list FOSS options first.

If you want, you can discus at T16018.

Per @aklapper, it's best to show both closed-source and open-source TOTP apps.

I'd personally not remove common proprietary software options (as it makes life of users potentially harder if they already have such an app installed) but list FOSS options first.

Some FoSS devs may not be familiar at all with open-source TOTP apps. I personally use Google Authenticator so I agree with you and also, I have my TOTP content on WinAuth too, which is unmaintained however I am not ready to switch TOTP app on my Windows PC (my revs from now on are created from an Ubuntu VM due to the arc troubles I am having on Windows).

Mention closed-source apps in addition to open-source apps per @aklapper

src/applications/auth/factor/PhabricatorTOTPAuthFactor.php
26

I'd replace the "and" with "or" here, for consistency.

39

This comma turned into a dot (but I'd remove it anyway in this sentence).

aklapper requested changes to this revision.Sun, Mar 30, 19:11

Should be fine after these two changes :)

This revision now requires changes to proceed.Sun, Mar 30, 19:11

Looks good to me, thanks!

This revision is now accepted and ready to land.Mon, Mar 31, 13:01