Is the input to parseDiff guaranteed to be UTF-8 encoded? I don’t have the code on-hand to look up but it’s possible encoding is handled elsewhere — or arc might have a hard requirement for all input to be UTF-8. All mercurial commands run by arcanist are done with a flag to enforce UTF-8.

Hmm I’ve used mercurial and arcanist/Phab for years at my company and don’t believe we’ve ever run into this. Any idea what’s causing the presence of the BOM? We’ll apply a change to handle the UTF-8 bom but I am curious what may have caused it to show up. Is your hgrc configured in some way for this or maybe an environment variable?

I'm tempted to just change that one line to $left = idx($view_data, 'left', 0); so there shoud not be a crash at this stage anymore but instead the default value 0 is passed to the DifferentialDiffQuery and to the new DifferentialTransactionView... but I lack a reproducer to check if all other code is fine with this.

PHP 8.2.14, Phorge at cc964550f945b08c64970c01a34b55314e8ef0aa

1. As an admin, check that /config/edit/user.require-real-name/ is set to Make real names optional
2. Log out of Phorge
3. Go to http://phorge.localhost/auth/register/
4. See that the Real Name field does not state Required on the right
5. Enter values into the fields Username, Password, Confirm Password, Email
6. Click the Register Account button

I've created R10 PhorgeIt Extension for this, with a little bit of content. I'll load it to the server shortly.

Reference: rPdfcccd4cb882a171d10ba8a5c2763dcc73654256

+lots for removing the words "storage containers" - projects are very much not "storage".
A better metaphor is "labels" or "index" (like in a printed book? Is that something young people know about?).

Also for Archived Projects, and maybe some other objects.
I'm not sure if there's a generic way to do this, or if each search-engine needs to be updated manually.

+1 on Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses.

In T15582#12521, @valerio.bozzolan wrote:

clarify why the Disable User button [...] not sufficient for this purpose.

I'd like to keep this boring:
Projects are hashtags are tags. You can use them for code bases, teams, or anything you need to group.

Do you mean "action"? If yes, I can reproduce

Indeed this fixes the problem. Premising there is still some mystery here that may deserve additional eyes.

Sentence case <3

Part of this Diff has no sense now that I learned that... some of these has sense. Let's close.

Sounds easy enough to implement.

Doc(s) on new extensions: I remember having a chapter under /book/contrib/, but I can't find it now. We should build a guide under T15030.
Short answer: create a new repo, make an src dir with all the code, and run arc liberate to create a "library" (including __phutil_library_init__.php and __phutil_library_map__.php), and then add the path of the extension to load-libraries in conf.json.

I copy/pasted the keys of the getStyleMap() function dictionary into chatgpt with some remark that they were part of a syntax highlighting mechanism.
I asked it to translate them into something more readable.

In T15708#15014, @avivey wrote:

I'd like to see this as an Extension rather then go into the rP, just because we want to have more stuff as extensions; I think this area is abstracted enough so that it can easily be made that way.

That could be a good target as well for this, Is there docs on how extensions should be made?

I'd like to see this as an Extension rather then go into the rP, just because we want to have more stuff as extensions; I think this area is abstracted enough so that it can easily be made that way.

Double-accept yeah

@valerio.bozzolan & @avivey What is the best practice for setting up the role/server check when new users attempt to auth via the oauth, you can't set limits on the oauth from discords side of view so you'd need to set them up on phorge, I've put down some ideas in the above comment.

In D25513#14722, @aklapper wrote:

Also, apart from the linter results, this patch should not include the changes from D25512

How would i go about implementing it such that for a user to sign in with discord they need to have certain roles.

In D25513#14724, @valerio.bozzolan wrote:

(Small tip: never work in master. Create a git branch for each feature, in sync with origin/master, and with your commits on top of that, so your patch is minimal and arc diff works)

(Small tip: never work in master. Create a git branch for each feature, in sync with origin/master, and with your commits on top of that, so your patch is minimal and arc diff works)

Also, apart from the linter results, this patch should not include the changes from D25512

Also hide "Buckets" search field on diffusion/commit/query/advanced/ when Audit is uninstalled

In D25507#14682, @valerio.bozzolan wrote:

Yeah I honestly don't know if uppercase or lowercase.

manual rebase

LGTM. Tested locally and works as expected, use case also makes sense, plus this is only about public keys.

In D25390#11765, @valerio.bozzolan wrote:

if (!is_array($value)) {  // ←←←←←←←←← May be this needs to be converted to is_string($value) or similar thing

This seems reasonable since it's nonsense to me to decode an integer, or decode a float. Only decoding a string makes sense to me.

Only call json_decode() in PhabricatorStandardCustomFieldPHIDs.php on string values, instead of not calling setValueFromApplicationTransactions() in PhabricatorCustomFieldEditField.php as proposed by Valerio

Yeah I honestly don't know if uppercase or lowercase.

Tested locally, all in all +1 but capitalization is inconsistent comparing to maniphest.custom-field-definitions: Custom Fields twice and User Profiles once should use lower-case.

I sincerely think this is lovely. Thanks. I do not understand how you figure it out all these keywords and in what order and associated to what, but hey, it works.

I set this to unbreak now just to give extra visibility on the homepage :^)

Ah, before landing, please consider an additional line in the comment (like the proposed one)

As far as I can understand, the generated file name here is 100% for commodity purposes: not used for anything on the filesystem, not used as unique key in something, not used to check whenever the file should be created again or not.

I'm testing this. It works and this makes me happy. Please wait Sunday before landing this, so others can give an eye.

Can you try changing this line in your local install?

Probably causing problems with Facebook OAuth

Use strlen() instead of empty string check

Same comment about keeping strlen. Up to you if you want to switch before landing.

Simplify some code / fix TODOs as proposed by Valerio

ty

Just for the records and bystanders: All expectations described in D25503#14539 are also what the patch currently does.

Use strlen() instead of empty string check