Page MenuHomePhorge

Trigger: Capitalize most Buzzwords in our Weird Way as usual
Needs ReviewPublic

Authored by valerio.bozzolan on Mar 22 2023, 00:08.
Tags
None
Referenced Files
F418479: D25078.id.diff
Fri, Dec 8, 12:59
F417911: D25078.id352.diff
Fri, Dec 8, 07:00
F417377: D25078.id353.diff
Thu, Dec 7, 21:56
Unknown Object (File)
Thu, Dec 7, 19:14
Unknown Object (File)
Thu, Dec 7, 12:38
Unknown Object (File)
Thu, Nov 30, 21:51
Unknown Object (File)
Fri, Nov 24, 22:17
Unknown Object (File)
Fri, Nov 24, 22:17
Tokens
"Hungry Hippo" token, awarded by valerio.bozzolan.

Details

Reviewers
Sten
Group Reviewers
O1: Blessed Committers
Test Plan
  • Open the Trigger Page from a Workboard Column
  • See that Most Things are Finally in this usual Weird Way

Diff Detail

Repository
rP Phorge
Branch
arcpatch-D25078_1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 737
Build 737: arc lint + arc unit

Event Timeline

update celerity to make the lint happy

  • also fix small typo "elmement"
Sten subscribed.

Apart from the pre-existing 'Statues' typo, looks good to me...

src/applications/project/trigger/PhabricatorProjectTriggerManiphestStatusRule.php
27

Plural of 'Status' is 'Statuses'. 'Statues' is the plural of 'Statue', which is something different.

let's also fix a typo (thanks Sten)