Page MenuHomePhorge

Trigger: Capitalize most Buzzwords in our Weird Way as usual
AbandonedPublic

Authored by valerio.bozzolan on Mar 22 2023, 00:08.
Tags
None
Referenced Files
F3329276: D25078.1743472530.diff
Mon, Mar 31, 01:55
F3328401: D25078.1743456308.diff
Sun, Mar 30, 21:25
F3307396: D25078.1743145217.diff
Thu, Mar 27, 07:00
F3306719: D25078.1743130858.diff
Thu, Mar 27, 03:00
F3306022: D25078.1743123366.diff
Thu, Mar 27, 00:56
F3299723: D25078.1743027521.diff
Tue, Mar 25, 22:18
F3298404: D25078.1743001414.diff
Tue, Mar 25, 15:03
F3291969: D25078.1742885333.diff
Mon, Mar 24, 06:48
Tokens
"Hungry Hippo" token, awarded by valerio.bozzolan.

Details

Reviewers
Sten
Group Reviewers
O1: Blessed Committers
Test Plan
  • Open the Trigger Page from a Workboard Column
  • See that Most Things are Finally in this usual Weird Way

Diff Detail

Repository
rP Phorge
Branch
arcpatch-D25078_1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 737
Build 737: arc lint + arc unit

Event Timeline

update celerity to make the lint happy

  • also fix small typo "elmement"
Sten subscribed.

Apart from the pre-existing 'Statues' typo, looks good to me...

src/applications/project/trigger/PhabricatorProjectTriggerManiphestStatusRule.php
27

Plural of 'Status' is 'Statuses'. 'Statues' is the plural of 'Statue', which is something different.

let's also fix a typo (thanks Sten)

valerio.bozzolan added a subscriber: aklapper.

Part of this Diff has no sense now that I learned that... some of these has sense. Let's close.

Yeah I honestly don't know if uppercase or lowercase.

In this case should be lower-case because consistency and because it's pretty much a full sentence.

Relevant. "User Profiles":

https://we.phorge.it/source/phorge/browse/master/src/applications/people/config/PhabricatorUserConfigOptions.php$7

That's probably a page title and thus title case.

Also, "User profiles", 4 lines below:

https://we.phorge.it/source/phorge/browse/master/src/applications/people/config/PhabricatorUserConfigOptions.php$7

That's probably a button text or such and seems to be sentence case...