In D25426#12221, @avivey wrote:

See D25420 for a conflicting change...

I like this approach, and prefer it to my simpler attempt from D25426; but have some minor suggestions:

Check out https://we.phorge.it/book/contrib/article/javascript_coding_standards/ and the Javeline docs here: https://github.com/phacility/javelin/tree/master/src/docs/concepts
(I'll try to render the Javeline guide here later).

Sorry, I mean this link:

I absolutely don't know what we are doing here since I don't know the supposed "Phabricator way" to interact with the DOM via JavaScript using its library.

Screenshot from:

We were able to push Phorge subliminal messages in an official Wikimedia video \o/

Yeah thanks! Maybe we can somehow keep the footer, in order to have a link for people like me that just have their brain switched-off and just look at the bottom link. Also maybe we can simplify a little bit.

Thanks for this patch. Yeah if I understand correctly, this should work:

I'm Valerio, a simple person: I see "GNU/Linux" and I say "yeah, land".

See D25420 for a conflicting change...

ooh, check out D25349 for basically this exact use-case...

IMO the added text should be connected to the second sentence of the existing third paragraph, maybe as a separate paragraph. In fact I'd suggest re-grouping the paragraphs differently, to focus on a brief intro, info for users, and info for contributors. Perhaps something like this:

@valerio.bozzolan I found the js section where with the listener for open/close the persistent chat. From there I can get element somehow (by ID I don't think it would be good, because it seems to be auto-generated (UQ3_0)) and remove the class "core-menu-item" and the invisible gear icon will no longer be clickable. If the chat is not minimized, we add the class back so we can see it and click it.

cosmetic whitespace changes

Updating D25420:

This is very promising. Just added an inline comment

if you check the checkbox, it will use the current setting timezone.

Updating D25420: Updating D25420: fixed tests error

Updating D25420: Added a checkbox to ignore timezone conflict in Adjust Timezone dialog window. Using the checkbox instead of a button because this way it's possible to reuse the existing form. Also, i still didn't find a way to capture the additional button click event. This way, if you check the checkbox, it will use the current setting timezone.

This is very probably a recent regression since I cannot reproduce on Wikimedia Phabricator.

Looks good

Looks good to me.

This happens also with the Upload File dialog

Ah! I can reproduce exactly in this comment!

Finally, after additional tests, I guess these issue are not related (as related in T15629)

consider more cases

fix corner case of NULL phid