Potentially related to Herald. Adding Herald to raise more attention.

try now

Tried. I Shall Not Pass :O

@valerio.bozzolan go ahead and give it a try? I think you have access to create rules.

I'd be very much in favor and I'd be happy to contribute changes for this. I've added type hints in my local fork to assist in development. Especially for core utility functions like idx and id which otherwise completely hide type information.

The code to select which tests to run by default is in ArcanistWorkflow::selectPathsForWorkflow().

There is no Edit Task option in the Add Action... dropdown. What makes you think so?

I can't see an Edit Task option in the dropdown. What actually enables this?

@avivey what do you think about? Maybe we can test with some powerful clicks

git rebase master; ./bin/celerity map; shows no output

Thanks for the quick review. I'll refrain from touching JS and CSS files.

I confirm that ./bin/celerity map does nothing after this change

Oh boy. D25893 first, I guess.

This makes me and probably other people mad lol

Aaand last 48 lines checked. Differential is crashing in my laptop lol

(Review 3 of ?)

P.S. maybe nice to introduce in AphrontView a method like getUserRequired() or something similar to implement exactly this logic - so we avoid that scattered logic everywhere

(epic review part 1 of ?)

I wonder if shouldAllowPublic() was just forgotten or if the idea behind was to exclude web crawlers (as querying those lists en-masse could be expensive).

Most of these can be done by adding the following to controller files related to query, list, and view files:

and reviews love you too! (lol)

Do the easier and more obvious thing that Valerio proposed

Argh, right... That's why I love reviews! :D Thus also check for null.

In D25872#23861, @nib wrote:

@aklapper Would it make sense to move the branch-naming lines into a function in class ArcanistGitWorkEngine, since it the branch-naming is git-specific? E.g.

public function buildBranchName($task_ref) {
  $task_name = $task_ref->getName();
  // regex, preg_replace, trim, etc
  return $branch_name;
}

@aklapper Would it make sense to move the branch-naming lines into a function in class ArcanistGitWorkEngine, since it the branch-naming is git-specific? E.g.

Hopefully the latest change will work for you. Now it checks existing git branches matching "T12345*" and if any exist, it will git checkout the first one, else it will create it from the task name.
So that should allow you to change the task title, and to use arc work T12345 as many times as you want without error.

• Fix indents, adds emoji support, improve REGEX
• Detect existing branch for task

• Handles existing branches
• Fixes indents, adds emoji support, improves REGEX

Fixes error when invoking arc work 2nd time on task id

I don't know if anybody is supposed to run

Alright, even after calling ->withEpochInRange(null, null) this very code change (comparing null with null) works fine without a problem, so I'd not add that additional null check

Oh wait I totally misunderstood you, sigh

Uh, nice thought! Phorge accepts and handles correctly one or two parameters being null which I think is fine as-is, so I'd only check for switched parameters created by confused developers here.

Small question. Is it supposed to be used with null+null?

Maybe also just declaring $path = '' as default in 209

Ooops, indeed. Thanks for finding that. Abandoning in favor of D25869.

In D25363#18825, @aklapper wrote:

• Resulting E13 still shows "Private User 1" to "Private User 5" with no user matching - I don't think that is expected but I'm not sure we want to care as that is no regression?

I've tested this and I'm impressed. You probably have changed my life.

• Fixes indents, adds emoji support, improves REGEX

For consistency, I'm wondering whether to

• rename src/applications/people/menuitem/PhabricatorPeopleTasksProfileMenuItem.php to src/applications/people/menuitem/PhabricatorPeopleTasksAssignedProfileMenuItem.php,
• rename src/applications/people/controller/PhabricatorPeopleProfileTasksController.php to src/applications/people/controller/PhabricatorPeopleProfileTasksAssignedController.php,
• update const ITEM_TASKS = 'people.tasks' to const ITEM_TASKS_ASSIGNED = 'people.tasks.assigned;,
• update 'tasks/(?P<id>[1-9]\d*)/' =>'PhabricatorPeopleProfileTasksController' to 'tasks-assigned/(?P<id>[1-9]\d*)/' =>'PhabricatorPeopleProfileTasksAssignedController'

as there is more than one "task" thingie now?

In T15726#15399, @aklapper wrote:

Fund: Going to http://phorge.localhost/fund/create/ and creating a New Initiative anyway yields

EXCEPTION: (RuntimeException) Undefined array key "totalAsCurrency" at [<arcanist>/src/error/PhutilErrorHandler.php:273]

Gotcha. Any opinion on this?

Maybe duplicate patch, look for same title (I'm on mobile now)

This would absolutely be useful in both the personal and professional Phorge instances I admin :)

Yes, please!

In D25864#23737, @valerio.bozzolan wrote:

Question: in an ideal world would you love even more the same button, that "just" prefills the textarea?