@deric you should land this revision, right?
If you're having troubles, ask on Z1 for help or ask somebody else to land.

Eh, let's make this exit(0) as that's more consistent with existing calls in the Arcanist codebase

Thanks. I can confirm with PHP 8.4.4 after upgrading one of my machines.

Probably same game as T15679 somewhere in src/applications/phriction/controller/PhrictionMoveController.php

In T15990#20841, @aklapper wrote:

Which PHP version do you use?

Note that (clone $foo)->bar() is still invalid so you need to use id(clone $foo)->bar().

Finally something that can be tested using arc anoid - I guess?

Test plan works! Thanks :3

grep -r " id(" --include=*.php . | wc -l gives a whopping 11220 results.
Would we accept a patch if I cooked up one? :)

I fail to reproduce with PHP 8.3 with the given steps: ../arcanist/bin/arc diff --create --help prints the help as expected, with no error.
Which PHP version do you use?

Hi @nib - still thanks and you are welcome in updating this patch using something like this:

last cosmetic change on a title with extra "==="

Question: in an ideal world would you love even more the same button, that "just" prefills the textarea? That could be also probably done server-side, without JavaScript. That would help T15991 even more I think.

git rebase master

add missing comma

implement tips, simplify (thanks)

With full respect of Badges, I don't see how a business can build an empire on this Badges menu entry. Anyway, if your business feel tampered by having this moved down by some pixels, please propose a patch to introduce a better menu management for this, like project menu that is more flexible :3

Insert a tear to play again :3

Tools make no mistakes.

Okay, got to wait until D25885 is merged first

Okay, got to wait until D25885 is merged first

Let's try again without celerity noise

I wonder what's wrong with my CSS/JS, sigh

As I uploaded a new diff now how do I request a new review / reset the existing one "Changes Requested"?
"Foist Upon", or which vaguely named oh so "funny" option from the "Add Action..." dropdown which makes non-native speakers feel stupid and be scared to choose the wrong option? Oh UX and usability...

having a portal with something useful (e.g. a Dashboard): shows the Dashboard

Remove first person voice in a few areas. And a bit of swearing that slipped through from my notes.

Run ./bin/celerity map

Rename function to override from parent class, as proposed by Valerio

Right, PhabricatorDashboardPortalProfileMenuEngine extends PhabricatorProfileMenuEngine so we can override newNoContentView()... that probably makes most sense, thanks

You have to check out an old version of the translations repo. You wrote the steps to reproduce at T15811, and they still reproduce without this patch and don't with it.

I'd love to see better steps to reproduce something somewhere. :-/ I cannot even find e.p.p. or epp. somewhere in the Finnish translations anymore...

I expanded the test plan a bit, still if there is more to add please also expand. This seems to work for me (phamous last words)

Fix unaligned elements by changing margin-left: -200px to -200px for div.phui-document-content and for full-size images

git rebase master

./bin/celerity map as this touches a JS file

@mturdus: Could you land this one please, or would you like any help? Thanks!

In D25859#23607, @aklapper wrote:

I took the liberty to edit the commit message a bit to make reproduction easier (handy URIs to test, plus include the error message which allows easier search).

@valerio.bozzolan: Would you like to give this a (hopefully) final review? TIA!

Setting Request Changes per the small review comments so far (as I am looking at https://we.phorge.it/differential/query/all/ and it helps to see correct statuses)

Thanks for the patch! I can confirm that after applying the patch, on PHP 8.3 I can successful create the initiative http://phorge.localhost/I4 (and I get an unrelated PHP 8.1 deprecation warning about strlen(): Passing null to parameter #1 in src/applications/fund/xaction/FundInitiativeDescriptionTransaction.php:19)

This is impressive, thanks for writing this up! I don't have enough expertise to comment on the "Edit Phases", however all in all this looks super helpful for technical understanding!

Confirming that this works as expected. I took the liberty to expand the commit message to also include the current error message.