Works on my machine!
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Tue, Nov 26
Thanks :)
Also update the PhpDoc accordingly
Ignore PHP 8.3.0's new DateMalformedStringException and stick to generic Exception in all cases instead
Handle whitespace-only task and project titles correctly
This needs rework as the logic currently does not properly handle entering a title consisting of whitespace only. (Outcome gets unpleasant afterwards.)
Mon, Nov 25
Sun, Nov 24
It might be slightly safer to use PhutilURI, but this is in any case a potentially-unsafe configuration.
Sat, Nov 23
https://devina.io/redos-checker says the new regex is still prone to polynomial backtracking, but that can happen only on extremely contrived input, whereas the old one was exponential on a common case.
Fix lint
Digging deeper, the problem is specific to ProjectRemarkupRule::getObjectIDPattern. That returns:
Step 2: Remove irrelevant character class exclusions:
Disentangling that monster regex, step 1:
Indeed https://devina.io/redos-checker says the aformentioned regex is exponential time worst-case
I monkeypatched the code to print preg_last_error when the problematic preg_match returns null. The error is "Backtrack limit exhausted".
Nov 22 2024
Thanks :)
This should be resolved by now in git master
Nov 21 2024
Ah, the mythical Platypus Ornithopter!
Nov 20 2024
Nov 17 2024
Double-accept
Nov 16 2024
In D25823#22340, @keithzg wrote:... Conversely, arc browse . works for what I expected a pathless invocation to do, and funny enough that doesn't work on Git repos! So we have feature parity ;)
Nov 15 2024
In D25823#22324, @valerio.bozzolan wrote:Hi @keithzg (and any SVN hacker) do you like the new added Subversion support?
Yep. I'm up-to-date with master as of filing the issue^^.
This textbox isn't a Remarkup field (it's actually a ConpherenceDurableColumnView, which doesn't even have a metadata field in the first place)
In normal Conpherence views, the "Upload file" button works just fine. (except as mentioned in Z1, where reloading the page erases the metadata field)
Thanks. Can you reproduce with "Upload file" button too? If yes, maybe sub-task of: T15106: "Upload file" in remarkup text fields should attach by default
Nov 13 2024
@avivey Thanks for the tip about arguments allow-list in getArguments() https://we.phorge.it/source/arcanist/browse/master/src/workflow/ArcanistLintWorkflow.php$67 but I was not able to use that since here it's using getWorkflowArguments() 🤔 So I've just added a warning. It works lol. Check "BRANCH OPTION NOT AVAILABLE"
found a corner case, fixed
Nov 12 2024
I think that, after the hidden comment is loaded in its bulk, "some more comments" are loaded as context for the hidden comment 🤔 So I guess that extra loading is probably a feature and not a bug.
Wikimedia Foundation has this in production since years. I think it doesn't hurt.
Hi @keithzg (and any SVN hacker) do you like the new added Subversion support?
Nov 11 2024
Nov 5 2024
Probably not enough consensus for a mass edit. Best we can do is case-by-case fixes reading warn reports.
Any other test plan suggested? Current ones: delete simple milestone, delete project with milestone, delete a project with sub-projects, delete a sub-project, ecc.
Nov 2 2024
One weird observation:
helping reviewers, adding comment on future export possibility