Hi @nib - still thanks and you are welcome in updating this patch using something like this:

last cosmetic change on a title with extra "==="

Question: in an ideal world would you love even more the same button, that "just" prefills the textarea? That could be also probably done server-side, without JavaScript. That would help T15991 even more I think.

add missing comma

implement tips, simplify (thanks)

With full respect of Badges, I don't see how a business can build an empire on this Badges menu entry. Anyway, if your business feel tampered by having this moved down by some pixels, please propose a patch to introduce a better menu management for this, like project menu that is more flexible :3

Insert a tear to play again :3

You're fast. lol I approve because life is too short.

(Maybe also moving in line 316, before phutil_utf8_strtolower() and the regexes)

With this I have a regression in /w/. Do you have too?

Thanks Cigaryno. I think it's good to start a discussion on this and I appreciate you started this. I also have seen github.com suggested somewhere.

Thanks. I'm curious if there's anything up that should not call this with null. Also I'm curious to test with a couple of date filters and custom date fields.

Thanks! I'm sorry that the execute method has undocumented return.

Thanks! I share a comment on the fly, maybe more comment soon after a test :)

OK super! <3

Thaanks!

(1. Are you an heroic package manager? <3 nice to know!)

I see the PHP approach is interestingly in line with stuff like line 11. wow lol. Thanks

Whopsie whopsie... you are now in the family of trusted contributors \o/

Do you think that this is wontfix? I think yes after https://we.phorge.it/T15281#10042

P.S. - finally a Mercurial user! Please try D25823 in Mercurial :D if it works for you, feel free to accept, or share any feedback

(Don't worry, I'm also super confused by arc now. lol - it still does not apply cleanly to me, so I've downloaded the patch...)

Maybe we need to rebase on top of 7955fe6df701 (I don't have the base af404703cbe9 locally)

Thaaanks taavi! Known non-issue: somebody may wonder why in Maniphest the "Queries" are listed before other things. I may answer that in Phame the "Queries" are listed after other things. So this is consistent with Phame /phame/post/ page. lol

If you want to easily try that missing piece I can add it with a little cute amend (keeping your authorship). We can always rollback the patch if you don't like the result or if it creates a nuclear weapon. Sounds OK?

OK probably just this is missing

It works on my computer but I see that in the left sidebar usually there is "Queries" 🤔 instead it seems to work for ManiphestController and similar ones

Welcome PHP 8.4

(Additional context: as follow-up request, the most adopted token MUST always be "fox" or "🦊", forever - even if not available. So maybe the implementation is a bit simpler and efficient 👍 lol)

Double slam-sgtm

add little cute comment and newline, to make it clear that the comment belongs only to that line, and really nothing else lol

Makes sense looking at

It works on my computer. Thaaaanks \o/

Decreasing priority since this happens only if you have not any posts.

(Sorry @mturdus I didn't want to assign this to you. It was automatically assigned by sub-task.)

It works on my computer \o/ thanks

fix PhabricatorPeopleProfilePictureController and PhabricatorProjectEditPictureController,
thanks to generic "transform" stuff from PhabricatorFileTransform

Hoping to be useful I will amend to fix 2 new errors caused by my suggestion.

Ouch the non-static method raised an error. I'm investigating a possible fix to keep this non-static approach in the next 20 minutes

Maybe since "we live in interesting times" we can increase such limit indeed also, but that logic makes some sense (but terrible user experience, I agree lol)

I also thought that, but I think the current limitation (4096 x 4096) is reasonable and was introduced to avoid to scale huge things and mitigate resource exhaustion in thumb generation.

Still untested but seems nice thanks <3

Yep, maybe the "Dummy project" can be a "personal project", that is, just a workboard with your name, like this:

Ah, I'm the author of this. Yes, let's abyss into decline. Thanks Andre

Yeah no problem.

Thanks revi. Dear @dereckson probably your nice installation is still on the legacy Phabricator? (or a Phorge before 2023 Week 17, accordingly to wiki search results)

Mark as "oh noooo boring comments from bozz" :3

Uh there's also phid_group_by_type($type) for extra readability and less code. Also maybe more modular for future things.

Hi @jmeador would you appreciate an help to update this?

Double-slam-accept

Since init_metrics() is supposed to be never called, maybe we can continue to do not define it 🤔

Any additional tips for the test plan? Maybe hacker @20after4

Thanks! If you remember which parts of the interface you've already tested, feel free to mention in the Test Plan, so I can maybe help in testing other parts

Interestingly, PhutilClassMapQuery supports a ->setFilterMethod('something'), but it seems over-complicated to me, since it's supposed to call $query->something() as filter using mfilter($query, 'something'). But, to do that in this way, we may want to add something in the parent class PhabricatorApplicationTransactionQuery - but this seems not needed at the moment and, moreover, I don't like its backend mfilter()...

Suggested meme for closing: "yesyes"

How an extension can have their unit tests then? 🤔

Love it. Also, showing the field "edit summary" would be extra loved

Let's mark this as "more hackers needed to escape from rabbit hole" lol

(I cannot reproduce anymore, now I see the very - ugly - native desktop notification of my environment lol; but it's difficult to note since I've configured my computer to disappear after 0.5 seconds - also maybe a common problem I guess)