Page MenuHomePhorge
Feed Advanced Search

Mon, Feb 17

valerio.bozzolan added a comment to D25872: Implements arc work for git workflow.

Hi @nib - still thanks and you are welcome in updating this patch using something like this:

Mon, Feb 17, 10:25
valerio.bozzolan updated the diff for D25772: Projects: improve quality of destroy workflow.

last cosmetic change on a title with extra "==="

Mon, Feb 17, 09:18 · Projects
valerio.bozzolan added a comment to D25864: Paste previous milestone's description text when creating a new milestone.

Question: in an ideal world would you love even more the same button, that "just" prefills the textarea? That could be also probably done server-side, without JavaScript. That would help T15991 even more I think.

Mon, Feb 17, 09:06
valerio.bozzolan updated the diff for D25772: Projects: improve quality of destroy workflow.

add missing comma

Mon, Feb 17, 08:16 · Projects
valerio.bozzolan added inline comments to D25772: Projects: improve quality of destroy workflow.
Mon, Feb 17, 08:16 · Projects
valerio.bozzolan updated the diff for D25772: Projects: improve quality of destroy workflow.

implement tips, simplify (thanks)

Mon, Feb 17, 08:09 · Projects
valerio.bozzolan accepted D25879: Fix editing Conpherence rooms on mobile.

jackie_chan_wtf

Mon, Feb 17, 07:39
valerio.bozzolan changed the image for Image Macro "jackie_chan_wtf".
Mon, Feb 17, 07:32
valerio.bozzolan accepted D25876: People Profile Menu: Move "Badges" item lower in panel list.

With full respect of Badges, I don't see how a business can build an empire on this Badges menu entry. Anyway, if your business feel tampered by having this moved down by some pixels, please propose a patch to introduce a better menu management for this, like project menu that is more flexible :3

Mon, Feb 17, 07:28
valerio.bozzolan accepted D25884: Add some trivial Herald related PhpDoc comments.

yesyes

Mon, Feb 17, 07:16
valerio.bozzolan awarded D25885: Run ./bin/celerity map a Love token.
Mon, Feb 17, 07:13
valerio.bozzolan accepted D25885: Run ./bin/celerity map.

Insert a tear to play again :3

Mon, Feb 17, 07:13

Fri, Feb 14

valerio.bozzolan accepted D25875: PHP 8.1: Do not pass null to ctype_digit() in AphrontFormDateControlValue::getStandardDateFormat().

You're fast. lol I approve because life is too short.

Fri, Feb 14, 15:43
valerio.bozzolan awarded D25874: Update installation guide to point to GitHub mirrors a Manufacturing Defect? token.
Fri, Feb 14, 14:40
valerio.bozzolan added a comment to D25875: PHP 8.1: Do not pass null to ctype_digit() in AphrontFormDateControlValue::getStandardDateFormat().

(Maybe also moving in line 316, before phutil_utf8_strtolower() and the regexes)

Fri, Feb 14, 13:57
valerio.bozzolan added a comment to D25873: Fix overlapping elements in Phame for >1791px width.

With this I have a regression in /w/. Do you have too?

Fri, Feb 14, 13:43
valerio.bozzolan added a comment to D25874: Update installation guide to point to GitHub mirrors.

Thanks Cigaryno. I think it's good to start a discussion on this and I appreciate you started this. I also have seen github.com suggested somewhere.

Fri, Feb 14, 09:22
valerio.bozzolan created T15995: User config change: add more useful title in feed (PhabricatorUserPreferencesTransaction).
Fri, Feb 14, 09:03 · Bug Reports, Feed, Auth
valerio.bozzolan added a comment to D25875: PHP 8.1: Do not pass null to ctype_digit() in AphrontFormDateControlValue::getStandardDateFormat().

Thanks. I'm curious if there's anything up that should not call this with null. Also I'm curious to test with a couple of date filters and custom date fields.

Fri, Feb 14, 08:41

Thu, Feb 13

valerio.bozzolan accepted D25869: Fix PHP 8 exit status cannot be null error in PhutilArgumentParser.

Thanks! I'm sorry that the execute method has undocumented return.

Thu, Feb 13, 11:28 · PHP 8 support
valerio.bozzolan edited the content of Next Up.
Thu, Feb 13, 08:08
valerio.bozzolan added a member for Trusted Contributors: nib.
Thu, Feb 13, 07:30
valerio.bozzolan added a comment to D25872: Implements arc work for git workflow.

Thanks! I share a comment on the fly, maybe more comment soon after a test :)

Thu, Feb 13, 07:30

Tue, Feb 11

valerio.bozzolan awarded D25870: Skip writing symbol cache to non-writable directories a Yellow Medal token.
Tue, Feb 11, 07:17
valerio.bozzolan requested changes to D25870: Skip writing symbol cache to non-writable directories.

OK super! <3

Tue, Feb 11, 06:53
valerio.bozzolan updated the test plan for D25871: xhpast: Skip -minline-all-stringops on non-x86 architectures.
Tue, Feb 11, 06:50
valerio.bozzolan accepted D25871: xhpast: Skip -minline-all-stringops on non-x86 architectures.

Thaanks!

Tue, Feb 11, 06:49
valerio.bozzolan added a comment to D25870: Skip writing symbol cache to non-writable directories.

(1. Are you an heroic package manager? <3 nice to know!)

Tue, Feb 11, 06:48
valerio.bozzolan requested changes to D25871: xhpast: Skip -minline-all-stringops on non-x86 architectures.
Tue, Feb 11, 06:21
valerio.bozzolan added inline comments to D25871: xhpast: Skip -minline-all-stringops on non-x86 architectures.
Tue, Feb 11, 06:19
valerio.bozzolan accepted D25871: xhpast: Skip -minline-all-stringops on non-x86 architectures.

I see the PHP approach is interestingly in line with stuff like line 11. wow lol. Thanks

Tue, Feb 11, 06:18
valerio.bozzolan added a member for Trusted Contributors: xtex.
Tue, Feb 11, 06:17

Feb 7 2025

valerio.bozzolan added a comment to Q168: Improvements to Mercurial workflows.

Whopsie whopsie... you are now in the family of trusted contributors \o/

Feb 7 2025, 07:58
valerio.bozzolan added a member for Trusted Contributors: amybones.
Feb 7 2025, 07:57

Feb 6 2025

valerio.bozzolan added a comment to T15281: $HOME missing from commands issued by ExecFuture.

Do you think that this is wontfix? I think yes after https://we.phorge.it/T15281#10042

Feb 6 2025, 11:26 · User-valerio.bozzolan, Arcanist
valerio.bozzolan updated the answer details for Q168: Improvements to Mercurial workflows (Answer 208).
Feb 6 2025, 09:39
valerio.bozzolan updated the answer details for Q168: Improvements to Mercurial workflows (Answer 208).
Feb 6 2025, 09:39
valerio.bozzolan added a comment to Q168: Improvements to Mercurial workflows.

P.S. - finally a Mercurial user! Please try D25823 in Mercurial :D if it works for you, feel free to accept, or share any feedback

Feb 6 2025, 09:38
valerio.bozzolan added Q168: Improvements to Mercurial workflows (Answer 208).
Feb 6 2025, 09:38

Feb 5 2025

valerio.bozzolan accepted D25865: Allow filtering tokens given by type of token.

(Don't worry, I'm also super confused by arc now. lol - it still does not apply cleanly to me, so I've downloaded the patch...)

Feb 5 2025, 17:36
valerio.bozzolan updated the summary of D25865: Allow filtering tokens given by type of token.
Feb 5 2025, 17:34
valerio.bozzolan added a comment to D25865: Allow filtering tokens given by type of token.

Maybe we need to rebase on top of 7955fe6df701 (I don't have the base af404703cbe9 locally)

Feb 5 2025, 16:43
valerio.bozzolan updated the test plan for D25863: Convert tokens given to use SearchEngine.
Feb 5 2025, 16:07
valerio.bozzolan accepted D25863: Convert tokens given to use SearchEngine.

Thaaanks taavi! Known non-issue: somebody may wonder why in Maniphest the "Queries" are listed before other things. I may answer that in Phame the "Queries" are listed after other things. So this is consistent with Phame /phame/post/ page. lol

Feb 5 2025, 16:04
valerio.bozzolan updated the test plan for D25863: Convert tokens given to use SearchEngine.
Feb 5 2025, 16:03
valerio.bozzolan updated the summary of D25863: Convert tokens given to use SearchEngine.
Feb 5 2025, 15:58
valerio.bozzolan added a comment to D25863: Convert tokens given to use SearchEngine.

If you want to easily try that missing piece I can add it with a little cute amend (keeping your authorship). We can always rollback the patch if you don't like the result or if it creates a nuclear weapon. Sounds OK?

Feb 5 2025, 08:06

Feb 4 2025

valerio.bozzolan added a comment to D25863: Convert tokens given to use SearchEngine.

OK probably just this is missing

Feb 4 2025, 13:58
valerio.bozzolan added a comment to D25863: Convert tokens given to use SearchEngine.

It works on my computer but I see that in the left sidebar usually there is "Queries" 🤔 instead it seems to work for ManiphestController and similar ones

Feb 4 2025, 13:54
valerio.bozzolan updated the test plan for D25863: Convert tokens given to use SearchEngine.
Feb 4 2025, 13:51
valerio.bozzolan added inline comments to D25776: Portals: Rename unused newNoMenuItemsView() to newNoContentView().
Feb 4 2025, 13:27 · Dashboards
valerio.bozzolan triaged T15989: `arc unit`: Constant E_STRICT is deprecated (with PHP 8.4) as Normal priority.

Welcome PHP 8.4

Feb 4 2025, 12:39 · Deprecation Notice, PHP 8 support, Bug Reports
valerio.bozzolan awarded T15988: Allow filtering tokens given by list of token a Like token.
Feb 4 2025, 12:00 · Feature Requests
valerio.bozzolan added a comment to T15988: Allow filtering tokens given by list of token.

(Additional context: as follow-up request, the most adopted token MUST always be "fox" or "🦊", forever - even if not available. So maybe the implementation is a bit simpler and efficient 👍 lol)

Feb 4 2025, 11:55 · Feature Requests

Feb 3 2025

valerio.bozzolan accepted D25774: Strike through archived projects in navigation crumbs.

Double slam-sgtm

Feb 3 2025, 17:25 · Projects
valerio.bozzolan updated the test plan for D25764: Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs.
Feb 3 2025, 08:00 · Remarkup
valerio.bozzolan requested changes to D25776: Portals: Rename unused newNoMenuItemsView() to newNoContentView().
Feb 3 2025, 08:00 · Dashboards
valerio.bozzolan updated the diff for D25764: Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs.

add little cute comment and newline, to make it clear that the comment belongs only to that line, and really nothing else lol

Feb 3 2025, 08:00 · Remarkup
valerio.bozzolan accepted D25751: Fix incorrect return value of PhabricatorCustomField::readValueFromObject().

Makes sense looking at

Feb 3 2025, 08:00
valerio.bozzolan accepted D25764: Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs.

It works on my computer. Thaaaanks \o/

Feb 3 2025, 08:00 · Remarkup

Feb 2 2025

waldyrious awarded T15701: Clarify that a Project is just a "Tag" a Like token.
Feb 2 2025, 20:43 · UX, Projects

Jan 22 2025

valerio.bozzolan edited the content of Next Up.
Jan 22 2025, 11:41
valerio.bozzolan added a comment to T15985: Fix UX regression in Phame.

Decreasing priority since this happens only if you have not any posts.

Jan 22 2025, 11:38 · Phame, Bug Reports, UX
valerio.bozzolan lowered the priority of T15985: Fix UX regression in Phame from High to Normal.
Jan 22 2025, 11:38 · Phame, Bug Reports, UX
valerio.bozzolan edited the content of Next Up.
Jan 22 2025, 11:30
valerio.bozzolan placed T15985: Fix UX regression in Phame up for grabs.

(Sorry @mturdus I didn't want to assign this to you. It was automatically assigned by sub-task.)

Jan 22 2025, 11:28 · Phame, Bug Reports, UX
valerio.bozzolan created T15985: Fix UX regression in Phame.
Jan 22 2025, 11:27 · Phame, Bug Reports, UX
valerio.bozzolan accepted D25862: Communicate max dimensions of profile images before upload.

It works on my computer \o/ thanks

Jan 22 2025, 07:42
valerio.bozzolan updated the diff for D25862: Communicate max dimensions of profile images before upload.

fix PhabricatorPeopleProfilePictureController and PhabricatorProjectEditPictureController,
thanks to generic "transform" stuff from PhabricatorFileTransform

Jan 22 2025, 07:33
valerio.bozzolan added a comment to D25862: Communicate max dimensions of profile images before upload.

Hoping to be useful I will amend to fix 2 new errors caused by my suggestion.

Jan 22 2025, 07:31
valerio.bozzolan added a comment to D25862: Communicate max dimensions of profile images before upload.

Ouch the non-static method raised an error. I'm investigating a possible fix to keep this non-static approach in the next 20 minutes

Jan 22 2025, 07:19

Jan 20 2025

valerio.bozzolan added a comment to T15984: Communicate maximum dimensions of avatar images.

Maybe since "we live in interesting times" we can increase such limit indeed also, but that logic makes some sense (but terrible user experience, I agree lol)

Jan 20 2025, 13:48 · Projects
valerio.bozzolan added a comment to T15984: Communicate maximum dimensions of avatar images.

I also thought that, but I think the current limitation (4096 x 4096) is reasonable and was introduced to avoid to scale huge things and mitigate resource exhaustion in thumb generation.

Jan 20 2025, 13:47 · Projects
valerio.bozzolan added a comment to D25862: Communicate max dimensions of profile images before upload.

Still untested but seems nice thanks <3

Jan 20 2025, 08:38
valerio.bozzolan added a comment to Q165: Maniphest tasks in calendar view (Answer 207).

Yep, maybe the "Dummy project" can be a "personal project", that is, just a workboard with your name, like this:

Jan 20 2025, 07:49

Jan 19 2025

valerio.bozzolan added Q165: Maniphest tasks in calendar view (Answer 206).
Jan 19 2025, 19:11

Jan 16 2025

valerio.bozzolan awarded Q164: Issue with Attached Files Displaying as Text ({F469}) a Love token.
Jan 16 2025, 17:04
valerio.bozzolan closed Q164: Issue with Attached Files Displaying as Text ({F469}) as resolved.
Jan 16 2025, 17:04
valerio.bozzolan closed T15766: Cleanup a bit MimeMailParser as Wontfix.

Ah, I'm the author of this. Yes, let's abyss into decline. Thanks Andre

Jan 16 2025, 15:19 · Mail, Good Starter Task

Jan 15 2025

valerio.bozzolan added a comment to Q164: Issue with Attached Files Displaying as Text ({F469}).

Yeah no problem.

Jan 15 2025, 16:49

Jan 13 2025

valerio.bozzolan closed T15953: `git format-patch` format not supported on differential web create form as Invalid.

Thanks revi. Dear @dereckson probably your nice installation is still on the legacy Phabricator? (or a Phorge before 2023 Week 17, accordingly to wiki search results)

Jan 13 2025, 10:39 · Differential, Phorge

Jan 12 2025

valerio.bozzolan requested changes to D25502: Make PhabricatorSearchIntField validate its input.

Mark as "oh noooo boring comments from bozz" :3

Jan 12 2025, 14:39
valerio.bozzolan accepted D25787: Remove unused PhabricatorApplicationTransactionCommentView::getStatusID().

sgtm

Jan 12 2025, 14:33
valerio.bozzolan added a comment to D25676: Fix responsible authors in DifferentialRevisionQuery.

Uh there's also phid_group_by_type($type) for extra readability and less code. Also maybe more modular for future things.

Jan 12 2025, 14:20 · Differential

Jan 10 2025

valerio.bozzolan created T15983: Install SVN for extra fun.
Jan 10 2025, 18:19 · phorge.it install
valerio.bozzolan added a comment to D25676: Fix responsible authors in DifferentialRevisionQuery.

Hi @jmeador would you appreciate an help to update this?

Jan 10 2025, 10:41 · Differential
valerio.bozzolan accepted D25855: JSON rendering: Avoid exception iterating on non-iterable objects.

Double-slam-accept

Jan 10 2025, 10:22
valerio.bozzolan added a comment to D25836: Update xhprof to latest upstream version 2.3.10.

Since init_metrics() is supposed to be never called, maybe we can continue to do not define it 🤔

Jan 10 2025, 10:17
valerio.bozzolan updated subscribers of D25823: arc browse: add support to Subversion repos.

Any additional tips for the test plan? Maybe hacker @20after4

Jan 10 2025, 10:10 · Arcanist
valerio.bozzolan closed Q159: Is MFA requiring all factors intentional? as resolved.
Jan 10 2025, 10:06
valerio.bozzolan added a comment to D25861: Don't try to translate date elements used internally in AphrontFormDateControlValue.

Thanks! If you remember which parts of the interface you've already tested, feel free to mention in the Test Plan, so I can maybe help in testing other parts

Jan 10 2025, 08:47

Jan 7 2025

valerio.bozzolan updated the test plan for D25823: arc browse: add support to Subversion repos.
Jan 7 2025, 14:07 · Arcanist
valerio.bozzolan updated the summary of D25823: arc browse: add support to Subversion repos.
Jan 7 2025, 14:00 · Arcanist
valerio.bozzolan accepted D25501: Feed: Do not query and display data of uninstalled applications.

Interestingly, PhutilClassMapQuery supports a ->setFilterMethod('something'), but it seems over-complicated to me, since it's supposed to call $query->something() as filter using mfilter($query, 'something'). But, to do that in this way, we may want to add something in the parent class PhabricatorApplicationTransactionQuery - but this seems not needed at the moment and, moreover, I don't like its backend mfilter()...

Jan 7 2025, 12:06
valerio.bozzolan added a comment to T15961: Should we adopt modern PHP type hints in Phorge source code?.

Suggested meme for closing: "yesyes"

Jan 7 2025, 11:33 · Phorge Development Tools, Discussion Needed

Dec 25 2024

valerio.bozzolan added a comment to T15519: arc-unit on phorge should ignore any currently installed extensions.

How an extension can have their unit tests then? 🤔

Dec 25 2024, 17:34 · Extension Development, Phorge Development Tools

Dec 24 2024

valerio.bozzolan added a comment to T15981: In feed story for "Edited Phriction doc", add link to diff.

Love it. Also, showing the field "edit summary" would be extra loved

Dec 24 2024, 09:13 · Feed, Good Starter Task, Phriction

Dec 20 2024

valerio.bozzolan requested changes to D25853: Add configuration option for maximum file size.

Let's mark this as "more hackers needed to escape from rabbit hole" lol

Dec 20 2024, 09:30 · Files, Config

Dec 19 2024

valerio.bozzolan accepted D25856: Add explicit cast to ArcanistUnitConsoleRenderer unit test.

yesyes

Dec 19 2024, 10:44 · Arcanist

Dec 18 2024

valerio.bozzolan added a comment to T15979: Can't grant notification permission to browser.

(I cannot reproduce anymore, now I see the very - ugly - native desktop notification of my environment lol; but it's difficult to note since I've configured my computer to disappear after 0.5 seconds - also maybe a common problem I guess)

Dec 18 2024, 07:52 · User-Cigaryno, Bug Reports