Page MenuHomePhorge

Fix incorrect return value of PhabricatorCustomField::readValueFromObject()
Needs ReviewPublic

Authored by aklapper on Jul 28 2024, 14:44.

Details

Summary

PhabricatorCustomField::readValueFromObject() returns $this while none of its seven child class implementations returns any value.
Make the method return nothing to make PHPStan a bit happier.

Closes T15895

Test Plan

Run static code analysis; read/grep the codebase.

Diff Detail

Repository
rP Phorge
Branch
customFieldReadVal
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1468
Build 1468: arc lint + arc unit