Page MenuHomePhorge

Fix incorrect return value of PhabricatorCustomField::readValueFromObject()
ClosedPublic

Authored by aklapper on Jul 28 2024, 14:44.
Tags
None
Referenced Files
F3327059: D25751.1743431880.diff
Sun, Mar 30, 14:38
F3321118: D25751.1743346388.diff
Sat, Mar 29, 14:53
F3300727: D25751.1743045444.diff
Wed, Mar 26, 03:17
F3298767: D25751.1743008823.diff
Tue, Mar 25, 17:07
F3295628: D25751.1742958128.diff
Tue, Mar 25, 03:02
F3295139: D25751.1742950791.diff
Tue, Mar 25, 00:59
F3292104: D25751.1742887290.diff
Mon, Mar 24, 07:21
F3289081: D25751.1742841258.diff
Sun, Mar 23, 18:34

Details

Summary

PhabricatorCustomField::readValueFromObject() returns $this while none of its seven child class implementations returns any value.
Make the method return nothing to make PHPStan a bit happier.

Closes T15895

Test Plan

Run static code analysis; read/grep the codebase.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable