Page MenuHomePhorge

JSON rendering: Avoid exception iterating on non-iterable objects
ClosedPublic

Authored by aklapper on Dec 11 2024, 20:14.
Tags
None
Referenced Files
F2977808: D25855.1739653350.diff
Fri, Feb 14, 21:02
F2977807: D25855.1739653349.diff
Fri, Feb 14, 21:02
F2977741: D25855.1739649508.diff
Fri, Feb 14, 19:58
F2977678: D25855.1739643826.diff
Fri, Feb 14, 18:23
F2965279: D25855.1739432420.diff
Wed, Feb 12, 07:40
F2958210: D25855.1739102288.diff
Sat, Feb 8, 11:58
F2955992: D25855.1739042598.diff
Fri, Feb 7, 19:23
F2950234: D25855.1738740908.diff
Tue, Feb 4, 07:35

Details

Summary

Check for is_iterable($object) (available since PHP 7.1) to avoid an exception calling foreach on $object in the rare case that the object is a custom Phorge class (PHUIBoxView, PhutilSafeHTML) and not an array. cf https://we.phorge.it/rARC7570dd0da119627ff83bc6db3be06b51eb5b366b for a similar patch to handle PHP stdClass objects.

See downstream https://phabricator.wikimedia.org/T373316.

Test Plan

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I see a red light in a unit test but it works on me after the patch src/parser/__tests__/ArcanistBundleTestCase.php - any comment on that? Anyway sgtm since it needs the foreach() stuff later.

sgtm

This revision is now accepted and ready to land.Dec 12 2024, 10:14

git clean -fx to hopefully avoid test failure

This revision was landed with ongoing or failed builds.Jan 10 2025, 10:51
This revision was automatically updated to reflect the committed changes.