Feed All Stories
May 19 2024
May 19 2024
aklapper updated the test plan for D25659: PHPMailer: Remove use of each() function removed in PHP 8.0.
aklapper committed rARC3cb117684f4e: Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath.
Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath
PHPMailer: Remove check for non-existing get_magic_quotes()
aklapper retitled D25663: PHPMailer: Remove check for non-existing get_magic_quotes() from PHPMailer: Remove check for non-existing `get_magic_quotes`
avivey updated the task description for T15835: Misc "Return type is not covariant" errors for method Iterator::key().
valerio.bozzolan accepted D25657: Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath.
Thanks asd
May 18 2024
May 18 2024
aklapper updated the summary of D25657: Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath.
aklapper updated the diff for D25657: Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath.
Valerio may have a point here :D
aklapper requested review of D25663: PHPMailer: Remove check for non-existing get_magic_quotes().
aklapper updated the task description for T15835: Misc "Return type is not covariant" errors for method Iterator::key().
Correct PHPDoc or add default return for numerous methods
valerio.bozzolan awarded D25662: MimeMailParser: Remove an unused variable a Love token.
I'm stupid and should have really checked the commit history first. Sorry!
Fix typo creating QRbitstream()
aklapper added a comment to D25651: Fix typo creating QRbitstream().
Uh thanks, I had no idea where the upstream is, good to know because there are a few more issues. :)
Fix PonderQuestionCreateMailReceiver accessing non-existing…
aklapper updated the test plan for D25656: Fix PonderQuestionCreateMailReceiver accessing non-existing PonderQuestionTransaction constants.
Correct call to non-existing Filesystem::removePath() in…
valerio.bozzolan updated the summary of D25651: Fix typo creating QRbitstream().
valerio.bozzolan updated the diff for D25651: Fix typo creating QRbitstream().
shot at line 1162
Thanks :3 Hoping to be useful I will amend with a minimal sed -i 's/QRbitrtream/QRbitstream/' externals/phpqrcode/phpqrcode.php
valerio.bozzolan edited the content of Next Up.
valerio.bozzolan accepted D25656: Fix PonderQuestionCreateMailReceiver accessing non-existing PonderQuestionTransaction constants.
I tested this with the following snippet:
Thanks :3 It makes sense, and I've also tested that snippet in PHP 5.5 and PHP 8.1 obtaining same results (premising that each() is not available anymore in PHP 8 as already clarified)
valerio.bozzolan accepted D25640: Correct call to non-existing Filesystem::removePath() in ArcanistDownloadWorkflow.php.
It was probably confused with the internal API executeRemovePath
valerio.bozzolan requested changes to D25662: MimeMailParser: Remove an unused variable.
Uh? It seems in use to me, in legacy lines 142, 145, 154, 155, etc.
valerio.bozzolan edited the content of 2024 week 19.
mainframe98 awarded D25626: The feed "created this task" should be the first one a Love token.
valerio.bozzolan edited the content of Next Up.
Uh! I like this.
Workboard Trigger Rule: allow to Add/Remove Subscribers
valerio.bozzolan edited the content of Next Up.
Probably OK now
valerio.bozzolan edited the content of Template.
The feed "created this task" should be the first one
aklapper requested review of D25662: MimeMailParser: Remove an unused variable.
aklapper added a comment to D25659: PHPMailer: Remove use of each() function removed in PHP 8.0.
Hmm, I also found this mentioned in https://secure.phabricator.com/T12404#256288 proposing a slightly different approach.
aklapper added inline comments to D25661: PHPMailer: Remove a check for PHP 5.0.
valerio.bozzolan added inline comments to D25661: PHPMailer: Remove a check for PHP 5.0.
PHPMailer: Remove a check for PHP 5.0
May 17 2024
May 17 2024
aklapper updated the diff for D25661: PHPMailer: Remove a check for PHP 5.0.
Indentation is awesome
aklapper requested review of D25661: PHPMailer: Remove a check for PHP 5.0.
aklapper requested review of D25659: PHPMailer: Remove use of each() function removed in PHP 8.0.
aklapper updated the task description for T15833: class.phpmailer-lite.php uses each() removed in PHP 8.0.
aklapper requested review of D25657: Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath.
aklapper requested review of D25655: Fix call to non-existing newWorkCommands() in NuanceItemType.
valerio.bozzolan added inline comments to D25602: Do not hardcode default Priority names in Project Reports tooltip.
aklapper committed rPe6925c83c187: Do not hardcode default Priority names in Project Reports tooltip.
Do not hardcode default Priority names in Project Reports tooltip
May 16 2024
May 16 2024
valerio.bozzolan added inline comments to D25602: Do not hardcode default Priority names in Project Reports tooltip.
aklapper updated the diff for D25602: Do not hardcode default Priority names in Project Reports tooltip.
Improvicate some things that valerio mentioned. (I prefer "Average" to "Normal" though; I consider "normal" a problematic term in this context.)
aklapper added a comment to D25651: Fix typo creating QRbitstream().
It's line 1162. Sorry for the line-ending collision noise, ./bin/arc diff did not want to accept my --ignore-cr-at-eol.
aklapper requested review of D25651: Fix typo creating QRbitstream().
aklapper requested review of D25650: Correct PHPDoc or add default return for numerous methods.
aklapper updated the diff for D25642: Initialize $cache_key variable in CelerityResourceController.php.
I felt it's not necessarily needed but it cannot hurt either. :)
aklapper requested review of D25647: Fix call to non-existing newIcons() in PhabricatorIconSet.
aklapper requested review of D25645: Remove unused save() method in PhabricatorUserCache.
aklapper requested review of D25643: Remove unused methods in PhabricatorEditorExtension.
valerio.bozzolan added inline comments to D25642: Initialize $cache_key variable in CelerityResourceController.php.
aklapper requested review of D25642: Initialize $cache_key variable in CelerityResourceController.php.
Remove deprecated buildStandardPage* method calls