Page MenuHomePhorge

ArcanistHardpointTask calls non-existent constructor for ArcanistHardpointFutureList
Closed, ResolvedPublic

Description

PHPStan complains about https://we.phorge.it/source/arcanist/browse/master/src/hardpoint/ArcanistHardpointTask.php$108 :
Class ArcanistHardpointFutureList does not have a constructor and must be instantiated without any parameters.

https://we.phorge.it/source/arcanist/browse/master/src/hardpoint/ArcanistHardpointTask.php$108 calls $result = new ArcanistHardpointFutureList($result);
But https://we.phorge.it/source/arcanist/browse/master/src/hardpoint/ArcanistHardpointFutureList.php has no constructor.

This code was added in rARC85141c4d909b2a832eea3dcff70be1c43089c690.