Thanks \o/ Can reproduce.

Maybe unrelated. But after we fix PhabricatorCursorPagedPolicyAwareQuery, maybe we will find a crash test also for the first two lines:

Interestingly I was able to reproduce, but only creating 101+ tasks manually and going to the next page. So after that ?after=100 is introduced.

adopt PhabricatorEnv::isSelfURI()

1. (Yes, arc liberate --clean. I'll also run it in Phorge).
2. I'll check it again, I refactored some things and maybe I broke that.

Thanks. Premising I have only knowledge of traits, but not mapbuilder.

@littleggghost I think you might just need to run celerity to update the icons.

Interesting. I see. Maybe expanding its controller that should be this one:

Yeah, in this one special place it doesn't matter; But that page already have a special body, so we can save even the extra click by putting the message right there...

OK I see. Indeed we should not put any similar button anywhere else.

But in Diffusion, that button is hidden behind a "Actions -> Manage" button, inside a screen that also has dozens of other admin actions. The clutter cost there is minimized.

I see. Maybe the root problem is that I'm in love with that Diffusion popup 🤔

In that case, we don't even need another button - just add a line to the "deleted message" that says something like "To completely remove the history from the database, contact your admin".

I change the visibility now.
I intuitional think the default permission is all users. But I'm wrong. The default permission is only myself. Maybe this is for privacy reasons?

Premising the user already have an Delete Document button.

I feel that adding such a button would clutter the UI.
Users should generally "know" that in order to really delete things, they need to go to the admin, because they don't have the permissions anyway; And adding that just for the once-in-a-while that the admin needs this...

I mean, we can maybe have a "Delete" button that just shows the related CLI command, like I've seen around (Diffusion maybe)

I don't think we actually allow "deleting" from the web ui, only hiding it (in the sense that the data is not removed from the database).

This feature request could also be expanded to:

(We cannot see screenshots like F1633808 - please set permissions to Visible To All Users - thanks)

(Marking as Resolved thanks to the mentioned patch - feel free to reopen and thanks)

Since Subversion allows to checkout just a sub-directory,

To quickly double-check the backend logic, to understand why it really likes an array:

Be more friendly against the backend logic, and with PhabricatorStandardCustomFieldLink

Uh. Yes, for example PhabricatorCustomField::ROLE_DEFAULT is maybe a good choice, just to be sure to obtain its definition whatever its "frontend role"

git rebase master again :) ready.

Tested again with git rebase master. Ready.

Thanks for the reminder!

Update comments

It also effects the PhabricatorCustomField::ROLE_APPLICATIONSEARCH condition, and possibly actually storing the data in some search-able table.
But try other roles - maybe it will work anyway.

( Welcome in Phorge \o/ you are now a Trusted Contributors - feel free to escalate as Task under Phame with a copy-paste for additional visibility, since it seems a super-appreciated Feature Requests )

Awesome thanks

Hi @20after4
Maybe I should ask this following question in a new Ponder?

Thanks for your advise!

I’m not sure about Permalink being a top-level button. Maybe under the View Options menu?

ready for review, flagged the thing as side-effect

Maybe better to land this to help the author. The author cannot receive email notifications.

move }

lint

I'm a bit happy that:

keep the original optimization about $is_claim, defined only in case

Thanks again for this proposed solution. I have now a big picture and I partially agree on the approach: the fix is there, in touching the manually-set claim action, but maybe we can just mute that "non-effective manual transaction" instead of dropping it. And anyway, we can maybe recycle some code about finding that transaction.

avoid to touch line 327

Evaluate the suggested refactor just for readability reasons :) fine also without that.

Mission accomplished.
Thanks

I suggest to visit here:

I thought this was already in the repo, but I forgot to execute arc land... (sorry)
I bump into a 403 error when I execute it now.
I had one merge conflict in resources/celerity/map.php which I corrected manually.

Perhaps a single new sound is enough to change the world.