Page MenuHomePhorge

Arc liberate: support traits
ClosedPublic

Authored by avivey on Mar 4 2024, 15:49.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 20, 18:11
Unknown Object (File)
Thu, May 16, 07:26
Unknown Object (File)
Fri, May 10, 00:16
Unknown Object (File)
Fri, May 10, 00:16
Unknown Object (File)
Fri, May 10, 00:16
Unknown Object (File)
Fri, May 10, 00:16
Unknown Object (File)
Wed, May 8, 04:32
Unknown Object (File)
Wed, May 1, 01:46

Details

Summary

Looks like this is all that's needed?

Ref T15751

Test Plan

R12 has some scenarios for testing this.
Also ran arc liberate --clean on arc and phorge repos, and the generated map did not change.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey requested review of this revision.Mar 4 2024, 15:49
support/lib/extract-symbols.php
263

Maybe this unset is not that needed

Thanks. Premising I have only knowledge of traits, but not mapbuilder.

  1. The test plan mentions arc lint --clean. Maybe was arc liberate --clean (?) since the first one does not work for me. The second one works 👍
  2. Maybe off-topic but that readme (https://we.phorge.it/diffusion/12/browse/master/libph-trait/) mentions a arc test-traits but I'm not able to have that command working. I get Unknown command.
  3. Just that inline comment :)

Approving since I confirm arc anoid still works after this change

This revision is now accepted and ready to land.Mar 10 2024, 07:37
  1. (Yes, arc liberate --clean. I'll also run it in Phorge).
  2. I'll check it again, I refactored some things and maybe I broke that.

✅ Double-accept

There is still that minor inline comment here, maybe interesting

support/lib/extract-symbols.php
263

Maybe not, but this is actually a very long script, and not a method, so I figured it would be safer to delete the variable instead of leaking it out for later.

I'll try to just extract a method out of this, that would be even safer...

(and I made sure this new function isn't exported to the arc lib namespace)

This revision was automatically updated to reflect the committed changes.