Page MenuHomePhorge
Feed Advanced Search

Jul 18 2023

valerio.bozzolan added a comment to T15556: Improve Diffusion identity reassignment propagation.

Thanks! Now the second step is, finding at least one file that is related to the generation of the above feeds / texts

Jul 18 2023, 12:54 · Bug Reports, Diffusion
smith renamed T15556: Improve Diffusion identity reassignment propagation from Show the Assigned Identity from Diffusion Commits pages to Improve Diffusion identity reassignment propagation.
Jul 18 2023, 12:53 · Bug Reports, Diffusion
valerio.bozzolan added a comment to T15556: Improve Diffusion identity reassignment propagation.

I'm not able to provide a smart title for this Task :D Thanks for any help in this

Jul 18 2023, 12:51 · Bug Reports, Diffusion
valerio.bozzolan closed Q59: Diffusion Identity reassignment doesn't propagate correctly as obsolete.
Jul 18 2023, 12:49 · People, Diffusion, Bug Reports
valerio.bozzolan added a comment to Q59: Diffusion Identity reassignment doesn't propagate correctly.

We can continue the discussion in Task T15556 - thanks for reporting

Jul 18 2023, 12:49 · People, Diffusion, Bug Reports
valerio.bozzolan triaged T15556: Improve Diffusion identity reassignment propagation as Low priority.
Jul 18 2023, 12:48 · Bug Reports, Diffusion
Sten closed T15476: PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of Diffusion repo as Resolved by committing rPcb9fcf18d5c3: Fix PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of….
Jul 18 2023, 08:06 · Diffusion, PHP 8 support

Jul 17 2023

aklapper placed T15476: PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of Diffusion repo up for grabs.

I currently don't have time to work on this so feel free to improve the diff (via arcanist/bin/arc patch D25296 / arcanist/bin/arc diff --update D25296).

Jul 17 2023, 13:23 · Diffusion, PHP 8 support
Sten reassigned T15476: PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of Diffusion repo from Sten to aklapper.

Andre already has a diff already out for this...

Jul 17 2023, 13:05 · Diffusion, PHP 8 support
Sten added a revision to T15476: PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of Diffusion repo: D25354: Fix PHP 8.1 strlen(null) when taking a repo out of maintenance mode..
Jul 17 2023, 13:02 · Diffusion, PHP 8 support
Sten claimed T15476: PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of Diffusion repo.

Have replicated the fault.

Jul 17 2023, 13:01 · Diffusion, PHP 8 support

Jul 11 2023

avivey added a comment to T15533: Bug: Unhandled Exception ("Exception") - Diff Parse Exception: Expected '\ No newline at end of file'..
  • the setlocal isn't supposed to make a difference (it only applies the command string itself - ie if a file is named 🧆.txt.
  • Setting E is more likely to cause this problem then to solve it...
Jul 11 2023, 18:31 · Localization, Bug Reports, Diffusion
avivey added a comment to T15533: Bug: Unhandled Exception ("Exception") - Diff Parse Exception: Expected '\ No newline at end of file'..

I think these two are related here:

Jul 11 2023, 17:25 · Localization, Bug Reports, Diffusion
avivey added a comment to T15533: Bug: Unhandled Exception ("Exception") - Diff Parse Exception: Expected '\ No newline at end of file'..

(I'm able to reproduce. Had to apt-get install language-pack-hu for that...)

Jul 11 2023, 17:08 · Localization, Bug Reports, Diffusion

Jul 10 2023

avivey added a project to T15528: Diffusion commit Feed: avoid to show the author twice (Authored by xxx) : Good Starter Task.
Jul 10 2023, 20:09 · UX, User-valerio.bozzolan, Diffusion
avivey edited projects for T15533: Bug: Unhandled Exception ("Exception") - Diff Parse Exception: Expected '\ No newline at end of file'., added: Bug Reports, Localization; removed Arcanist.
Jul 10 2023, 20:08 · Localization, Bug Reports, Diffusion

Jul 9 2023

valerio.bozzolan added a comment to Q59: Diffusion Identity reassignment doesn't propagate correctly.

Is there a Task about this? if not, feel free to open that in Diffusion at least. I'm interested in seeing this fixed.

Jul 9 2023, 21:45 · People, Diffusion, Bug Reports
valerio.bozzolan added a comment to Q59: Diffusion Identity reassignment doesn't propagate correctly.

Ouch sorry renamed again since I forgot the discussion. Still an annoying bug and found your question.

Jul 9 2023, 21:43 · People, Diffusion, Bug Reports
valerio.bozzolan updated Q59: Diffusion Identity reassignment doesn't propagate correctly from Diffusion Identity reassignment doesn't propagate correctly in People queries to Diffusion Identity reassignment doesn't propagate correctly.
Jul 9 2023, 21:42 · People, Diffusion, Bug Reports
valerio.bozzolan updated Q59: Diffusion Identity reassignment doesn't propagate correctly from Identity reassignment doesn't propagate correctly in Diffusion to Diffusion Identity reassignment doesn't propagate correctly in People queries.
Jul 9 2023, 21:41 · People, Diffusion, Bug Reports

Jul 7 2023

szotsaki added a comment to T15533: Bug: Unhandled Exception ("Exception") - Diff Parse Exception: Expected '\ No newline at end of file'..

It is on Diffusion > My repository > Selected commit SHA diff page. E.g. https://<domain>/R1:abdcdefgh

Jul 7 2023, 07:47 · Localization, Bug Reports, Diffusion

Jul 6 2023

valerio.bozzolan closed T15314: Diffusion commit with a Diff: "<user> added an edge" as Resolved by committing rP7bebfa289aa1: Diffusion commits: add some edge phrases about Revisions.
Jul 6 2023, 11:32 · User-valerio.bozzolan, UX, Diffusion
avivey added a comment to T15533: Bug: Unhandled Exception ("Exception") - Diff Parse Exception: Expected '\ No newline at end of file'..

Where exactly are you seeing this error? what page exactly?

Jul 6 2023, 06:47 · Localization, Bug Reports, Diffusion

Jul 5 2023

szotsaki created T15533: Bug: Unhandled Exception ("Exception") - Diff Parse Exception: Expected '\ No newline at end of file'..
Jul 5 2023, 21:27 · Localization, Bug Reports, Diffusion
valerio.bozzolan triaged T15528: Diffusion commit Feed: avoid to show the author twice (Authored by xxx) as Wishlist priority.
Jul 5 2023, 08:09 · UX, User-valerio.bozzolan, Diffusion

Jul 4 2023

valerio.bozzolan closed T15508: Locate File could accept initial "./" to speedup lazy terminal users as Resolved.

\o/

Jul 4 2023, 16:24 · User-valerio.bozzolan, UX, Diffusion

Jul 2 2023

avivey added a comment to T15443: Add Diffusion policy capability "Can Edit and View Identities".

Also, this mashes up Diffusion and Repositories to add confusion

Jul 2 2023, 20:04 · Diffusion, Policy
aklapper added a comment to T15443: Add Diffusion policy capability "Can Edit and View Identities".

I don't get the code.
src/applications/diffusion/controller/DiffusionIdentityViewController.php (note the View in its name) includes stuff like
$edit_uri = $this->getApplicationURI("identity/edit/{$id}/") defining ->setName(pht('Edit Identity')) (note the Edit here).
Also, this mashes up Diffusion and Repositories to add confusion (DiffusionIdentityEditController calls PhabricatorRepositoryIdentityEditEngine?).
I think I give up.

Jul 2 2023, 19:12 · Diffusion, Policy

Jul 1 2023

valerio.bozzolan added a comment to T15508: Locate File could accept initial "./" to speedup lazy terminal users.

I was honestly not aware of that. Interesting. Thanks!

Jul 1 2023, 10:18 · User-valerio.bozzolan, UX, Diffusion
avivey added a comment to T15508: Locate File could accept initial "./" to speedup lazy terminal users.

DO you know about arc browse?

Jul 1 2023, 06:58 · User-valerio.bozzolan, UX, Diffusion
valerio.bozzolan claimed T15508: Locate File could accept initial "./" to speedup lazy terminal users.
Jul 1 2023, 00:53 · User-valerio.bozzolan, UX, Diffusion
valerio.bozzolan added a revision to T15508: Locate File could accept initial "./" to speedup lazy terminal users: D25320: Locate File: allow to search './path/to/something.txt'.
Jul 1 2023, 00:49 · User-valerio.bozzolan, UX, Diffusion

Jun 30 2023

valerio.bozzolan triaged T15508: Locate File could accept initial "./" to speedup lazy terminal users as Wishlist priority.
Jun 30 2023, 13:19 · User-valerio.bozzolan, UX, Diffusion
aklapper added a comment to T15129: Unmark Audit as a required application.

.. and vice versa

Jun 30 2023, 10:18 · Diffusion, User-Cigaryno
Cigaryno added a project to T15423: PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding: Diffusion.
Jun 30 2023, 07:32 · Diffusion, PHP 8 support
Cigaryno added a project to T15476: PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of Diffusion repo: Diffusion.
Jun 30 2023, 07:29 · Diffusion, PHP 8 support

Jun 29 2023

Cigaryno updated the task description for T15129: Unmark Audit as a required application.
Jun 29 2023, 17:49 · Diffusion, User-Cigaryno
Cigaryno added a comment to T15129: Unmark Audit as a required application.

For archaeologists: canUninstall = false for Audit got set in rP11861265fe94fa97e4d0563c5bdb7b8cac27282d

Jun 29 2023, 17:47 · Diffusion, User-Cigaryno
Cigaryno added a project to T15443: Add Diffusion policy capability "Can Edit and View Identities": Diffusion.

It's important to restrict the ability to create Diffusion IDs.

Jun 29 2023, 15:23 · Diffusion, Policy

Jun 23 2023

jbo added a comment to T15491: Add config option for default branch name.
In T15491#10740, @speck wrote:

Just clarifying - this is for specifying the initial default value for the Default Branch field that can currently be edited after creation?

Jun 23 2023, 11:27 · Good Starter Task, Feature Requests, Diffusion
valerio.bozzolan updated the task description for T15489: Diffusion commit feed: avoid to repeat the commit message twice.
Jun 23 2023, 09:06 · UX, User-valerio.bozzolan, Diffusion
valerio.bozzolan updated the task description for T15489: Diffusion commit feed: avoid to repeat the commit message twice.
Jun 23 2023, 08:43 · UX, User-valerio.bozzolan, Diffusion
valerio.bozzolan added a comment to T15491: Add config option for default branch name.
In T15491#10740, @speck wrote:

Just clarifying - this is for specifying the initial default value for the Default Branch field that can currently be edited after creation?

Jun 23 2023, 08:40 · Good Starter Task, Feature Requests, Diffusion

Jun 22 2023

speck added a comment to T15491: Add config option for default branch name.

Just clarifying - this is for specifying the initial default value for the Default Branch field that can currently be edited after creation?

Jun 22 2023, 18:01 · Good Starter Task, Feature Requests, Diffusion
jbo created T15491: Add config option for default branch name.
Jun 22 2023, 16:10 · Good Starter Task, Feature Requests, Diffusion
valerio.bozzolan moved T15489: Diffusion commit feed: avoid to repeat the commit message twice from Backlog to Code Sprint Candidate on the User-valerio.bozzolan board.
Jun 22 2023, 14:40 · UX, User-valerio.bozzolan, Diffusion
valerio.bozzolan added a cover image to T15489: Diffusion commit feed: avoid to repeat the commit message twice.
Jun 22 2023, 14:39 · UX, User-valerio.bozzolan, Diffusion
valerio.bozzolan triaged T15489: Diffusion commit feed: avoid to repeat the commit message twice as Wishlist priority.
Jun 22 2023, 14:39 · UX, User-valerio.bozzolan, Diffusion
valerio.bozzolan moved T15314: Diffusion commit with a Diff: "<user> added an edge" from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Jun 22 2023, 14:29 · User-valerio.bozzolan, UX, Diffusion
valerio.bozzolan added a revision to T15314: Diffusion commit with a Diff: "<user> added an edge": D25306: Diffusion commits: add some edge phrases about Revisions.
Jun 22 2023, 14:28 · User-valerio.bozzolan, UX, Diffusion
valerio.bozzolan added a project to T15314: Diffusion commit with a Diff: "<user> added an edge": User-valerio.bozzolan.
Jun 22 2023, 14:28 · User-valerio.bozzolan, UX, Diffusion
valerio.bozzolan updated the task description for T15314: Diffusion commit with a Diff: "<user> added an edge".
Jun 22 2023, 14:25 · User-valerio.bozzolan, UX, Diffusion
valerio.bozzolan claimed T15314: Diffusion commit with a Diff: "<user> added an edge".
Jun 22 2023, 14:18 · User-valerio.bozzolan, UX, Diffusion
valerio.bozzolan updated the task description for T15314: Diffusion commit with a Diff: "<user> added an edge".
Jun 22 2023, 14:06 · User-valerio.bozzolan, UX, Diffusion
valerio.bozzolan added a comment to Q52: How to set the Pull Time Limit for Mercurial repos?.

Assuming this as Resolved but feel free to attach other details in the question itself and reopen :)

Jun 22 2023, 13:28 · Diffusion
valerio.bozzolan closed Q52: How to set the Pull Time Limit for Mercurial repos? as resolved.
Jun 22 2023, 13:28 · Diffusion

Jun 21 2023

aklapper added a comment to T15129: Unmark Audit as a required application.

For archaeologists: canUninstall = false for Audit got set in rP11861265fe94fa97e4d0563c5bdb7b8cac27282d

Jun 21 2023, 13:31 · Diffusion, User-Cigaryno

Jun 20 2023

valerio.bozzolan claimed T15256: Diffusion file: add a way to copy permalink.
Jun 20 2023, 09:31 · User-valerio.bozzolan, Diffusion

Jun 17 2023

valerio.bozzolan updated the task description for T15256: Diffusion file: add a way to copy permalink.
Jun 17 2023, 22:16 · User-valerio.bozzolan, Diffusion

Jun 16 2023

valerio.bozzolan moved T15256: Diffusion file: add a way to copy permalink from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Jun 16 2023, 23:37 · User-valerio.bozzolan, Diffusion
valerio.bozzolan added a revision to T15256: Diffusion file: add a way to copy permalink: D25301: Diffusion: add "Permalink" button.
Jun 16 2023, 23:09 · User-valerio.bozzolan, Diffusion

Jun 12 2023

avivey added a project to T15153: Document the special syntax you can use in commit messages to cause effects: Documentation.
Jun 12 2023, 07:43 · Documentation, Diffusion, User-valerio.bozzolan

Jun 7 2023

valerio.bozzolan merged task T15451: Implement Diffusion identity reassignment access control into T15443: Add Diffusion policy capability "Can Edit and View Identities".
Jun 7 2023, 15:52 · Policy, Security, Feature Requests, Diffusion
smith closed T15451: Implement Diffusion identity reassignment access control as Invalid.

It turns out that this is a duplicate:
T15443: Add Diffusion policy capability "Can Edit and View Identities"

Jun 7 2023, 12:01 · Policy, Security, Feature Requests, Diffusion
tinloaf added a comment to T15265: Exception when importing Mercurial repository with non-UTF-8 characters in filenames.

Our currently running version is git commit 1ba5c8c26095 from 2023-04-20, so that change should already be included. In fact, I can see the --encoding utf8 argument to hg in various logs.

Jun 7 2023, 10:35 · Diffusion
smith updated Q59: Diffusion Identity reassignment doesn't propagate correctly from Identity reassignment doesn't propagate correctly in Diffusion Commits search results to Identity reassignment doesn't propagate correctly in Diffusion.
Jun 7 2023, 10:20 · People, Diffusion, Bug Reports
valerio.bozzolan added a comment to Q59: Diffusion Identity reassignment doesn't propagate correctly.

Oh sorry I love to randomly rename things :D

Jun 7 2023, 10:19 · People, Diffusion, Bug Reports
valerio.bozzolan updated Q59: Diffusion Identity reassignment doesn't propagate correctly from Identity reassignment doesn't propagate correctly in Diffusion "Recent commits" (/people/commits/) to Identity reassignment doesn't propagate correctly in Diffusion Commits search results.
Jun 7 2023, 10:18 · People, Diffusion, Bug Reports
smith added a comment to Q59: Diffusion Identity reassignment doesn't propagate correctly.

No, your edit is not correct. The same happens in search, as I indicated in the description:

or craft a query for Diffusion commits, specifying X as author

So if after following my instructions you go to /diffusion/commit/query/all/, you see all of the commits with the author field correctly displayed. If, however, you proceed to editing a query and you select user X as author, you get the "old state".

Jun 7 2023, 10:17 · People, Diffusion, Bug Reports
valerio.bozzolan added a comment to Q59: Diffusion Identity reassignment doesn't propagate correctly.

Let's try to reduce the surface

Jun 7 2023, 10:14 · People, Diffusion, Bug Reports
valerio.bozzolan updated Q59: Diffusion Identity reassignment doesn't propagate correctly from Identity reassignment doesn't propagate correctly in Diffusion to Identity reassignment doesn't propagate correctly in Diffusion "Recent commits" (/people/commits/).
Jun 7 2023, 10:13 · People, Diffusion, Bug Reports
smith added a comment to T15451: Implement Diffusion identity reassignment access control.

But, they identities probably should be editable only for:

  • people who can edit the repository (people who administer it)
  • you, if the email matches yours (since you somehow pushed in the repository)
Jun 7 2023, 10:08 · Policy, Security, Feature Requests, Diffusion
valerio.bozzolan added a project to T15451: Implement Diffusion identity reassignment access control: Policy.
Jun 7 2023, 10:04 · Policy, Security, Feature Requests, Diffusion
valerio.bozzolan added a project to T15451: Implement Diffusion identity reassignment access control: Security.

Uh thanks. Interesting. Yeah probably with considerations under Security probably.

Jun 7 2023, 10:03 · Policy, Security, Feature Requests, Diffusion
smith updated the question details for Q59: Diffusion Identity reassignment doesn't propagate correctly.
Jun 7 2023, 08:58 · People, Diffusion, Bug Reports
valerio.bozzolan updated the question details for Q59: Diffusion Identity reassignment doesn't propagate correctly.
Jun 7 2023, 08:36 · People, Diffusion, Bug Reports
smith added a comment to Q59: Diffusion Identity reassignment doesn't propagate correctly.

Done.

Jun 7 2023, 08:34 · People, Diffusion, Bug Reports
valerio.bozzolan added a comment to Q59: Diffusion Identity reassignment doesn't propagate correctly.

Ah sorry for this bug, please visit the files and set Public (I cannot see them)

Jun 7 2023, 08:27 · People, Diffusion, Bug Reports
smith closed Q60: Diffusion identity reassignment access control as invalid.
Jun 7 2023, 08:14 · Diffusion, Feature Requests
smith created T15451: Implement Diffusion identity reassignment access control.
Jun 7 2023, 08:14 · Policy, Security, Feature Requests, Diffusion
smith added a comment to Q60: Diffusion identity reassignment access control.

Ah, sorry. I'll create the ticket in a minute.

Jun 7 2023, 07:58 · Diffusion, Feature Requests
avivey added a comment to Q60: Diffusion identity reassignment access control.

(As a member of Trusted Contributors, you can use the "Create Task" button to directly file tickets in Maniphest. The "Ponder first" approach is/was mostly intended to keep non-community-members from flooding the task list).

Jun 7 2023, 07:57 · Diffusion, Feature Requests
smith added a project to Q60: Diffusion identity reassignment access control: Diffusion.
Jun 7 2023, 07:40 · Diffusion, Feature Requests
smith added a project to Q59: Diffusion Identity reassignment doesn't propagate correctly: Diffusion.
Jun 7 2023, 07:40 · People, Diffusion, Bug Reports

Jun 2 2023

speck added a comment to T15265: Exception when importing Mercurial repository with non-UTF-8 characters in filenames.

Could you check whether your install is running with this change? https://secure.phabricator.com/D21676

Jun 2 2023, 03:48 · Diffusion

Jun 1 2023

speck added a comment to Q52: How to set the Pull Time Limit for Mercurial repos?.

From the exception

STDERR
waiting for lock on working directory of /var/repo/8 held by process '112297' on host 'ec6149cd0a0b/f000037a'

It sounds like another hg process is operating on that repo at the time.

Jun 1 2023, 20:18 · Diffusion

May 25 2023

valerio.bozzolan closed T15370: PHP 8.1 "strlen(null)" exceptions block repository import as Resolved by committing rP5405134fa5db: Fix PHP 8.1 "strlen(null)" exception which can block repository imports.
May 25 2023, 14:15 · Bug Reports, Diffusion, PHP 8 support
valerio.bozzolan added a comment to T15370: PHP 8.1 "strlen(null)" exceptions block repository import.

Again @amit I know you have other things to do :) Can you just try to manually apply this patch?

May 25 2023, 10:02 · Bug Reports, Diffusion, PHP 8 support

May 18 2023

valerio.bozzolan added a comment to T15370: PHP 8.1 "strlen(null)" exceptions block repository import.

Hi @amit can you please confirm if D25204 fixes your problem? I tested it locally and it works, but having a double-check from you would be super-nice. Thanks!

May 18 2023, 21:13 · Bug Reports, Diffusion, PHP 8 support

May 8 2023

valerio.bozzolan added a revision to T15370: PHP 8.1 "strlen(null)" exceptions block repository import: D25204: Fix PHP 8.1 "strlen(null)" exception which can block repository imports.
May 8 2023, 15:02 · Bug Reports, Diffusion, PHP 8 support
valerio.bozzolan triaged T15370: PHP 8.1 "strlen(null)" exceptions block repository import as High priority.
May 8 2023, 15:01 · Bug Reports, Diffusion, PHP 8 support

May 1 2023

aklapper closed T15301: PHP 8.1 "strlen(null)" exception blocks loading icons when creating new Diffusion repository as Resolved by committing rP5a76e8d26232: Fix PHP 8.1 "strlen(null)" exception which blocks loading icons when creating….
May 1 2023, 20:01 · Diffusion, PHP 8 support
valerio.bozzolan triaged T15314: Diffusion commit with a Diff: "<user> added an edge" as Wishlist priority.
May 1 2023, 09:25 · User-valerio.bozzolan, UX, Diffusion

Apr 30 2023

aklapper closed T15300: PHP 8.1 "strlen(null)" exceptions block rendering the Diffusion page as Resolved by committing rP1b8294341916: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Diffusion page.
Apr 30 2023, 13:13 · Diffusion, PHP 8 support
aklapper added a comment to T15301: PHP 8.1 "strlen(null)" exception blocks loading icons when creating new Diffusion repository.

Actually this issue blocks loading most (all?) icons; also the favicon of the site.

Apr 30 2023, 08:47 · Diffusion, PHP 8 support
aklapper added a revision to T15301: PHP 8.1 "strlen(null)" exception blocks loading icons when creating new Diffusion repository: D25151: Fix PHP 8.1 "strlen(null)" exception which blocks loading icons when creating new Diffusion repository.
Apr 30 2023, 08:38 · Diffusion, PHP 8 support
aklapper created T15301: PHP 8.1 "strlen(null)" exception blocks loading icons when creating new Diffusion repository.
Apr 30 2023, 08:35 · Diffusion, PHP 8 support
aklapper added a revision to T15300: PHP 8.1 "strlen(null)" exceptions block rendering the Diffusion page: D25150: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Diffusion page.
Apr 30 2023, 08:08 · Diffusion, PHP 8 support
aklapper created T15300: PHP 8.1 "strlen(null)" exceptions block rendering the Diffusion page.
Apr 30 2023, 08:07 · Diffusion, PHP 8 support

Apr 26 2023

valerio.bozzolan updated the task description for T15280: Herald object Diffusion Commit: allow to add a Tag.
Apr 26 2023, 15:28 · User-valerio.bozzolan, Herald, Diffusion