Fix PHP 8.1 strlen(null) when taking a repo out of maintenance mode.
AbandonedPublic
Actions

Authored by Sten on Jul 17 2023, 13:02.

Tags

None

Referenced Files

	F3296048: D25354.1742966351.diff
	Tue, Mar 25, 05:19

	F3295190: D25354.1742951858.diff
	Tue, Mar 25, 01:17

	F3294985: D25354.1742948544.diff
	Tue, Mar 25, 00:22

	F3236206: D25354.1742166706.diff
	Sat, Mar 15, 23:11

	F3225033: D25354.1742090245.diff
	Sat, Mar 15, 01:57

	F3220014: D25354.1741800290.diff
	Tue, Mar 11, 17:24

	F3215857: D25354.1741666831.diff
	Mon, Mar 10, 04:20

	F3214739: D25354.1741585865.diff
	Sun, Mar 9, 05:51

Subscribers

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15476: PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of Diffusion repo

Summary

Fix PHP 8.1 strlen(null) when taking a repo out of maintenance mode.

Fixes T15476

Test Plan

./bin/repository maintenance --start "fooo" rMyRepo
./bin/repository maintenance --stop rMyRepo

Diff Detail

Repository

rP Phorge

Branch

maintmode (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 677
Build 677: arc lint + arc unit

Event Timeline

Sten created this revision.Jul 17 2023, 13:02

Owners added a reviewer: O1: Blessed Committers.Jul 17 2023, 13:02

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 17 2023, 13:02

Sten requested review of this revision.Jul 17 2023, 13:02

Harbormaster completed remote builds in B677: Diff 1135.Jul 17 2023, 13:02

D25296 already out for this

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

repository/

management/

PhabricatorRepositoryManagementMaintenanceWorkflow.php

2 lines

O1: Blessed Committers

Diff 1135

View Options

src/applications/repository/management/PhabricatorRepositoryManagementMaintenanceWorkflow.php

Fix PHP 8.1 strlen(null) when taking a repo out of maintenance mode.AbandonedPublicActions