Fix PHP 8.1 strlen(null) when taking a repo out of maintenance mode.
AbandonedPublic
Actions

Authored by Sten on Jul 17 2023, 13:02.

Tags

None

Referenced Files

	F3979541: D25354.1746539282.diff
	Mon, May 5, 13:48

	F3955858: D25354.1746468055.diff
	Sun, May 4, 18:00

	F3946089: D25354.1746446268.diff
	Sun, May 4, 11:57

	F3877851: D25354.1746210749.diff
	Thu, May 1, 18:32

	F3850731: D25354.1746115754.diff
	Wed, Apr 30, 16:09

	F3789322: D25354.1745917654.diff
	Mon, Apr 28, 09:07

	F3763653: D25354.1745839439.diff
	Sun, Apr 27, 11:23

	F3372136: D25354.1744248540.diff
	Wed, Apr 9, 01:29

Subscribers

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15476: PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of Diffusion repo

Summary

Fix PHP 8.1 strlen(null) when taking a repo out of maintenance mode.

Fixes T15476

Test Plan

./bin/repository maintenance --start "fooo" rMyRepo
./bin/repository maintenance --stop rMyRepo

Diff Detail

Repository

rP Phorge

Branch

maintmode (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 677
Build 677: arc lint + arc unit

Event Timeline

Sten created this revision.Jul 17 2023, 13:02

Owners added a reviewer: O1: Blessed Committers.Jul 17 2023, 13:02

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 17 2023, 13:02

Sten requested review of this revision.Jul 17 2023, 13:02

Harbormaster completed remote builds in B677: Diff 1135.Jul 17 2023, 13:02

D25296 already out for this

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

repository/

management/

PhabricatorRepositoryManagementMaintenanceWorkflow.php

2 lines

O1: Blessed Committers

Diff 1135

View Options

src/applications/repository/management/PhabricatorRepositoryManagementMaintenanceWorkflow.php

Fix PHP 8.1 strlen(null) when taking a repo out of maintenance mode.AbandonedPublicActions