Fix PHP 8.1 strlen(null) when taking a repo out of maintenance mode.
AbandonedPublic
Actions

Authored by Sten on Jul 17 2023, 13:02.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 12, 22:21

	Unknown Object (File)
	Mon, Apr 22, 22:15

	Unknown Object (File)
	Mon, Apr 22, 19:09

	Unknown Object (File)
	Mon, Apr 22, 18:42

	Unknown Object (File)
	Sun, Apr 21, 22:12

	Unknown Object (File)
	Fri, Apr 19, 04:14

	Unknown Object (File)
	Sun, Apr 14, 12:48

	Unknown Object (File)
	Sun, Apr 14, 12:27

Subscribers

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15476: PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of Diffusion repo

Summary

Fix PHP 8.1 strlen(null) when taking a repo out of maintenance mode.

Fixes T15476

Test Plan

./bin/repository maintenance --start "fooo" rMyRepo
./bin/repository maintenance --stop rMyRepo

Diff Detail

Repository

rP Phorge

Branch

maintmode (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 677
Build 677: arc lint + arc unit

Event Timeline

Sten created this revision.Jul 17 2023, 13:02

Owners added a reviewer: O1: Blessed Committers.Jul 17 2023, 13:02

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 17 2023, 13:02

Sten requested review of this revision.Jul 17 2023, 13:02

Harbormaster completed remote builds in B677: Diff 1135.Jul 17 2023, 13:02

D25296 already out for this

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

repository/

management/

PhabricatorRepositoryManagementMaintenanceWorkflow.php

2 lines

O1: Blessed Committers

Diff 1135

View Options

src/applications/repository/management/PhabricatorRepositoryManagementMaintenanceWorkflow.php

Fix PHP 8.1 strlen(null) when taking a repo out of maintenance mode.AbandonedPublicActions