Page MenuHomePhorge
Create Task
Maniphest T15476

PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of Diffusion repo
Closed, ResolvedPublic
Actions

Description

  1. PHP 8.2.7; Phorge at 1c098c273d06ea3cf8215245ea109f41c59593d9
  2. Go to Diffusion at http://phorge.localhost/diffusion/
  3. Select Create Repository in upper right corner to go to http://phorge.localhost/diffusion/edit/form/default/
  4. Select "Create Git Repository" to go to http://phorge.localhost/diffusion/edit/form/default/?vcs=git
  5. On the Create Repository page, in the Name field, enter gitMaint
  6. Select the Create Repository button and end up on http://phorge.localhost/diffusion/20/manage/
  7. On the terminal/CLI, run ./bin/repository maintenance --start "fooo" R20
  8. See output Put repository "R20" into maintenance mode.
  9. Run ./bin/repository maintenance --stop R20
[2023-06-14 19:21:40] EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=master, ref.master=97e163187418), phorge(head=repoMaintStartHistory, ref.master=1c098c273d06, ref.repoMaintStartHistory=0a4a34143528)
  #0 PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/repository/management/PhabricatorRepositoryManagementMaintenanceWorkflow.php:45]
  #1 PhabricatorRepositoryManagementMaintenanceWorkflow::execute(PhutilArgumentParser) called at [<arcanist>/src/parser/argument/PhutilArgumentParser.php:492]
  #2 PhutilArgumentParser::parseWorkflowsFull(array) called at [<arcanist>/src/parser/argument/PhutilArgumentParser.php:377]
  #3 PhutilArgumentParser::parseWorkflows(array) called at [<phorge>/scripts/repository/manage_repositories.php:22]

Revisions and Commits

rP Phorge
AbandonedD25354 Fix PHP 8.1 strlen(null) when taking a repo out of maintenance mode.
D25296rPcb9fcf18d5c3 Fix PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of…

Related Objects
Search...

Event Timeline

aklapper created this task.Jun 14 2023, 19:26
Herald added subscribers: Cigaryno, Matthew, chris and 2 others. · View Herald TranscriptJun 14 2023, 19:26
aklapper added a revision: D25296: Fix PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of Diffusion repo.Jun 14 2023, 19:31
aklapper updated the task description. (Show Details)Jun 14 2023, 20:14
Cigaryno added a project: Diffusion.Jun 30 2023, 07:29
Sten claimed this task.Jul 17 2023, 13:01
Sten subscribed.

Have replicated the fault.

Sten added a revision: D25354: Fix PHP 8.1 strlen(null) when taking a repo out of maintenance mode..Jul 17 2023, 13:02
Sten reassigned this task from Sten to aklapper.Jul 17 2023, 13:05

Andre already has a diff already out for this...

aklapper removed aklapper as the assignee of this task.Jul 17 2023, 13:23

I currently don't have time to work on this so feel free to improve the diff (via arcanist/bin/arc patch D25296 / arcanist/bin/arc diff --update D25296).

Sten closed this task as Resolved by committing rPcb9fcf18d5c3: Fix PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of….Jul 18 2023, 08:06
Sten claimed this task.
Sten added a commit: rPcb9fcf18d5c3: Fix PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of….