I noticed that Diffusion probably has an user message that could be improved:

aklapper added an edge: D123: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Upload SSH Public key settings dialog.

https://we.phorge.it/rPe3ad37f79259378ceaf2b75dd4937d106145a0f4#1006

Probably we should replace "added an edge" with "attached the patch" or something like that.

Note that from Differentials, the message is OK, thanks to this class probably:

https://we.phorge.it/source/phorge/browse/master/src/applications/differential/edge/DifferentialRevisionHasCommitEdgeType.php

So it seems that this is the class that does not produce that message:

https://we.phorge.it/source/phorge/browse/master/src/applications/diffusion/edge/DiffusionCommitHasRevisionEdgeType.php;7c1487e4dcfab19e0ef42cd4596780a37e0c8c4e

Probably because the last class is missing methods like getTransactionAddString(), etc.

Steps to reproduce

1. Visit a Diffusion commit
2. Attach a Differential Diff using Edit Related Objects → Edit Revisions

Proposal A/B

Current	Proposal