Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Diffusion page
ClosedPublic

Authored by aklapper on Apr 30 2023, 08:08.
Tags
None
Referenced Files
F1415712: D25150.id574.diff
Sun, Feb 25, 07:35
F1415710: D25150.id562.diff
Sun, Feb 25, 07:35
F1415313: D25150.id.diff
Sun, Feb 25, 06:53
F1415184: D25150.diff
Sun, Feb 25, 06:47
Unknown Object (File)
Fri, Feb 23, 04:14
Unknown Object (File)
Tue, Feb 20, 03:52
Unknown Object (File)
Tue, Feb 20, 02:40
Unknown Object (File)
Thu, Feb 15, 18:31

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15300

Test Plan

Applied these three changes (on top of D25144, D25145, D25146, D25147) and /diffusion/ finally rendered in web browser.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 30 2023, 08:10