Root problem is the https://we.phorge.it/source/phorge/browse/master/src/view/layout/AphrontSideNavFilterView.php with its styles: https://we.phorge.it/source/phorge/browse/master/webroot/rsrc/css/phui/phui-basic-nav-view.css

Yeah, I believe the most important adaptation is the //File a Bug Report// section saying that until you are confirmed as a "trusted contributor", you need to report bugs in the form of a Ponder question.

To implement this, you may want to start from this 🌈

(Oh sorry avivey, I have not noticed your priority action - I agree)

I do not (yet?) understand the use case of this task.

Indeed reported from a Wikimedia user about Wikimedia Phabricator.

I have a nice working version here, which renders the diagram with the drawio viewer javascript component:

• Fixes regression from missing html element

Anyway, even with this fix, for some reasons I can't still use this feature with a comment like {#0000ff} in my local installation 🤔 I'm confused since the unit test works.

This single-casing of a specific class is not ideal, but given the complexity of other proposals here I'd like to get the current four lines in. Any other opinions? :)

@valerio.bozzolan yes, just now. I have only realized that there is a fix already after opening the ticket raised as a concern. Hadn't checked this in the past few days, so here I am, finally with my account approved and the issue is fixed. Thank you. :)

@zajdee have you already tried to update to latest master? After 6ab2b56a1a4a6 I mean. Thanks for this confirmation

EDIT: This was already reported and resolved in T15802: Regression: HTML entities rendered as plain text in config option descriptions, I'm keeping the comment just to track this.

Thank you for testing. I think this looks good. In the one case that the old var is used it’s rendered as a string in pht so string assumption seems okay here.

One by one

thank you!

yarp

The underlying issue is way more contained now that rP7868ab3754fa is merged. I'm abandoning this revision to clean up my backlog.

Break long line into two

If we find 10 minutes, let's test this on every provider, as last time it gave us a little surprise on one of them

Oh neat, I see. Thanks!

Sounds like an outline-offset of a couple pixels or so would solve the general case, and individual elements that still look problematic could be revisited afterwards. I'm somewhat used to weird cut-offs and overlapping outlines and such myself, and I'd take that over missing outlines any day.

That is, what I get from setup issues at https://issuetracker.revi.xyz/config/issue/deprecations/ is to report it:

For completeness: Cf. T15808#17058

Also, phorge version and arcanist version is included in line 2.

@revi: Hi, could you please provide a list of steps to reproduce, if possible, and always exact Phorge version info? Thanks!

@revi: Hi, could you please provide a list of steps to reproduce, if possible, and always exact Phorge version info? Thanks!

Phorge saves CPU cycles

Or wrap a text with a background color - (something like What if I can change the background color here (and no italics)?)

To find it, I needed to put in loads of debugging. It seems to be an issue with PHP deferring the execution of the object destructor until after the Imbalanced AphrontWriteGuard check, even though the object was unset prior to the check.

Perhaps the real treasure was the friends you made along the way?

Also it's strange that the stack trace does not mention PhabricatorConduitAPIController

Thanks. Premising that I cannot reproduce the issue. I use arc diff and arc branches frequently without issues 🤔 Tested both with and without authentication.

Thanks again :) Giving right credits

For the sake of completeness: Please add mention of rPd519f75dfdee61bb109468aa708c47f53f3e5128. Thanks!

Use correct markup for comment about markup