Reports: Remove unused variable
ClosedPublic
Actions

Authored by aklapper on Apr 30 2024, 16:22.

Tags

None

Referenced Files

	F3299912: D25609.1743031193.diff
	Tue, Mar 25, 23:19

	F3299055: D25609.1743014689.diff
	Tue, Mar 25, 18:44

	F3290714: D25609.1742870825.diff
	Mon, Mar 24, 02:47

	F3249468: D25609.1742286241.diff
	Mon, Mar 17, 08:24

	F3220246: D25609.1741800661.diff
	Tue, Mar 11, 17:31

	F3220245: D25609.1741800660.diff
	Tue, Mar 11, 17:31

	F3220244: D25609.1741800659.diff
	Tue, Mar 11, 17:30

	F3147979: D25609.1741216742.diff
	Tue, Mar 4, 23:19

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP74e28bc2a7b0: Reports: Remove unused variable

Summary

This variable feels unneeded in this function. It may have a better and more fulfilling life after finding a new function.

Test Plan

Read slowly and aloud all code in the function.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Apr 30 2024, 16:22

Owners added a reviewer: O1: Blessed Committers.Apr 30 2024, 16:22

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptApr 30 2024, 16:22

aklapper requested review of this revision.Apr 30 2024, 16:22

Harbormaster completed remote builds in B1209: Diff 1914.Apr 30 2024, 16:22

Phorge saves CPU cycles

This revision is now accepted and ready to land.Apr 30 2024, 18:57

Closed by commit rP74e28bc2a7b0: Reports: Remove unused variable. · Explain WhyMay 1 2024, 09:44

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP74e28bc2a7b0: Reports: Remove unused variable.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

project/

controller/

PhabricatorProjectReportsController.php

5 lines

O1: Blessed Committers

Diff 1916

View Options

src/applications/project/controller/PhabricatorProjectReportsController.php

Reports: Remove unused variableClosedPublicActions